[DISCUSS] PIP-255: Support for Idempotent Commit and Abort.

2023-05-24 Thread play maker
Hi pulsar-dev community, I raised a pip to discuss : PIP-255: Support for Idempotent Commit and Abort. PIP link: https://github.com/apache/pulsar/issues/19744 And I have implemented it in PR: https://github.com/apache/pulsar/pull/20356 Regards, TheTumbled.

[DISCUSS] PIP-271: Add broker health check status into prometheus metrics #20147

2023-05-24 Thread vineeth p
Hello, Broker metrics don't have anything to indicate the health of the broker (to indicate if the broker is active). In Prometheus broker metrics which are used for monitoring, it will be useful if metrics also show the broker health. This way, Prometheus can automatically scrape the broker state

Re: [DISCUSS] PIP-271: Add broker health check status into prometheus metrics #20147

2023-05-24 Thread Enrico Olivelli
Vineeth, Il Mer 24 Mag 2023, 21:57 vineeth p ha scritto: > Hello, > > Broker metrics don't have anything to indicate the health of the broker (to > indicate if the broker is active). In Prometheus broker metrics which are > used for monitoring, it will be useful if metrics also show the broker >

Re: [DISCUSS] PIP-271: Add broker health check status into prometheus metrics #20147

2023-05-24 Thread Rajan Dhabalia
Thank you Vineeth for creating the PIP. This PIP will be useful to capture a broker's health as a part of metrics or dashboards and we can also set up various alerts on it. Generally we should check the status API of the broker for the HC/liveness probe in k8 instead of sanity because that can brin

Re: [DISCUSS] PIP-271: Add broker health check status into prometheus metrics #20147

2023-05-24 Thread vineeth p
Thanks Rajan and Enrico for reviewing. Rajan's answer covers it for the most part and as mentioned in the PIP already, by default this is disabled. Regards, Vineeth On Wed, May 24, 2023 at 2:01 PM Rajan Dhabalia wrote: > Thank you Vineeth for creating the PIP. This PIP will be useful to capture