RE: [DISCUSS] PIP-255: Assign topic partitions to bundle by round robin

2023-03-19 Thread lifepuzzlefun
Hi, pulsar community. I'm insterest in this topic and want to join the discussion : - ) I test to create one partitioned topic with 1024 partitions in a namespace with 256 bundle. the distribution for this topic is post below. key is the total assigned partition number to the bundle. value is

RE: [DISCUSS] PIP-255: Assign topic partitions to bundle by round robin

2023-03-19 Thread lifepuzzlefun
I'm interest on the implementation details. 1. where is the partition to bundle mapping stored?when upgrade origin logic to the new round robin logic. how the current code distinguish partition assigned by origin logic and the new created topic assign by round robin logic. 2. can you explain

Re: [DISCUSS] PIP-246: Improved PROTOBUF_NATIVE schema compatibility checks without using avro-protobuf

2023-03-19 Thread Asaf Mesika
On Wed, Mar 15, 2023 at 5:46 PM SiNan Liu wrote: > 1. > > > > Why? The root message name is not written over the wire to the best of > my > > > knowledge. I haven't found it written in the official doc. > > > The name of the root message check is the rules in the previous > `ProtobufNativeSchemaC

Re: [DISCUSS] PIP-246: Improved PROTOBUF_NATIVE schema compatibility checks without using avro-protobuf

2023-03-19 Thread Asaf Mesika
Also: (2) PROTOBUF_NATIVE was designed so that not use avro-protobuf for protobuf > schema compatibility checking. The root message name is the class name we pass in when we create the > producer or consumer. ProtoBuf has many nested messages or dependencies. > The current implementation only che

Re: [Discuss] PIP-256: Building Great Developer Experience with API Content

2023-03-19 Thread Asaf Mesika
I'll rephrase what I mean. Why I finish reading https://github.com/apache/pulsar/issues/19755, I should be able to answer the following questions, *without* resorting to reading external links (i.e. Google Doc): 1. What exactly is problematic with current API docs? List concisely a bullet point l

Re: New Pulsar docs (API + CLI) are available!

2023-03-19 Thread Asaf Mesika
Good work - this makes the API documentation better for end users and less confusing. One small note: https://pulsar.apache.org/docs/next/admin-api-tutorial/ - I didn't find a tutorial there, mainly setup instructions. On Fri, Mar 17, 2023 at 11:13 AM Max Xu wrote: > Yu , Thanks for driving th

Re: [DISCUSS] PIP-246: Improved PROTOBUF_NATIVE schema compatibility checks without using avro-protobuf

2023-03-19 Thread SiNan Liu
1. > message SearchReq { string query = 1; int32 page_number = 2; int32 > result_per_page = 3;} > Then second version I use: > message SearchRequest { string query = 1; int32 page_number = 2; > int32 result_per_page = 3;} The rule in PIP improve the previous implementation, so the previous imple

RE: Re: [DISCUSS] PIP-186: Introduce two phase deletion protocol based on system topic

2023-03-19 Thread Horizon
> Penghui suggested instead of communicating via Admin API we use the same > methodology used in the new load balancer - using a compacted topic as a > queue: > The system topic you create will have compaction enabled. > You write the pending ledger delete, and the key is ledger-ID and > ledger-typ

Re: [DISCUSS] PIP-258: Deprecation of the consumer subscribeTopicMode configuration

2023-03-19 Thread Baodi Shi
> > Should we state in the PIP which version it will be removed? > I think adding is best, but I'm not quite sure which version we should be specific to. How about v3.2.0? Wait for 2 major versions (3.0.0 and 3.1.0) Thanks, Baodi Shi 在 2023年3月17日 15:16:19 上,Zike Yang 写道: > LGTM. +1 > It will

Re: New Pulsar docs (API + CLI) are available!

2023-03-19 Thread Yu
Thank you, Max and Asaf! > One small note: https://pulsar.apache.org/docs/next/admin-api-tutorial/ - I didn't find a tutorial there, mainly setup instructions. Yes, this is a known issue, which will be optimized later. On Sun, Mar 19, 2023 at 9:51 PM Asaf Mesika wrote: > Good work - this make

[VOTE] Pulsar Release 2.9.5 Candidate 1

2023-03-19 Thread Cong Zhao
This is the third release candidate for Apache Pulsar, version 2.9.5. This release contains 82 commits by 30 contributors. https://github.com/apache/pulsar/compare/v2.9.4...v2.9.5-candidate-1 *** Please download, test, and vote on this release. This vote will stay open for at least 72 hours ***

Re: [Discuss] PIP-256: Building Great Developer Experience with API Content

2023-03-19 Thread Yu
Hi Asaf, Thanks for your explanations! Now I understand your point. I've summarized the doc issues, solutions, corresponding changes, task status, and more here [1]. Also, add the link to the issue. PTAL, TIA! [1] https://docs.google.com/document/d/1NWmfDyIyUGzXOqX8V28AHyORF72lTFIvxlM6n86wAfU/ed