Re: [DISCUSS] PIP-246: Improved PROTOBUF_NATIVE schema compatibility checks without using avro-protobuf

2023-03-05 Thread Asaf Mesika
On Wed, Mar 1, 2023 at 4:33 PM SiNan Liu wrote: > > > > Can you please explain how a Protobuf Schema descriptor can be validated > > for backward compatibility check using Avro based compatibility rules? > > Doesn't it expect the schema to be Avro, but it is actually a Protobuf > > descriptor? >

Re: [Discuss] PIP-248: Add backlog eviction metric

2023-03-05 Thread Asaf Mesika
On Thu, Mar 2, 2023 at 12:57 PM 太上玄元道君 wrote: > > I think you should fix this explanation: > > Thanks! I would like to copy the context you provide to the PIP motivation, > your description is more detailed, so developers don't have to go through > the code. > Sure > > > Today the quota is ch

Re: [VOTE]PIP-247: Notifications for partitions update.

2023-03-05 Thread Asaf Mesika
+1with note: I think the discussion thread has not reached consensus. On Thu, Mar 2, 2023 at 1:21 PM houxiaoyu wrote: > Dear Community, > > I would like to start a VOTE on "PIP-247: Notifications for partitions > update." > > The proposal can be read at [0] and the discussion thread is availabl

Re: [DISCUSS] PIP-253: Expose producer metrics for deadLetterProducer and retryLetterProducer

2023-03-05 Thread Asaf Mesika
I would rather see them as attributes of ConsumerStats . Add ProducerStats deadLetterProducerStats; ProducerStats retryLetterProducerStats(); On Fri, Mar 3, 2023 at 2:54 AM Kai Levy wrote: > Hello! > > I created a new PIP because I discovered there's no way for a user to > access the metrics

Re: [VOTE] Pulsar Release 2.10.4 Candidate 1

2023-03-05 Thread Xiangying Meng
Hi, community, Sorry to tell everyone that we may need to abort the release 2.10.4-candidate-1 because some CI can not be passed after #19674 [0] is cherry-picked. I will be sure to carry out the release process again as soon as it is resolved. Sincerely Xiangying [0] https://github.com/apache/pu

Re: [DISCUSS] PIP-246: Improved PROTOBUF_NATIVE schema compatibility checks without using avro-protobuf

2023-03-05 Thread SiNan Liu
Hi! I updated the explanation of some things in the PIP issue. And also added a new “flag” in the conf is used as the different ProtobufNativeSchemaValidator implementation, also set ProtobufNativeSchemaValidator default only check whether the name of the root message is the same. Thanks, sinan

Re: [DISCUSS] PMC/Committer Emiratus status

2023-03-05 Thread Asaf Mesika
Thanks to everyone who took the time to carefully answer with detailed explanations. I personally learned a lot about Apache projects this way (made me read about it some more). So my personal recap is: - The goal of knowing the health of the Apache Pulsar community can be achieved by takin

Re: Please stop cherry-picking (breaking) changes to the released branches

2023-03-05 Thread Xiangying Meng
>Maybe it is better to start a discussion on the mailing list when you want to >cherry-pick something and wait for some time. >If nobody objects then it is good to go Because there are a large number of PRs that need to be cherry-picked, some PRs may not strictly abide by this agreement when cherr

Re: [PROPOSAL] Roadmap for 3.0 release

2023-03-05 Thread Cong Zhao
+1 Looks great! Thanks, Cong > 2023年2月18日 06:44,Matteo Merli 写道: > > Since the LTS release model has been formally approved, I'm proposing > the following schedule for the release: > > * Tue - 2023-05-11 > - RC-1 > - Code Freeze -- Only critical fixes will be merged in the 3.0 > rele

Re: [VOTE] Pulsar Node.js Client Release 1.8.1 Candidate 2

2023-03-05 Thread PengHui Li
+1 (binding) - Verified checksum and signature - Install from npm - Start a standalone and run the example following here [0] We should mention the following in the verification steps. 1. The pulsar_binary_host_mirror is required for the RC version 2. The example in README needs to copy to a .js

Re: [Vote] PIP-245: Make subscriptions of non-persistent topic non-durable

2023-03-05 Thread Yunze Xu
+1 (binding) Thanks, Yunze On Fri, Mar 3, 2023 at 11:46 AM PengHui Li wrote: > > +1 (binding) > > Penghui > > > On Feb 13, 2023, at 14:56, Jiuming Tao > > wrote: > > > > Hi all, > > > > I would like to start a VOTE on `PIP-245: Make subscriptions of > > non-persistent topic non-durable`. > >

Re: [DISCUSS] PIP-247: Notifications for partitions update

2023-03-05 Thread houxiaoyu
Bump. Are there other concerns or suggestions about this PIP :) Ping @ Michael @Joe @Enrico Thanks Xiaoyu Hou houxiaoyu 于2023年2月27日周一 14:10写道: > Hi Joe and Michael, > > I think I misunderstood what you replied before. Now I understand and > explain it again. > > Besides the reasons what Asaf m

Re: [VOTE]PIP-247: Notifications for partitions update.

2023-03-05 Thread houxiaoyu
Thanks Asaf, I will continue the discussion on the discussion thread Asaf Mesika 于2023年3月5日周日 21:16写道: > +1with note: I think the discussion thread has not reached consensus. > > > On Thu, Mar 2, 2023 at 1:21 PM houxiaoyu wrote: > > > Dear Community, > > > > I would like to start a VOTE on "PI