Re: [DISCUSS] PIP-186: Introduce two phase deletion protocol based on system topic

2023-02-13 Thread Asaf Mesika
On Mon, Feb 6, 2023 at 12:02 PM Yan Zhao wrote: > > > On 2023/02/05 14:40:10 Asaf Mesika wrote: > > On Fri, Feb 3, 2023 at 1:48 PM Yan Zhao wrote: > > > > > > If you persisted the message successfully by the producer and the > broker > > > > was terminated before being able to delete the ledger

Re: [DISCUSS] PIP-242 Topic name restrictions

2023-02-13 Thread Asaf Mesika
On Sat, Feb 11, 2023 at 6:01 AM wrote: > Hi guys. > > This is the refined PIP-242 discussion thread. Because we have discussed > some parts of this in another thread[0][1], we can start the standard PIP > discussion to reach a detailed consensus. > > You can check here[2] to see the PIP. > > > Be

Re: [DISCUSS] Retry topic should not create for a retry topic

2023-02-13 Thread Asaf Mesika
Sounds like a bug for sure. How did you plan on solving it? On Mon, Feb 13, 2023 at 12:46 AM Enrico Olivelli wrote: > Il Dom 12 Feb 2023, 04:42 Yubiao Feng .invalid> > ha scritto: > > > Hi Enrico Olivelli > > > > > It is good to help users to not fall into bad situations but on the > other > >

Re: [DISCUSS] PIP-245: Subscriptions expiration for NonPersistentTopic only

2023-02-13 Thread Asaf Mesika
Can we fail the client if they choose NonDurable subscription mode on a non-persistent topic, instead of writing WARN log messages? On Mon, Feb 13, 2023 at 4:26 AM guo jiwei wrote: > Agree,+1 > > > Regards > Jiwei Guo (Tboy) > > On Thu, Feb 9, 2023 at 7:07 PM Jiuming Tao > wrote: > > > > > > I

Re: [Vote] PIP-245: Make subscriptions of non-persistent topic non-durable

2023-02-13 Thread Asaf Mesika
I made a small comment on the PIP just now. On Mon, Feb 13, 2023 at 8:56 AM Jiuming Tao wrote: > Hi all, > > I would like to start a VOTE on `PIP-245: Make subscriptions of > non-persistent topic non-durable`. > > Motivation: > > There are two types of subscriptions for a topic: Durable and Non

Re: [DISCUSS] PIP-245: Subscriptions expiration for NonPersistentTopic only

2023-02-13 Thread Asaf Mesika
Clarifying: as Pengu wrote in the pip comment - if we change the default subscription mode to be non-durable for non-persistent topics, then what will happen to users who previously had durable subscriptions on that topic? Are we ruining something if we create non-durable subscriptions instead? O

[HELP WANTED] One of Pulsar's dependencies is Apache jClouds

2023-02-13 Thread Dave Fisher
Hi -, Anyone interested in Apache jClouds which Pulsar uses for Offloading / Tiered Storage should probably be aware that the project is thinking about moving to the Attic stoping active development. Anyone interested in jClouds continuing should subscribe to d...@jclouds.apache.org and ask ho

Re: [Discuss] Deprecate Index-based Publisher Stat Aggregation in Topics Partitioned-Stats

2023-02-13 Thread Heesung Sohn
Hi dev, If there are no particular concerns, I will send out a vote email. Thanks, Heesung On Tue, Jan 3, 2023 at 10:28 AM Heesung Sohn wrote: > Hi Pulsar dev, > > I raised a PIP for the default config change(change the > aggregatePublisherStatsByProducerName config default to true) as > reque

Re: [DISCUSS] PIP-242 Topic name restrictions

2023-02-13 Thread mattisonchao
Hi, Asaf Welcome to join this discussion. > You mean that allows the *system* to use it when it's a partitioned topic? Sorry, I didn't get your point. What do you mean by *system*? > Why postfix of `__`?Why uppercase ?Maybe `__system__`? Yes, That is a key point that I want to discuss in this thre

Re: [VOTE][PIP-240] A new API to unload subscriptions

2023-02-13 Thread Haiting Jiang
+1 binding Thanks Haiting On Mon, Feb 13, 2023 at 10:27 AM 丛搏 wrote: > > +1 (binding) > > Thanks, > Bo > > 易客 萧 于2023年2月13日周一 09:51写道: > > > > +1 (non-binding) > > > > From: Yubiao Feng > > Sent: Sunday, February 12, 2023 20:04 > > To: dev@pulsar.apache.org >

Re: [VOTE] PIP-175: Extend time based release process

2023-02-13 Thread Haiting Jiang
Hi Matteo, I noticed that 2.10 is not mentioned to be the first LTS version as discussed previously. Should we include this? Thanks, Haiting On Mon, Feb 13, 2023 at 10:26 AM Yunze Xu wrote: > > +1 (binding) > > Thanks, > Yunze > > On Thu, Feb 9, 2023 at 6:47 PM Nicolò Boschi wrote: > > > > +1

Re: [DISCUSS][PIP-226] Add JWKS support for AuthenticationProviderToken

2023-02-13 Thread Zixuan Liu
Ping Michael. Zixuan Liu 于2022年12月26日周一 11:07写道: > Hi Michael, > > Thank you for your suggestion! > > OIDC is very popular everywhere and makes great sense for Apache Pulsar. > Your OIDC plugin is excellent, it follows the OIDC standard and includes my > PIP idea. I'm looking forward to your OI

Re: [VOTE] PIP-175: Extend time based release process

2023-02-13 Thread Hang Chen
+1 (binding) Thanks, Hang Haiting Jiang 于2023年2月14日周二 10:27写道: > > Hi Matteo, > > I noticed that 2.10 is not mentioned to be the first LTS version as > discussed previously. > Should we include this? > > Thanks, > Haiting > > On Mon, Feb 13, 2023 at 10:26 AM Yunze Xu > wrote: > > > > +1 (bindi

Re: [VOTE] PIP-175: Extend time based release process

2023-02-13 Thread Michael Marshall
+1 (binding) Thanks for bringing this thread back, Matteo. Thanks, Michael On Mon, Feb 13, 2023 at 9:20 PM Hang Chen wrote: > > +1 (binding) > > Thanks, > Hang > > Haiting Jiang 于2023年2月14日周二 10:27写道: > > > > Hi Matteo, > > > > I noticed that 2.10 is not mentioned to be the first LTS version a

Re: [VOTE] PIP-175: Extend time based release process

2023-02-13 Thread mattisonchao
+1(non-binding) Best, Mattison On Feb 9, 2023, 04:44 +0800, Matteo Merli , wrote: > https://github.com/apache/pulsar/issues/15966 > > > > > ## Motivation > > In PIP-47 ( > https://github.com/apache/pulsar/wiki

Re: [VOTE] PIP-175: Extend time based release process

2023-02-13 Thread Enrico Olivelli
+1 (binding) Enrico Il Mar 14 Feb 2023, 07:51 ha scritto: > +1(non-binding) > > Best, > Mattison > On Feb 9, 2023, 04:44 +0800, Matteo Merli , wrote: > > https://github.com/apache/pulsar/issues/15966 > > > > > -

Re: [VOTE] Pulsar Client C++ Release 3.1.2 Candidate 1

2023-02-13 Thread Zike Yang
+1 (non-binding) - Build from source (macos x86_64 12.6) - Run example producer/consumer - Run perf producer/consumer. - Run unit tests I have found an issue when running the unit test [0]. But it seems not a regression bug and only affects the test code. So I am +1. [0] https://github.com/apach

Re: [DISCUSS] PIP-245: Subscriptions expiration for NonPersistentTopic only

2023-02-13 Thread Jiuming Tao
Hi Asaf, If we fail the client when users use Durable subscription to subscribe NonPersistentTopic, it will lead to break change. Users have to change their code, so we can change the `subscriptionMode` from `Durable` to `NonDurable` and print WARN log when users choose `Durable`, then, users