Re: [VOTE] PIP-175: Extend time based release process

2023-02-09 Thread Nozomi Kurihara
+1 The LTS plan seems clear and helpful for users. Thanks, Nozomi 2023年2月9日(木) 5:44 Matteo Merli : > https://github.com/apache/pulsar/issues/15966 > > > > > > ## Motivation > > In PIP-47 ( > https://github.

Re: [VOTE] PIP-237: Make PulsarAdmin accessible in SinkContext and SourceContext

2023-02-09 Thread Nicolò Boschi
+1 binding Nicolò Il giorno gio 9 feb 2023 alle 04:48 Zike Yang ha scritto: > +1 (non-binding) > > Thanks, > Zike Yang > > On Wed, Feb 8, 2023 at 11:08 PM Baodi Shi wrote: > > > > +1 (non-binding) > > > > > > Thanks, > > Baodi Shi > > > > > > 在 2023年2月8日 19:12:41 上,r...@apache.org 写道: > > > >

Re: [VOTE] PIP-237: Make PulsarAdmin accessible in SinkContext and SourceContext

2023-02-09 Thread PengHui Li
+1 (binding) Penghui > On Feb 9, 2023, at 17:26, Nicolò Boschi wrote: > > +1 binding > Nicolò > > Il giorno gio 9 feb 2023 alle 04:48 Zike Yang ha scritto: > >> +1 (non-binding) >> >> Thanks, >> Zike Yang >> >> On Wed, Feb 8, 2023 at 11:08 PM Baodi Shi wrote: >>> >>> +1 (non-binding) >>>

Re: [VOTE] PIP-175: Extend time based release process

2023-02-09 Thread PengHui Li
+1 (binding) Penghui > On Feb 9, 2023, at 17:24, Nozomi Kurihara wrote: > > +1 > > The LTS plan seems clear and helpful for users. > > Thanks, > Nozomi > > 2023年2月9日(木) 5:44 Matteo Merli : > >> https://github.com/apache/pulsar/issues/15966 >> >> >>

Re: [DISCUSS] PIP-245: Subscriptions expiration for NonPersistentTopic only

2023-02-09 Thread Zike Yang
> How about set `isDurable = false` when create `NonPersistentSubscription`? We could directly delete the `isDurable` in this constructor. There will be no durable subscriptions on the non-persistent topic anymore. > When the topic is non-persistent and uses durable to subscribe, print warns >

Re: [VOTE] PIP-175: Extend time based release process

2023-02-09 Thread Zike Yang
+1 (non-binding) Thanks, Zike Yang On Thu, Feb 9, 2023 at 5:28 PM PengHui Li wrote: > > +1 (binding) > > Penghui > > > On Feb 9, 2023, at 17:24, Nozomi Kurihara wrote: > > > > +1 > > > > The LTS plan seems clear and helpful for users. > > > > Thanks, > > Nozomi > > > > 2023年2月9日(木) 5:44 Matteo

Re: [VOTE] Pulsar Client C++ Release 3.1.2 Candidate 1

2023-02-09 Thread Baodi Shi
+1 (non-binding) * Verify checksum and signatures * Build from source (MacOS arm64 13.1) * Verify oauth2 set `TlsTrustCertsFilePath`(libpulsarwithdeps.a) * Verify the oauth2 set `TlsTrustCertsFilePath` on Node.js client Thanks, Baodi Shi 在 2023年2月9日 04:33:36 上,Matteo Merli 写道: > +1 > > -- >

Re: [VOTE] PIP-175: Extend time based release process

2023-02-09 Thread Nicolò Boschi
+1 (binding) Nicolò Boschi Il giorno gio 9 feb 2023 alle ore 11:17 Zike Yang ha scritto: > +1 (non-binding) > > Thanks, > Zike Yang > > On Thu, Feb 9, 2023 at 5:28 PM PengHui Li wrote: > > > > +1 (binding) > > > > Penghui > > > > > On Feb 9, 2023, at 17:24, Nozomi Kurihara wrote: > > > > > >

Re: [DISCUSS] PIP-245: Subscriptions expiration for NonPersistentTopic only

2023-02-09 Thread Jiuming Tao
It makes sense Thanks, Tao Jiuming > 2023年2月9日 15:44,Baodi Shi 写道: > > Agree, and we can add verification on the client side. When the topic is > non-persistent and uses durable to subscribe, print warns logs: > “non-persistent not support durable subscribe will use non-durable to > subscrib

Re: Pulsar Flaky test report 2023-02-07 for PR builds in CI

2023-02-09 Thread Nicolò Boschi
Sorry I haven't linked the google sheet: https://docs.google.com/spreadsheets/d/165FHpHjs5fHccSsmQM4beeg6brn-zfUjcrXf6xAu4yQ/edit#gid=1022097898 The most relevant are: org.apache.pulsar.broker.transaction.pendingack.PendingAckPersistentTest.testDeleteUselessLogDataWhenSubCursorMoved 42 Detailed r

Re: Pulsar Flaky test report 2023-02-07 for PR builds in CI

2023-02-09 Thread Lari Hotari
Thanks, very useful. -Lari On 2023/02/09 15:24:28 Nicolò Boschi wrote: > Sorry I haven't linked the google sheet: > https://docs.google.com/spreadsheets/d/165FHpHjs5fHccSsmQM4beeg6brn-zfUjcrXf6xAu4yQ/edit#gid=1022097898 > > > The most relevant are: > org.apache.pulsar.broker.transaction.pendin

Re: Pulsar Flaky test report 2023-02-07 for PR builds in CI

2023-02-09 Thread Yubiao Feng
Thanks, very useful +1. Yubiao Feng On Fri, Feb 10, 2023 at 5:45 AM Lari Hotari wrote: > Thanks, very useful. > > -Lari > > On 2023/02/09 15:24:28 Nicolò Boschi wrote: > > Sorry I haven't linked the google sheet: > > > https://docs.google.com/spreadsheets/d/165FHpHjs5fHccSsmQM4beeg6brn-zfUjcrXf

Re: [DISCUSS] Base64-encoded key/cert in the ClusterData

2023-02-09 Thread Michael Marshall
Is this the same ClusterData object stored in zookeeper? If so, it seems risky to store these certs there because many Pulsar components access ZK. I started work to support retrieving in-memory TLS certificates to the Java Client's ClientConfiguration object [0] but my priorities changed, and I w

Re: [VOTE] Pulsar Client C++ Release 3.1.2 Candidate 1

2023-02-09 Thread 丛搏
I run ./pulsar-tests block, ``` [ RUN ] BasicEndToEndTest.testMessageListenerPause 2023-02-10 14:53:57.415 INFO [0x101084580] BasicEndToEndTest:922 | res = 204 2023-02-10 14:53:57.415 INFO [0x101084580] ClientConnection:190 | [ -> pulsar://localhost:6650] Create ClientConnection, timeout=100

Re: [DISCUSS] Base64-encoded key/cert in the ClusterData

2023-02-09 Thread Zike Yang
It looks strange to fill a configuration item named `XXXFilePath` with the contents of the key/certs instead of the file path. Maybe adding new configs like `brokerClientKey`, `brokerClientCertificate`... would be more appropriate. Thanks, Zike Yang Zike Yang On Fri, Feb 10, 2023 at 2:54 PM