[DISCUSS] PIP-244: Refactor ByteBuf release method
Hello everyone. I hope you guys are all doing well. I would like to start
the discussion for PIP-244 https://github.com/apache/pulsar/issues/19350,
Please let me know if you have any concerns or questions.
--- Paste original PIP content to help
Yunze - in summary - your proposal is to get rid of the ServiceUrlProvider
right? You just want to have setServiceUrl on the client instead?
On Wed, Jan 25, 2023 at 2:03 PM Yunze Xu
wrote:
> It makes sense to me. So the better way is still providing the
> `updateXXX` methods to `PulsarClient`.
>
> Users can only create a topic with it if the topic is partitioned
You mean to say, if the topic is partitioned, the word "partition" can not
appear in the submitted topic name, in the topic creation API?
4. Make `enableStrictTopicName=true` in the future.
I think this PIP should go close to
Couples of notes:
1.
> In the LedgerDeletionService start, it will create a producer to send
> pending delete ledger.
> When delete a ledger, a PendingDeleteLedgerInfo msg with 1 min delay (the
> delay is for consumer side, if send it immediately, maybe the metadata
> din't change when consume
In summary, the core issue is that ServiceUrlProvider could be
misused. A user might want to implement its own ServiceUrlProvider by
changing the returned value of `get` method but it actually does not
work. The built-in implementations like AutoFailover actually work by
these `updateXXX` methods.
I disagree with using `ReferenceCountUtil.safeRelease()` everywhere.
The implementation is throwing any Throwable:
```java
public static void safeRelease(Object msg) {
try {
release(msg);
} catch (Throwable var2) {
logger.warn("Failed to release a message: {}", msg, var2);
> Otherwise, we end up having so many "feature flags" turned off, it's hard to
> navigate and improve Pulsar.
+1 to me. We already have too many feature flags.
Thanks,
Yunze
On Mon, Jan 30, 2023 at 12:17 AM Asaf Mesika wrote:
>
> >
> > Users can only create a topic with it if the topic is par
Congrats Nico!
On Mon, Jan 23, 2023 at 10:47 PM Zixuan Liu wrote:
> Congrats, Nicolò!
>
> Best,
> Zixuan
>
> Dave Fisher 于2023年1月21日周六 06:01写道：
>
> > Congratulations Nicolo!
> >
> > Best,
> > Dave
> >
> > > On Jan 20, 2023, at 6:57 AM, tison wrote:
> > >
> > > Congrats Nico! And well deserved
Congratulations, Baodi!
From: Yunze Xu
Sent: Wednesday, January 18, 2023 21:35
To: dev@pulsar.apache.org
Subject: [ANNOUNCE] New Committer: Baodi Shi
The Project Management Committee (PMC) for Apache Pulsar has invited
Baodi Shi (https://github.com/shibd) to beco
Congratulations, Bo!
From: PengHui Li
Sent: Wednesday, January 18, 2023 21:50
To: Dev
Subject: [ANNOUNCE] Bo Cong as new PMC member in Apache Pulsar
Hi all,
The Apache Pulsar Project Management Committee (PMC) has invited Bo Cong
(https://github.com/congbobo184)
Congratulations!
Thanks,
Cong
On 2023/01/18 13:35:41 Yunze Xu wrote:
> The Project Management Committee (PMC) for Apache Pulsar has invited
> Baodi Shi (https://github.com/shibd) to become a committer and we are
> pleased to announce that he has accepted.
>
> Being a committer enables easier con
Congratulations, Nicolò!
From: Lari Hotari
Sent: Friday, January 20, 2023 20:36
To: dev@pulsar.apache.org
Subject: [ANNOUNCE] Nicolò Boschi as new PMC member in Apache Pulsar
Dear Community,
We are thrilled to announce that Nicolò Boschi
(https://github.com/nico
Congratulations!
Thanks,
Cong
On 2023/01/18 13:50:12 PengHui Li wrote:
> Hi all,
>
> The Apache Pulsar Project Management Committee (PMC) has invited Bo Cong
> (https://github.com/congbobo184) as a member of the PMC and we are
> pleased to announce that he has accepted.
>
> He is very active in
Congratulations!
Thanks,
Cong
On 2023/01/20 12:36:54 Lari Hotari wrote:
> Dear Community,
>
> We are thrilled to announce that Nicolò Boschi
> (https://github.com/nicoloboschi) has been invited and has accepted the
> role of member of the Apache Pulsar Project Management Committee (PMC).
>
> Ni
Hi, Asaf, Yunze
> You mean to say, if the topic is partitioned, the word "partition" can
> notappear in the submitted topic name, in the topic creation API?
It's a little bit confusing. I will give some examples to help explain:
Create a topic:
• no corresponding partitioned topic
• persist
Congratulations! Bo
Best,
Max Xu
On Wed, Jan 18, 2023 at 9:50 PM PengHui Li wrote:
> Hi all,
>
> The Apache Pulsar Project Management Committee (PMC) has invited Bo Cong
> (https://github.com/congbobo184) as a member of the PMC and we are
> pleased to announce that he has accepted.
>
> He is v
Congratulations! Nicolò
Best,
Max Xu
On Fri, Jan 20, 2023 at 8:36 PM Lari Hotari wrote:
> Dear Community,
>
> We are thrilled to announce that Nicolò Boschi
> (https://github.com/nicoloboschi) has been invited and has accepted the
> role of member of the Apache Pulsar Project Management Commit
Congratulations! Baodi
Best,
Max Xu
On Wed, Jan 18, 2023 at 9:36 PM Yunze Xu wrote:
> The Project Management Committee (PMC) for Apache Pulsar has invited
> Baodi Shi (https://github.com/shibd) to become a committer and we are
> pleased to announce that he has accepted.
>
> Being a committer e
Congratulations !
Best
Xiaoyu Hou
Max Xu 于2023年1月30日周一 12:34写道：
> Congratulations! Nicolò
>
> Best,
> Max Xu
>
>
> On Fri, Jan 20, 2023 at 8:36 PM Lari Hotari wrote:
>
> > Dear Community,
> >
> > We are thrilled to announce that Nicolò Boschi
> > (https://github.com/nicoloboschi) has been invi
19 matches
Mail list logo
