Re: [DISCUSS] Redundant ServiceUrlProvider design and improper use of PIP-121

2023-01-24 Thread Asaf Mesika
If I understand correctly, the idea of having the ability to change serviceUrl is to support switching over between clusters dynamically? If that is the case, doesn't it make sense that it will trigger the change to the client instead of the client polling it and check it self if something has chan

Re: [DISCUSS] Registering Jackson Java 8 support modules by default for all Pulsar components, including client

2023-01-24 Thread Asaf Mesika
This was a clear explanation. Thanks! On Mon, Jan 23, 2023 at 10:40 AM Lari Hotari wrote: > A potential breaking change would be the case when Java 8 support module > hasn't been registered and Jackson seems to serialize and de-serialize the > objects successfully, but with a obscure JSON struct

[VOTE] PIP-241: TopicEventListener / topic events for the BrokerService.

2023-01-24 Thread Andrey Yegorov
I am starting VOTE for the proposed implementation of PIP-241. https://github.com/apache/pulsar/pull/19153 for PIP-241: TopicEventListener / topic events for the BrokerService. PIP issue: https://github.com/apache/pulsar/issues/19224 Discussion thread: https://lists.apache.org/thread/n3y4wc7r848

Re: [DISCUSS] PIP-241: TopicEventListener / topic events for the BrokerService

2023-01-24 Thread Michael Marshall
This proposal looks good to me. I left some minor feedback on the PR. I agree with Enrico that this would be a helpful framework to use internally in Pulsar. Thanks, Michael On Thu, Jan 19, 2023 at 10:24 AM Andrey Yegorov wrote: > > Hi Haiting, > > Currently there are no plans to use TopicEvent

Re: [VOTE] PIP-241: TopicEventListener / topic events for the BrokerService.

2023-01-24 Thread Michael Marshall
+1 (binding) Thanks, Michael On Tue, Jan 24, 2023 at 10:13 AM Andrey Yegorov wrote: > > I am starting VOTE for the proposed implementation of PIP-241. > > https://github.com/apache/pulsar/pull/19153 for PIP-241: TopicEventListener > / topic events for > the BrokerService. > > PIP issue: https:/