+1 (binding)
Thanks,
Hang
Yunze Xu 于2022年12月28日周三 11:53写道：
>
> After discussing with @hangc0276 offline, I decided to add a
> `Schema` implementation in this proposal to serialize
> both the owner topic and the base `MessageId`. You can see the latest
> update on GitHub. If any of you have any c
Schema doesn't make much sense to me.
Schema is a Pulsar Client API to deal with Message serialisation, it
is not a general purpose serde framework.
I still approve the PIP overall but I don't think we should expose
such things to the user facing APIs
Il giorno mer 28 dic 2022 alle ore 09:15 Han
I agree with you.
Please note that the new test case is about non-persistent topics
is it expected ?
Enrico
Il giorno mer 28 dic 2022 alle ore 07:58 Yubiao Feng
ha scritto:
>
> Hi qiang
>
> I think this is a necessary fix, and it would be nice if more explicit
> errors were given to the client
Hi Mattison,
I'm not sure if this is the current behavior, I left a comment in the PR
Thanks,
Bo
Enrico Olivelli 于2022年12月28日周三 16:27写道：
>
> I agree with you.
>
> Please note that the new test case is about non-persistent topics
>
> is it expected ?
>
> Enrico
>
> Il giorno mer 28 dic 2022 alle
+1 (binding)
Verified
- Checksum and signatures
- Build from source with JDK8 and maven 3.8.6
- Checked BookKeeper so lib
- Start standalone cluster and run pulsar perf produce and consume
- Run pulsar-lakehouse-connectors based on this release
Thanks,
Hang
Haiting Jiang 于2022年12月25日周日 16:
Thank you all,
Close the vote with 3 bindings(PengHui, Haiting, Hang), and 4
non-bindings(Xiangying, Yunze).
I will continue the release process.
Thanks,
Bo
Hang Chen 于2022年12月28日周三 18:29写道：
>
> +1 (binding)
>
> Verified
> - Checksum and signatures
> - Build from source with JDK8 and maven
+1 (binding)
Verify following the steps from
https://github.com/RobertIndie/pulsar-client-node-validation
- Start standalone (master branch)
- Start consumer (node ./examples/consumer.js)
- Start producer (node ./examples/producer.js)
- The consumer can receive the messages
Regards,
Penghui
On
Hi, Enrico
> Please note that the new test case is about non-persistent topics
I'm sorry, It's my mistake, the non-persistent already fix this problem, I need
to change the test topic name to persistent.
Best,
Mattison
On Dec 28, 2022, 16:27 +0800, Enrico Olivelli , wrote:
> I agree with you.
>
>
+1 (binding)
Verified
- Checksum and signatures
- Build from source with JDK17 and maven 3.8.6
- Checked BookKeeper so lib
- Start standalone cluster and run pulsar perf produce and consume
- Run pulsar-lakehouse-connectors based on this release
Thanks,
Hang
guo jiwei 于2022年12月28日周三 11:21写
-1 (binding)
When checking the `apache-pulsar-shell-2.11.0-shell.tar.gz` license, I
found a lot of third party jars are not included in the LICENSE file.
Thanks,
Hang
Haiting Jiang 于2022年12月27日周二 20:26写道：
>
> +1 (binding)
>
> - Checksum and signatures
>
> - Built from sources using JDK 17 and m
Hmmm
I found that if we want to provide the public API(shared event loop) in the
pulsar-client-api module.
We need to add Netty dependency to the pulsar-client-api module.
It's not a good idea to have Netty dependency in the pulsar-client-api
module.
Maybe we can add the new API to the pulsar-cli
Hi Enrico,
Yeah, I've discussed it privately with Hang and he had the same
concern with you and. So I changed the `Schema` to a
more simple class:
```java
class TopicMessageIdSerDes {
public static byte[] serialize(TopicMessageId topicMessageId) {/* ... */}
public static TopicMessageId d
> Maybe we can add the new API to the pulsar-client-original module? like we
> currently do.
Adding stable APIs to the pulsar-client-original module that
represents the internal implementations is not a good way IMO. I'm
wondering why we need to configure a Netty EventLoop? Is there any
alternati
Hi, All
I have another question that needs to discuss.
Should we allow the user to create the non-partitioned topic name like
`persistent://tenant/namespace/localname-partition-0`?
If so, this is a little confusing with the partitioned topic.
e.g.:
TopicName#isPartitioned method.
Best,
Mattis
Hi Mattison,
> Should we allow the user to create the non-partitioned topic name like
> `persistent://tenant/namespace/localname-partition-0`?
I think we should disallow creation. This will cause the partition
metadata to be incorrect.
If the current behavior is to allow the creation, modifying
15 matches
Mail list logo
