Re: [DISCUSS] Remove restful producer component

2022-12-07 Thread Jiaqi Shen
+1 By the way, why the restful consumer still not be completed? Thanks, Jiaqi Shen Haiting Jiang 于2022年12月7日周三 15:56写道: > > I think we can remove it first because it is not a complete feature. > Anyone interested in working on it can find the code from the git history > and migrate it to anot

Re: [DISCUSS] Proposal required for Admin API/CLI and metrics changes

2022-12-07 Thread PengHui Li
> I agree a proposal would be better before adding a PR. But the document part must be a part of such a proposal. Make sense. It looks like we should have a checklist for the proposal. The documentation changes should be listed in the proposal. > Can the PR template/GitHub process check that if e

Re: [DISCUSS] How to handle broker public API changes

2022-12-07 Thread Haiting Jiang
Hi all, We already have working procedures to change the public API, like PIP , mail-discussion and the PR templates. >From what I understand, the problem is more like how to provide a clear and proper definition of "Broker Public API". I believe it's the reason why PIP-136 updated the method sign

Re: [VOTE] Pulsar Release 2.11.0 Candidate-2

2022-12-07 Thread PengHui Li
> I'm wondering whether affecting the resource quota. Could you confirm that? Hmmm, I haven't heard of anyone using this feature. I think it should be ok for a standalone. Penghui On Wed, Dec 7, 2022 at 1:33 PM Zixuan Liu wrote: > > If it only affects standalone. I think it’s ok. > > Right. >

Re: [DISCUSS] Proposal required for Admin API/CLI and metrics changes

2022-12-07 Thread Haiting Jiang
+1 for enforcing the PIP procedures. > And the CI can try to add labels `doc required` or `wants/proposal` > according to the list selections. Is it possible that the CI can check if there is a "voted" PIP linking to this PR. And the label can be manually added by committers if the PR author miss

Re: [DISCUSS] How to handle broker public API changes

2022-12-07 Thread Nicolò Boschi
> > The root cause is that we don't have an API abstraction for the > pulsar-broker module +1 I think that's reasonable to think about the pulsar-broker module as internal and to not take care of retrocompatibility. If we have the desire to expose the broker service classes in a compatible way,

[GitHub] [pulsar] nicoloboschi added a comment to the discussion: connect to broker in standalone mode via Kubernetes

2022-12-07 Thread GitBox
GitHub user nicoloboschi added a comment to the discussion: connect to broker in standalone mode via Kubernetes In kubernetes you should use a [Service](https://kubernetes.io/docs/concepts/services-networking/service/) resource for manage networking and put it in "front" of the pulsar pod. T

[DISCUSS][PIP-226] Add JWKS support for AuthenticationProviderToken

2022-12-07 Thread Zixuan Liu
Hi all, I made a PIP to discuss: https://github.com/apache/pulsar/issues/18798. Thanks, Zixuan

[DISCUSS] PIP-227: New API for closing the consumer after waiting for the job to complete

2022-12-07 Thread Jie crossover
Hi, pulsar community, I’ve opened a PIP to discuss: PIP-227: New API for closing the consumer after waiting for the job to complete. The PIP link: https://github.com/apache/pulsar/issues/18799 Thanks. -- Best Regards! crossoverJie

Re: [VOTE] Pulsar Release 2.11.0 Candidate-2

2022-12-07 Thread Zixuan Liu
Ok, sounds good. Thanks, Zixuan PengHui Li 于2022年12月7日周三 16:10写道: > > I'm wondering whether affecting the resource quota. Could you confirm > that? > > Hmmm, I haven't heard of anyone using this feature. > I think it should be ok for a standalone. > > Penghui > > On Wed, Dec 7, 2022 at 1:33 PM

Re: [VOTE] Pulsar Release 2.11.0 Candidate-2

2022-12-07 Thread Nicolò Boschi
I'm sorry but I think I've found a blocker issue. pulsar-perf doesn't support jdk17. I know client compatibility targets jdk8 but the image uses jdk17 and this may be very annoying if pulsar-perf is not usable within the official docker image. btw I've send out the fix: https://github.com/apache/

Re: [VOTE] Pulsar Release 2.11.0 Candidate-2

2022-12-07 Thread Nicolò Boschi
Just realized that the error doesn't block the producer but it's only related to some DNS caching optimizations. I believe we can proceed with the current rc Nicolò Boschi Il giorno mer 7 dic 2022 alle ore 17:40 Nicolò Boschi ha scritto: > I'm sorry but I think I've found a blocker issue. > >

Re: [DISCUSS] PIP-227: New API for closing the consumer after waiting for the job to complete

2022-12-07 Thread 丛搏
Hi, Jie: I think it's better to leave it to user handle. We try not to add APIs that users can handle themselves. And I don't think there are many scenarios using this API, which brings about higher complexity. I tend to add a new interface beforeClose() in ConsumerInterceptor to allow users to cus

[VOTE] Reactive Java client for Apache Pulsar 0.1.0 Candidate 1

2022-12-07 Thread Christophe Bornet
Following PIP-205: Reactive Java client for Apache Pulsar ( https://github.com/apache/pulsar/issues/17335), this is the first release candidate for the Reactive Java client for Apache Pulsar, version 0.1.0. Please see the GitHub repo for the sources: https://github.com/apache/pulsar-client-reactiv

Re: [VOTE] Reactive Java client for Apache Pulsar 0.1.0 Candidate 1

2022-12-07 Thread Lari Hotari
Since this is a new module, it's the first time we are setting up the release process. I have pushed the sources for voting to this location: https://dist.apache.org/repos/dist/dev/pulsar/pulsar-client-reactive-0.1.0-candidate-1/ The sources are the same as in the opening voting mail that Christ

Re: [VOTE] Reactive Java client for Apache Pulsar 0.1.0 Candidate 1

2022-12-07 Thread Lari Hotari
+1, binding - sources, signature and checksums validated - Staged maven artifacts validated with a simple pulsar-client-reactive application. (followed https://github.com/apache/pulsar-client-reactive/wiki/Release-process#release-validation for validation) -Lari On 2022/12/07 19:09:23 Christo

Re: [VOTE] Reactive Java client for Apache Pulsar 0.1.0 Candidate 1

2022-12-07 Thread Lari Hotari
After consulting with Dave Fisher, I'm ending this first vote since it didn't contain all necessary details (the source artifact location and checksum). This vote thread is ended and I'll re-open a new thread for the actual vote. -Lari On 2022/12/07 19:09:23 Christophe Bornet wrote: > Followin

[VOTE] Reactive Java client for Apache Pulsar 0.1.0 Candidate 1, #2 vote

2022-12-07 Thread Lari Hotari
Following PIP-205: Reactive Java client for Apache Pulsar ( https://github.com/apache/pulsar/issues/17335), this is the first release candidate for the Reactive Java client for Apache Pulsar, version 0.1.0. *** Please download, test and vote on this release. This vote will stay open for at least 7

Re: [VOTE] Reactive Java client for Apache Pulsar 0.1.0 Candidate 1, #2 vote

2022-12-07 Thread Lari Hotari
+1, binding - sources, signature and checksums validated - sha512 checksum matches c10ec566d6f758b6a3c09f957e3e6005fdee8d8b9979b84cb33c9feae6fe28c84e198387fe0b92b6e1c697dd8e454b5a1b04565a74560a36259c35bfcfffccd2 - signature is valid - sources match git tag v0.1.0-candidate-1 (052a219334f6

Re: [VOTE] Reactive Java client for Apache Pulsar 0.1.0 Candidate 1, #2 vote

2022-12-07 Thread Dave Fisher
Hi - -1 (binding) 1. grade-wrapper.jar is a compiled binary and is not allowed. You can provide a script to be run to download it. See issues.apache.org/jira/browse/CALCITE-4575 2. NOTICE file is missing. See apache.org/legal/src-headers.html#notice 3. A few of the *.gradle files are missing A

Re: [VOTE] Reactive Java client for Apache Pulsar 0.1.0 Candidate 1, #2 vote

2022-12-07 Thread Christophe Bornet
Good points Dave. Thanks for your feedback. Le mer. 7 déc. 2022 à 22:43, Dave Fisher a écrit : > Hi - > > -1 (binding) > > 1. grade-wrapper.jar is a compiled binary and is not allowed. You can > provide a script to be run to download it. See > issues.apache.org/jira/browse/CALCITE-4575 > > 2. NO

Re: [VOTE] Pulsar Release 2.11.0 Candidate-2

2022-12-07 Thread Massimiliano Mirelli
Hi, I am running some long-lasting tests on this rc at the moment. Would it be OK to close the vote EOW or could you give me another 20h? Thank you, Max On Wed, 7 Dec 2022, 18:47 Nicolò Boschi, wrote: > Just realized that the error doesn't block the producer but it's only > related to some DNS c

[VOTE][PIP-225] Pulsar Functions fetch parameters from local config file.

2022-12-07 Thread Yufei Zhang
Hi all, I'm starting the vote for PIP-225: Pulsar Functions fetch parameters from local config file: https://github.com/apache/pulsar/issues/18744 Here is the discussion thread: https://lists.apache.org/thread/3m6z7jgn71nzd3ng3x73vsxvd4b1jjcp The vote will be open for at least 3 days. Cheers, Y

Re: [DISCUSS] PIP-227: New API for closing the consumer after waiting for the job to complete

2022-12-07 Thread PengHui Li
Hi, Jie One option is you can try to call consumer.pause() first. Then the consumer will not increase flow permits. No new messages will be dispatched to this consumer. And you can continue to receive messages from the buffer of the consumer. After all cached messages consumed. You can close the

Re: [VOTE][PIP-225] Pulsar Functions fetch parameters from local config file.

2022-12-07 Thread Rui Fu
+1 Best, Rui Fu On Dec 8, 2022, 07:48 +0800, Yufei Zhang , wrote: > Hi all, > > I'm starting the vote for PIP-225: Pulsar Functions fetch parameters from > local config file: > https://github.com/apache/pulsar/issues/18744 > > Here is the discussion thread: > https://lists.apache.org/thread/3m6z7

Re: [DISCUSS] PIP-227: New API for closing the consumer after waiting for the job to complete

2022-12-07 Thread Jie crossover
Thanks for the discussion. Even though the `pause()` is called, when the processing logic is asynchronous, the `acknowledge()` will still not be called, resulting in re- consumed when the consumer is restarted. The background here is that I found a problem similar to this issue

Re: [VOTE] Pulsar Release 2.11.0 Candidate-2

2022-12-07 Thread mattisonchao
Hi, All I found two regressions that need to block this release. https://github.com/apache/pulsar/pull/18816 https://github.com/apache/pulsar/pull/18812 Best, Mattison On Dec 8, 2022, 07:15 +0800, Massimiliano Mirelli , wrote: > Hi, > I am running some long-lasting tests on this rc at the mome

Re: [VOTE] Pulsar Release 2.11.0 Candidate-2

2022-12-07 Thread PengHui Li
Thanks, Mattison It's better also to have https://github.com/apache/pulsar/pull/18755 for the next RC I have merged the PR. Penghui On Thu, Dec 8, 2022 at 1:53 PM wrote: > Hi, All > > I found two regressions that need to block this release. > > https://github.com/apache/pulsar/pull/18816 > htt

Re: [Vote] PIP-223: Add metrics for all Rest Endpoints

2022-12-07 Thread Jiuming Tao
bump, need one more binding Jiuming Tao 于2022年11月28日周一 16:47写道: > Dear Pulsar Community, > > Please review and vote on this PIP. > > PIP link: https://github.com/apache/pulsar/issues/18560 > > Discuss thread: > https://lists.apache.org/thread/z74vcn0yolzzrcc4ftonm9j3nbk4pzxm > > Thanks, > Tao Ji

Re: [DISCUSS] Transactions isolation design

2022-12-07 Thread 丛搏
Hi, All: For question 1: The transaction itself is likely to be executed across multiple tenants. Applying for `TxnID` does not mean that it belongs to a specific tenant (or namespace). It means that it cannot be completely isolated. TC in the tenant will store another tenant topic register consume