Re: [DISCUSS] Close the connection quickly after authorization failure

2022-11-24 Thread Haiting Jiang
Hi Zixuan, Just want to make sure if we disconnect the connection, what's the behavior of the client? will it throw exceptions and fail, or do retries? Is the client possibly doing too many retries and crashing the server? Thanks, Haiting On Thu, Nov 24, 2022 at 3:41 PM Zixuan Liu wrote: > > Hi

Re: [VOTE] PIP-222: Add CommandPartitionedTopicMetadata metrics

2022-11-24 Thread Haiting Jiang
+1 binding Thanks, Haiting On Thu, Nov 24, 2022 at 1:05 AM Jiuming Tao wrote: > > > Bump > > > > 2022年11月22日 下午4:03,Ran Gao 写道: > > > > +1 (unbinding) > > > > Thanks, > > Ran > > > > On 2022/11/17 09:06:50 Jiuming Tao wrote: > >> Dear Pulsar Community, > >> > >> Please review and vote on this P

[VOTE] Pulsar Client C++ Release 3.1.0 Candidate 1

2022-11-24 Thread Zike Yang
This is the first release candidate for Apache Pulsar Client C++, version 3.1.0. It fixes the following issues: https://github.com/apache/pulsar-client-cpp/milestone/2?closed=1 *** Please download, test and vote on this release. This vote will stay open for at least 72 hours *** Note that we are

Re: [DISCUSS] PIP-223: Add metrics for all Rest Endpoints

2022-11-24 Thread Haiting Jiang
Hi Jiuming, > I’m not sure that if observe failed requests latency is meaningful. 1. Normally for failed requests, the latency sometimes will help in debugging. 2. Add httpcode label to latency, we can analyze the latency between different successful results too, like 200 and 307. As for `pulsar

Re: [DISCUSS] Close the connection quickly after authorization failure

2022-11-24 Thread Zixuan Liu
Hi Haiting, >Just want to make sure if we disconnect the connection, what's the behavior of the client? The client reconnects with the broker multiple times. When the maximum number of reconnections is reached, the client shutdown completely. Thanks, Zixuan Haiting Jiang 于2022年11月24日周四 16:04写道

[Result][Vote] PIP-222: Add CommandPartitionedTopicMetadata metrics

2022-11-24 Thread Jiuming Tao
Thanks for vote this PIP, closing the vote 3 bindings: Enrico Olivelli Haiting Jiang Penghui Li 1 non-bindings: Ran Gao Thanks, Tao Jiuming

Re: [VOTE] Pulsar Release 2.11.0 Candidate 1

2022-11-24 Thread guo jiwei
Hi We found a case that may break the old users. could we discuss if we need to resolve that and then continue to validate this release? https://github.com/apache/pulsar/issues/18598 Regards Tboy On Thu, Nov 24, 2022 at 3:56 PM Haiting Jiang wrote: > +1 binding > > - Checksum and signatu

Re: [DISCUSS] The use of consumer redeliverUnacknowledgedMessages method

2022-11-24 Thread 丛搏
Hi, Baodi > After, when the user calls `redeliverUnacknowledgedMessages` under failover > and exclusive subType, > It gets a warning reminder that the messages may be out of order, right? > yes, in failover and exclusive subType, we should suggest user to use a new API to redeliver the messages a

Re: [DISCUSS] PIP-223: Add metrics for all Rest Endpoints

2022-11-24 Thread Jiuming Tao
Hi Haiting, I’ll update the PIP as we discussed: 1. `pulsar_broker_rest_endpoint_failed` Labels: a. path: The HTTP request path b. method: The HTTP request method c. code: The HTTP response code This metric only records HTTP requests which response code >= 400 2. `pulsar_broker_rest_end

Re: [DISCUSS] The use of consumer redeliverUnacknowledgedMessages method

2022-11-24 Thread 丛搏
Hi, Joe: > This "brokenness" is not clear to me. https://github.com/apache/pulsar/pull/10478 This PIP solves some problems of "brokenness", >The sequence 3,4,5,6,7,8,9,10,11 12,13,14,15, 16 ,9,10,11,12,13,14,15,16,17, >18, 19, 20 ...does not break > the ordering guarantees of Pulsar If don't use

Happy Thanksgiving!

2022-11-24 Thread Yu
Hi team, Today is the Thanksgiving Day. At this wonderful time of the year, I have much to be immensely thankful for. Everyone here has made this a truly global community and a terrific place to collaborate. Wish Pulsar continues to grow faster and stronger next year with our joint efforts. Hap

PIP-224: Introduce TopicMessageId for consumer's MessageId related APIs

2022-11-24 Thread Yunze Xu
Hi Pulsar community, I've opened a PIP to discuss: https://github.com/apache/pulsar/issues/18616. PTAL. Thanks, Yunze

Re: [Vote] PIP-215: Configurable TopicCompactionStrategy for StrategicTwoPhaseCompactor and TableView

2022-11-24 Thread guo jiwei
+1 (binding) Regards Jiwei Guo (Tboy) On Tue, Nov 22, 2022 at 8:57 AM Baodi Shi wrote: > +1 (non-binding) > > > Thanks, > Baodi Shi > > > 2022年11月18日 17:00,Enrico Olivelli 写道: > > > > +1 (binding) > > > > Enrico > > > > Il giorno mar 15 nov 2022 alle ore 02:41 PengHui Li > > ha scritto: > >

[DISCUSS] Enable branch-2.9 force push and frozen branch-2.9

2022-11-24 Thread 丛搏
Hi, pulsar community, I am sorry for that, there is no commit to execute cherry-pick --continue, resulting in many cherry-pick commit messages not being correct[1]. So re-cherry-pick, now requires enabling branch-2.9 force push and frozen branch-2.9. reset commit 5ed247de3a. now branch-2.9 has c

Re: [VOTE] Pulsar Release 2.9.4 Candidate 1

2022-11-24 Thread 丛搏
Hi, all: this candidate cancel , reason:https://lists.apache.org/thread/jcrq9q0k6kh9rvb71dwb9s3mvo5c5dk5 丛搏 于2022年11月24日周四 11:22写道: > > Docker images: > https://hub.docker.com/layers/congbobo184/pulsar-all/2.9.4/images/sha256-53ef82d20fa7d9ee4809a3480f98cacea9b608cbb3a428881bcad3b8c77a9a32 > htt

Re: [DISCUSS] Enable branch-2.9 force push and frozen branch-2.9

2022-11-24 Thread PengHui Li
Hi Bo, Thanks for raising the discussion. +1 for re-cherry-pick the commits. The misleading commit logs will confuse users. Regards, Penghui On Fri, Nov 25, 2022 at 12:29 PM 丛搏 wrote: > Hi, pulsar community, > > I am sorry for that, there is no commit to execute cherry-pick > --continue, resu

Re: [DISCUSS] PIP-223: Add metrics for all Rest Endpoints

2022-11-24 Thread Haiting Jiang
+1, Great work. Haiting On Thu, Nov 24, 2022 at 6:25 PM Jiuming Tao wrote: > > Hi Haiting, > > I’ll update the PIP as we discussed: > > 1. `pulsar_broker_rest_endpoint_failed` > Labels: >a. path: The HTTP request path >b. method: The HTTP request method >c. code: The HTTP response c

Re: [DISCUSS] Enable branch-2.9 force push and frozen branch-2.9

2022-11-24 Thread guo jiwei
+1 for re-cherry-pick the commits. Regards Jiwei Guo (Tboy) On Fri, Nov 25, 2022 at 1:10 PM PengHui Li wrote: > Hi Bo, > > Thanks for raising the discussion. > > +1 for re-cherry-pick the commits. > The misleading commit logs will confuse users. > > Regards, > Penghui > > On Fri, Nov 25, 2022

Re: [DISCUSS] Enable branch-2.9 force push and frozen branch-2.9

2022-11-24 Thread Yubiao Feng
+1 for re-cherry-pick the commits. On Fri, Nov 25, 2022 at 12:29 PM 丛搏 wrote: > Hi, pulsar community, > > I am sorry for that, there is no commit to execute cherry-pick > --continue, resulting in many cherry-pick commit messages not being > correct[1]. So re-cherry-pick, now requires enabling br

Re: [DISCUSS] Enable branch-2.9 force push and frozen branch-2.9

2022-11-24 Thread Hang Chen
+1 for re-cherry-picking the commits. Thanks, Hang Yubiao Feng 于2022年11月25日周五 13:58写道: > > +1 for re-cherry-pick the commits. > > On Fri, Nov 25, 2022 at 12:29 PM 丛搏 wrote: > > > Hi, pulsar community, > > > > I am sorry for that, there is no commit to execute cherry-pick > > --continue, resulti

Re: [Discuss] Deprecate Index-based Publisher Stat Aggregation in Topics Partitioned-Stats

2022-11-24 Thread Nozomi Kurihara
Hi Heesung, Thank you for opening this discussion. IMO backward-compatibility should be kept at least across minor releases. Although the performance issue you mentioned (e.g. memory burst, high GC and OOM) looks problematic, backward-compatibility is also important. I think which has higher pri

Re: [ANNOUNCE] New Committer: Cong Zhao

2022-11-24 Thread Qiang Huang
Congrats! Nicolò Boschi 于2022年11月22日周二 15:22写道: > Congrats! > Nicolò Boschi > > > Il giorno mar 22 nov 2022 alle ore 06:23 Hang Chen > ha > scritto: > > > Congrats! > > > > Best, > > Hang > > > > tison 于2022年11月22日周二 13:15写道: > > > > > > Congrats! > > > > > > Best, > > > tison. > > > > > > > >