Re: [DISSCUSS] Code coverage report for PRs to master

2022-09-12 Thread Elliot West
Hello devs, I think that at a minimum we should be able to detect coverage regression and generate a visible warning on a PR. Specific statistics in the PR conversation may be less useful, and potentially noisy. However, I'd suggest also including some developer documentation that describes how to

[GitHub] [pulsar-helm-chart] claudio-vellage commented on pull request #286: Allow to use selectors with volumeClaimTemplates

2022-09-12 Thread GitBox
claudio-vellage commented on PR #286: URL: https://github.com/apache/pulsar-helm-chart/pull/286#issuecomment-1244292757 @lhotari is there anything left to do for me? Can this be assigned to someone for review? It's a rather small change which doesn't affect existing deployments, only adds

[GitHub] [pulsar-helm-chart] bharatbhushan1705 opened a new issue, #287: Error while executing prepare_helm_release.sh: tar: Error opening archive: Unrecognized archive format

2022-09-12 Thread GitBox
bharatbhushan1705 opened a new issue, #287: URL: https://github.com/apache/pulsar-helm-chart/issues/287 **Describe the bug** Error while executing prepare_helm_release.sh: tar: Error opening archive: Unrecognized archive format **To Reproduce** Steps to reproduce the behavior:

[GitHub] [pulsar-helm-chart] michaeljmarshall commented on issue #287: Error while executing prepare_helm_release.sh: tar: Error opening archive: Unrecognized archive format

2022-09-12 Thread GitBox
michaeljmarshall commented on issue #287: URL: https://github.com/apache/pulsar-helm-chart/issues/287#issuecomment-1244813286 Thanks for your issue @bharatbhushan1705. > Get pulsarctl install.sh script ... % Total % Received % Xferd Average Speed Time Time Time Current Dload Upl

Re: [VOTE] PIP-196 Segmented transaction buffer snapshot

2022-09-12 Thread Hang Chen
+1 (binding) Thanks, Hang guo jiwei 于2022年9月9日周五 18:17写道: > > +1(binding) > > Great work ! > > Regards > Jiwei Guo (Tboy) > > > On Fri, Sep 9, 2022 at 10:10 AM PengHui Li wrote: > > > +1(binding) > > > > I have done the review on gdoc > > And please also update the github issue(PIP). > > > > T

Re: [VOTE] PIP-196 Segmented transaction buffer snapshot

2022-09-12 Thread Qiang Huang
+1(non-binding) Hang Chen 于2022年9月13日周二 11:28写道: > +1 (binding) > > Thanks, > Hang > > guo jiwei 于2022年9月9日周五 18:17写道: > > > > +1(binding) > > > > Great work ! > > > > Regards > > Jiwei Guo (Tboy) > > > > > > On Fri, Sep 9, 2022 at 10:10 AM PengHui Li wrote: > > > > > +1(binding) > > > > > >

[DISCUSS] Back pressure in Apache Pulsar

2022-09-12 Thread mattison chao
Hi, All Since Pulsar has many asynchronous operations, we need to talk about backpressure. Because this is something to watch out for in async and I've seen comments about it in some other PRs. I think we need to open a separate discussion to collect the problems we are having and the solutions w

Re: Re: [DISCUSS] PIP-Enable read-only partition, add read and write control for a single partition.

2022-09-12 Thread Haiting Jiang
Hi Minyu, > Yes ,it is a new message router using partition permission without the > partition key . We need to discuss if the new partition permission is absolutely necessary. >From your use case, you can just implement your router based on the backlog. No new feature needs to be added. So do

Re: [VOTE] PIP-196 Segmented transaction buffer snapshot

2022-09-12 Thread Xiangying Meng
Thanks for your help. Close this vote with 3 binding and 2 non-binding. Sincerely, Xiangying On Tue, Sep 13, 2022 at 12:15 PM Qiang Huang wrote: > +1(non-binding) > > Hang Chen 于2022年9月13日周二 11:28写道: > > > +1 (binding) > > > > Thanks, > > Hang > > > > guo jiwei 于2022年9月9日周五 18:17写道: > > > >