[GitHub] [pulsar-helm-chart] nodece commented on a diff in pull request #243: Update pulsarctl to v2.9.2.7

2022-06-26 Thread GitBox
nodece commented on code in PR #243: URL: https://github.com/apache/pulsar-helm-chart/pull/243#discussion_r906836366 ## scripts/pulsar/common_auth.sh: ## @@ -25,7 +25,7 @@ fi OUTPUT=${CHART_HOME}/output OUTPUT_BIN=${OUTPUT}/bin -PULSARCTL_VERSION=v0.4.0 +PULSARCTL_VERSION=v2

Re: [VOTE] Pulsar Release 2.10.1 Candidate 1

2022-06-26 Thread PengHui Li
Hi all, Thanks for all your verification for 2.10.1 We currently have 2 (+1) bindings and 5 (+1) non-bindings. We need one more (+1) binding to unblock the 2.10.1 release. Please help validate. Thanks, Penghui On Thu, Jun 16, 2022 at 12:43 PM Shusuke Tsuda wrote: > +1 (non-binding) > > - veri

Re: [VOTE] Pulsar Release 2.9.3 Candidate 1

2022-06-26 Thread PengHui Li
+1 (binding) - verify gpg signatures - run standalone - pub/sub with pulsar-perf - verify connector (Cassandra) - verify stateful function - build image and test internally for the integration tests (all the tests get passed) @mattison It's better to upload the image under your org first so that

Re: [VOTE] Pulsar Release 2.10.1 Candidate 1

2022-06-26 Thread Hang Chen
Hi Penghui, Thanks for your great work! I found two problems with this candidate, I'm not sure whether it will block this release. - There are some CVEs in this candidate. Please refer to: https://github.com/apache/pulsar/runs/6854904384?check_suite_focus=true - When I import `pul

Re: [VOTE] Pulsar Release 2.9.3 Candidate 1

2022-06-26 Thread Hang Chen
Hi Mattison, Thanks for your great work! I found one problem with this candidate. - When I import `pulsar-broker` and `managed-ledger` into my project, I found the project build failed with the following exceptions. ``` [ERROR] Failed to execute goal on project test_pulsar_lib: Could not

Re: [DISCUSS] Enable GitHub Discussions?

2022-06-26 Thread Yu
+1 for enabling the GitHub Discussion as I proposed before. At that time, the main concern was not able to sync info between GitHub Discussion and Mailing List. Since the concern can be resolved now, we can make the most of GitHub Discussion as it's a powerful supplementary to community collaborat

[GitHub] [pulsar-client-node] massakam commented on pull request #81: Support seting topic schema when creating producers/consumers

2022-06-26 Thread GitBox
massakam commented on PR #81: URL: https://github.com/apache/pulsar-client-node/pull/81#issuecomment-1166771346 I've resolved the conflict, but the current code fails to compile. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHu

[GitHub] [pulsar-client-node] massakam commented on a diff in pull request #81: Support seting topic schema when creating producers/consumers

2022-06-26 Thread GitBox
massakam commented on code in PR #81: URL: https://github.com/apache/pulsar-client-node/pull/81#discussion_r906928647 ## src/SchemaInfo.cc: ## @@ -0,0 +1,78 @@ +/** + * Licensed to the Apache Software Foundation (ASF) under one + * or more contributor license agreements. See th

[GitHub] [pulsar-client-node] massakam commented on a diff in pull request #81: Support seting topic schema when creating producers/consumers

2022-06-26 Thread GitBox
massakam commented on code in PR #81: URL: https://github.com/apache/pulsar-client-node/pull/81#discussion_r906928816 ## src/SchemaInfo.cc: ## @@ -0,0 +1,78 @@ +/** + * Licensed to the Apache Software Foundation (ASF) under one + * or more contributor license agreements. See th

[GitHub] [pulsar-client-node] massakam commented on a diff in pull request #81: Support seting topic schema when creating producers/consumers

2022-06-26 Thread GitBox
massakam commented on code in PR #81: URL: https://github.com/apache/pulsar-client-node/pull/81#discussion_r906929063 ## src/SchemaInfo.h: ## @@ -0,0 +1,41 @@ +/** + * Licensed to the Apache Software Foundation (ASF) under one + * or more contributor license agreements. See the

[GitHub] [pulsar-client-node] massakam commented on a diff in pull request #81: Support seting topic schema when creating producers/consumers

2022-06-26 Thread GitBox
massakam commented on code in PR #81: URL: https://github.com/apache/pulsar-client-node/pull/81#discussion_r906929144 ## src/SchemaInfo.h: ## @@ -0,0 +1,41 @@ +/** + * Licensed to the Apache Software Foundation (ASF) under one + * or more contributor license agreements. See the

Re: [VOTE] Pulsar Release 2.10.1 Candidate 1

2022-06-26 Thread Dave Fisher
Hi - The Release Manager can vote. Shouldn’t you? Best Regards, Dave Sent from my iPhone > On Jun 26, 2022, at 5:51 PM, PengHui Li wrote: > > Hi all, > > Thanks for all your verification for 2.10.1 > > We currently have 2 (+1) bindings and 5 (+1) non-bindings. > We need one more (+1) bindi

Re: [DISCUSS] [PIP-179] Support the admin API to check unknown request parameters

2022-06-26 Thread Zike Yang
+1 Zike Yang On Wed, Jun 22, 2022 at 11:26 AM PengHui Li wrote: > +1 > > Penghui > > On Wed, Jun 22, 2022 at 10:53 AM Yubiao Feng > wrote: > > > Hi, Pulsar community: > > > > I open a pip to discuss "Support the admin API to check unknown request > > parameters" > > > > Proposal Link: https://

[GitHub] [pulsar-helm-chart] nodece commented on a diff in pull request #243: Update pulsarctl to v2.9.2.7

2022-06-26 Thread GitBox
nodece commented on code in PR #243: URL: https://github.com/apache/pulsar-helm-chart/pull/243#discussion_r906987312 ## scripts/pulsar/common_auth.sh: ## @@ -25,7 +25,7 @@ fi OUTPUT=${CHART_HOME}/output OUTPUT_BIN=${OUTPUT}/bin -PULSARCTL_VERSION=v0.4.0 +PULSARCTL_VERSION=v2

[GitHub] [pulsar-helm-chart] nodece commented on a diff in pull request #243: Update pulsarctl to v2.9.2.7

2022-06-26 Thread GitBox
nodece commented on code in PR #243: URL: https://github.com/apache/pulsar-helm-chart/pull/243#discussion_r906987312 ## scripts/pulsar/common_auth.sh: ## @@ -25,7 +25,7 @@ fi OUTPUT=${CHART_HOME}/output OUTPUT_BIN=${OUTPUT}/bin -PULSARCTL_VERSION=v0.4.0 +PULSARCTL_VERSION=v2

Re: [VOTE] PIP-177: Add the classLoader field for SchemaDefinition

2022-06-26 Thread Cong Zhao
Thanks for your participation. I'm closing the vote. The proposal has been accepted with 5 binding +1, non-binding +2 votes. On 2022/06/17 01:21:14 Cong Zhao wrote: > Hi Pulsar Community, > > > I would like to start a VOTE on "Add the classLoader field for > SchemaDefinition" (PIP-177). > > >

Re: [VOTE] PIP-168: Support zero-copy of NIC to NIC on Proxy

2022-06-26 Thread Cong Zhao
I forgot to close this vote. I'm closing the vote. The proposal has been accepted with 4 binding +1, non-binding +1 votes. Thanks, Cong Zhao On 2022/05/26 13:40:30 zhaocong wrote: > Hi Pulsar Community, > > > I would like to start a VOTE on "Support zero-copy of NIC to NIC on Proxy" > (PIP-168

[GitHub] [pulsar-helm-chart] rdhabalia commented on a diff in pull request #269: Support mechanism to provide external zookeeper-server list to build global/configuration zookeeper

2022-06-26 Thread GitBox
rdhabalia commented on code in PR #269: URL: https://github.com/apache/pulsar-helm-chart/pull/269#discussion_r907003823 ## charts/pulsar/templates/zookeeper-statefulset.yaml: ## @@ -134,10 +134,19 @@ spec: containerPort: {{ .Values.zookeeper.ports.clientTls }}