[GitHub] [pulsar-client-node] nkurihar commented on pull request #217: Suggest pulsar-admin-client in README.md

2022-06-16 Thread GitBox
nkurihar commented on PR #217: URL: https://github.com/apache/pulsar-client-node/pull/217#issuecomment-1157335037 Thank you for your contribution. However, IMO we sholud clarify whether the library is made by the third party or not to avoid users' misunderstanding and confusion.

[GitHub] [pulsar-client-node] visortelle commented on pull request #217: Suggest pulsar-admin-client in README.md

2022-06-16 Thread GitBox
visortelle commented on PR #217: URL: https://github.com/apache/pulsar-client-node/pull/217#issuecomment-1157342139 Thank you. I'll create a PR at the suggested place. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use t

[GitHub] [pulsar-client-node] visortelle closed pull request #217: Suggest pulsar-admin-client in README.md

2022-06-16 Thread GitBox
visortelle closed pull request #217: Suggest pulsar-admin-client in README.md URL: https://github.com/apache/pulsar-client-node/pull/217 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific c

[GitHub] [pulsar-client-node] nearzxide10 commented on issue #87: npm install fails on MacOS

2022-06-16 Thread GitBox
nearzxide10 commented on issue #87: URL: https://github.com/apache/pulsar-client-node/issues/87#issuecomment-1157411697 nodeJs version : 16.15.1 npm version : 8.11.0 mac OS: 12.4 (M1 max) I installed the cpp client first and export PULSAR_CPP_DIR.. can't npm install too

Re: Mark delete rate limiter bug?

2022-06-16 Thread Asaf Mesika
If I understand correctly: this.flushCursorsTask = scheduledExecutor.scheduleAtFixedRate(catchingAndLoggingThrowables(this::flushCursors), config.getCursorPositionFlushSeconds(), config.getCursorPositionFlushSeconds(), TimeUnit.SECONDS); which calls ml.getCursors().forEach(c -> ((Managed

Re: [DISCUSS] [PIP-160] Batch writing ledger for transaction operation

2022-06-16 Thread Yubiao Feng
Hi Pulsar community: I've rewritten proposal: "Make transactions work more efficiently by aggregation operation for transaction log and pending ack store" Proposal Link: https://github.com/apache/pulsar/issues/15370 ## Motivation Transaction coordinator and Pending Ack Store are two core compon

[GitHub] [pulsar-manager] toneill818 opened a new issue, #465: Docker Failed to Initialize Postgresql Database

2022-06-16 Thread GitBox
toneill818 opened a new issue, #465: URL: https://github.com/apache/pulsar-manager/issues/465 When running the docker container the following is produced in the logs. ``` /pulsar-manager/startup.sh: 21: initdb: not found /pulsar-manager/startup.sh: 22: pg_ctl: not found create

Re: [DISCUSS] [PIP-160] Batch writing ledger for transaction operation

2022-06-16 Thread Yubiao Feng
> I am not sure I understand the part of making it configurable via a classname. I believe it is better to simply have a flag "transactionEnableBatchWrites". Otherwise the matrix of possible implementations will grow without limits. Good idea, I've modified the design and added a switch in the Con

Re: [DISCUSS] [PIP-160] Batch writing ledger for transaction operation

2022-06-16 Thread Yubiao Feng
Hi XiangYing > I noticed you write conf transactionMetadataStoreProviderClassName is configured in broker.conf. Should this be added to `Configuration Changes`? I have rewritten the design, in the new design I removed the section which has "transactionMetadataStoreProviderClassName", instead it,

[GitHub] [pulsar-client-node] tuteng commented on issue #87: npm install fails on MacOS

2022-06-16 Thread GitBox
tuteng commented on issue #87: URL: https://github.com/apache/pulsar-client-node/issues/87#issuecomment-1158192533 > nodeJs version : 16.15.1 npm version : 8.11.0 mac OS: 12.4 (M1 max) > > I installed the cpp client first and export PULSAR_CPP_DIR.. can't npm install too > > `

[VOTE] PIP-177: Add the classLoader field for SchemaDefinition

2022-06-16 Thread Cong Zhao
Hi Pulsar Community, I would like to start a VOTE on "Add the classLoader field for SchemaDefinition" (PIP-177). The proposal can be read at https://github.com/apache/pulsar/issues/16058 and the discussion thead is available at https://lists.apache.org/thread/3wjvmpzo3pq1ff62f4cops7ckyrcgfhf

[GitHub] [pulsar-client-node] nearzxide10 commented on issue #87: npm install fails on MacOS

2022-06-16 Thread GitBox
nearzxide10 commented on issue #87: URL: https://github.com/apache/pulsar-client-node/issues/87#issuecomment-1158382450 > > nodeJs version : 16.15.1 npm version : 8.11.0 mac OS: 12.4 (M1 max) > > I installed the cpp client first and export PULSAR_CPP_DIR.. can't npm install too > > ``

[GitHub] [pulsar-client-node] equanz commented on issue #87: npm install fails on MacOS

2022-06-16 Thread GitBox
equanz commented on issue #87: URL: https://github.com/apache/pulsar-client-node/issues/87#issuecomment-1158384683 @nearzxide10 > ``` > npm ERR! ld: library not found for -lpulsar > npm ERR! clang: error: linker command failed with exit code 1 (use -v to see invocation) > ```

[GitHub] [pulsar-client-node] nearzxide10 commented on issue #87: npm install fails on MacOS

2022-06-16 Thread GitBox
nearzxide10 commented on issue #87: URL: https://github.com/apache/pulsar-client-node/issues/87#issuecomment-1158391286 > @nearzxide10 > > > ``` > > npm ERR! ld: library not found for -lpulsar > > npm ERR! clang: error: linker command failed with exit code 1 (use -v to see invo

Re: [DISCUSS] Reject partitioned topic creation when the topic name contains the `partition` keyword.

2022-06-16 Thread mattison chao
I pushed a pull request[1]. That can avoid creating partitioned metadata when the topic local name includes `-partition-` keywords. [1] https://github.com/apache/pulsar/pull/16104

[GitHub] [pulsar-connectors] dependabot[bot] opened a new pull request, #3: Bump fastjson from 1.2.73 to 1.2.83 in /pulsar-io/canal

2022-06-16 Thread GitBox
dependabot[bot] opened a new pull request, #3: URL: https://github.com/apache/pulsar-connectors/pull/3 Bumps [fastjson](https://github.com/alibaba/fastjson) from 1.2.73 to 1.2.83. Release notes Sourced from https://github.com/alibaba/fastjson/releases";>fastjson's releases.

Re: [VOTE] PIP-165: Auto release client useless connections

2022-06-16 Thread Yubiao Feng
Hi Matteo, Enrico, LinLin I would appreciate it if you could give me some comments. Thanks Yubiao.Feng On Wed, Jun 15, 2022 at 2:47 PM Hang Chen wrote: > +1 > > Thanks, > Hang > > Zike Yang 于2022年6月15日周三 10:31写道: > > > > +1 > > > > > > Zike Yang > > > > On Wed, Jun 15, 2022 at 10:28 AM Haiti

Re: [DISCUSS] [PIP-160] Batch writing ledger for transaction operation

2022-06-16 Thread Yubiao Feng
Hi Enrico > I am not sure I understand the part of making it configurable via a classname. I believe it is better to simply have a flag "transactionEnableBatchWrites". Otherwise the matrix of possible implementations will grow without limits. Good idea, I've modified the design and added a switc

[GitHub] [pulsar-client-node] equanz opened a new pull request, #220: Split conditions between OS in binding.gyp

2022-06-16 Thread GitBox
equanz opened a new pull request, #220: URL: https://github.com/apache/pulsar-client-node/pull/220 # Motivation On macOS and Apple Silicon, we can't build pulsar-client-node if using default environment variables like below. https://github.com/apache/pulsar-client-node/issues/87#issue

[GitHub] [pulsar-site] urfreespace merged pull request #119: fix: url trailing slash

2022-06-16 Thread GitBox
urfreespace merged PR #119: URL: https://github.com/apache/pulsar-site/pull/119 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@pulsar.a

[GitHub] [pulsar-helm-chart] MarvinCai opened a new issue, #272: Allow broker/proxy to define extra envs.

2022-06-16 Thread GitBox
MarvinCai opened a new issue, #272: URL: https://github.com/apache/pulsar-helm-chart/issues/272 **Is your feature request related to a problem? Please describe.** Allow broker/proxy to define extra envs so user can add env like Pod IP or Pod Name. **Describe the solution you'd like

[GitHub] [pulsar-helm-chart] MarvinCai opened a new pull request, #273: Support defining extra env for broker and proxy statefulsset.

2022-06-16 Thread GitBox
MarvinCai opened a new pull request, #273: URL: https://github.com/apache/pulsar-helm-chart/pull/273 Fixes #272 ### Motivation Allow broker/proxy to define extra envs so user can add env like Pod IP or Pod Name. ### Modifications Add extra env in broker/proxy sts if defin