[GitHub] [pulsar] mattisonchao commented on a diff in pull request #15011: [improve][transaction] support configurable ``transactionBufferClientOperationTimeoutInMills``

2022-04-04 Thread GitBox
mattisonchao commented on code in PR #15011: URL: https://github.com/apache/pulsar/pull/15011#discussion_r841480571 ## pulsar-broker-common/src/main/java/org/apache/pulsar/broker/ServiceConfiguration.java: ## @@ -2475,6 +2475,12 @@ ) private int transactionBufferClient

[GitHub] [pulsar-client-node] Matt-Esch commented on a diff in pull request #200: convert worker threads to async functions

2022-04-04 Thread GitBox
Matt-Esch commented on code in PR #200: URL: https://github.com/apache/pulsar-client-node/pull/200#discussion_r841559559 ## src/Client.cc: ## @@ -40,14 +41,43 @@ static const std::string CFG_TLS_ALLOW_INSECURE = "tlsAllowInsecureConnection"; static const std::string CFG_STATS_

[GitHub] [pulsar-client-node] massakam commented on a diff in pull request #200: convert worker threads to async functions

2022-04-04 Thread GitBox
massakam commented on code in PR #200: URL: https://github.com/apache/pulsar-client-node/pull/200#discussion_r841573203 ## src/Client.cc: ## @@ -40,14 +41,43 @@ static const std::string CFG_TLS_ALLOW_INSECURE = "tlsAllowInsecureConnection"; static const std::string CFG_STATS_I

[GitHub] [pulsar-client-node] equanz commented on a diff in pull request #200: convert worker threads to async functions

2022-04-04 Thread GitBox
equanz commented on code in PR #200: URL: https://github.com/apache/pulsar-client-node/pull/200#discussion_r842345647 ## src/Consumer.cc: ## @@ -243,160 +235,225 @@ class ConsumerReceiveWorker : public Napi::AsyncWorker { private: Napi::Promise::Deferred deferred; - puls