[GitHub] [pulsar-site] Anonymitaet commented on pull request #21: Update reporting a vulnerability documentation

2022-03-21 Thread GitBox
Anonymitaet commented on pull request #21: URL: https://github.com/apache/pulsar-site/pull/21#issuecomment-1073646750 @michaeljmarshall thanks for your explanations! That makes sense. To avoid duplication and add references, how about changing it as below? (add a row for secur...@apach

[GitHub] [pulsar-manager] aluccaroni opened a new pull request #452: Upgrade BKVM to 3.1.1 - DRAFT

2022-03-21 Thread GitBox
aluccaroni opened a new pull request #452: URL: https://github.com/apache/pulsar-manager/pull/452 This is a DRAFT, do not merge I'm trying to update BKVM on pulsar-manager...just by updating graddle dependencies for BKVM and HerdDB I see that the build process is removing many files

[GitHub] [pulsar-manager] eolivelli commented on a change in pull request #452: Upgrade BKVM to 3.1.1 - DRAFT

2022-03-21 Thread GitBox
eolivelli commented on a change in pull request #452: URL: https://github.com/apache/pulsar-manager/pull/452#discussion_r830914897 ## File path: gradle.properties ## @@ -18,8 +18,8 @@ apiMockitoVersion=1.7.1 mockitoJunit4Version=1.7.1 gsonVersion=2.8.2 postgresqlVersion=42.2

[GitHub] [pulsar-manager] eolivelli commented on pull request #452: Upgrade BKVM to 3.1.1 - DRAFT

2022-03-21 Thread GitBox
eolivelli commented on pull request #452: URL: https://github.com/apache/pulsar-manager/pull/452#issuecomment-1073695250 does the build work without your patch ? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL

[GitHub] [pulsar-manager] aluccaroni closed pull request #452: Upgrade BKVM to 3.1.1 - DRAFT

2022-03-21 Thread GitBox
aluccaroni closed pull request #452: URL: https://github.com/apache/pulsar-manager/pull/452 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-un

[GitHub] [pulsar-manager] aluccaroni commented on pull request #452: Upgrade BKVM to 3.1.1 - DRAFT

2022-03-21 Thread GitBox
aluccaroni commented on pull request #452: URL: https://github.com/apache/pulsar-manager/pull/452#issuecomment-1073717984 @eolivelli the frontend file are removed with a "./gradlew clean build" on the current master, so the patch isn't the culprit -- This is an automated message from the

[GitHub] [pulsar-manager] eolivelli commented on pull request #453: Upgrade BKVM to 3.1.1

2022-03-21 Thread GitBox
eolivelli commented on pull request #453: URL: https://github.com/apache/pulsar-manager/pull/453#issuecomment-1073812359 Tested locally, with pulsar standalone. BKVM works like a charm ! -- This is an automated message from the Apache Git Service. To respond to the message, please log on

[GitHub] [pulsar-manager] eolivelli merged pull request #453: Upgrade BKVM to 3.1.1

2022-03-21 Thread GitBox
eolivelli merged pull request #453: URL: https://github.com/apache/pulsar-manager/pull/453 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-uns

[Discuss] Generate cert and key files automatically

2022-03-21 Thread Yunze Xu
Hi all, Recently I found a document error when configuring Pulsar client for TLS encryption. See https://github.com/apache/pulsar/issues/14762. However, the code example in the official documents is more intuitive. See https://pulsar.apache.org/docs/en/security-tls-transport/#java-client, the exa

[GitHub] [pulsar-helm-chart] sdwerwed commented on pull request #127: Antiaffinity with zone topology for high availability

2022-03-21 Thread GitBox
sdwerwed commented on pull request #127: URL: https://github.com/apache/pulsar-helm-chart/pull/127#issuecomment-1074108404 @sijie > I think the zone affinity would work for stateless components. I don't think it will work well for stateful components. Because the location of bookie

[GitHub] [pulsar-helm-chart] sdwerwed edited a comment on pull request #127: Antiaffinity with zone topology for high availability

2022-03-21 Thread GitBox
sdwerwed edited a comment on pull request #127: URL: https://github.com/apache/pulsar-helm-chart/pull/127#issuecomment-1074108404 @sijie > I think the zone affinity would work for stateless components. I don't think it will work well for stateful components. Because the location of

[GitHub] [pulsar-helm-chart] sdwerwed edited a comment on pull request #127: Antiaffinity with zone topology for high availability

2022-03-21 Thread GitBox
sdwerwed edited a comment on pull request #127: URL: https://github.com/apache/pulsar-helm-chart/pull/127#issuecomment-1074108404 @sijie > I think the zone affinity would work for stateless components. I don't think it will work well for stateful components. Because the location of

Re: [Discuss] Generate cert and key files automatically

2022-03-21 Thread Enrico Olivelli
Il giorno lun 21 mar 2022 alle ore 16:31 Yunze Xu ha scritto: > > Hi all, > > Recently I found a document error when configuring Pulsar client for TLS > encryption. See https://github.com/apache/pulsar/issues/14762. However, the > code > example in the official documents is more intuitive. > > Se

Re: [VOTE] Pulsar Release 2.8.3 Candidate 4

2022-03-21 Thread Michael Marshall
Thank you for uploading the images. Michael On Fri, Mar 18, 2022 at 11:46 PM PengHui Li wrote: > > Hi Michael, > > Images have been uploaded. > > Penghui > > On Sat, Mar 19, 2022 at 12:19 PM PengHui Li wrote: > > > Thanks Michael, > > > > I can help push the docker image. > > After the images

Re: [VOTE] PIP-136: Sync Pulsar policies across multiple clouds

2022-03-21 Thread Rajan Dhabalia
>> If it contains namespace policy replication, There are some policies no need to replicate to another cluster yes, local policies doesn't need to be replicate to other clusters and it will only replicate global policies which is shared across multiple clusters such tenant/namespace's identity-cre

[GitHub] [pulsar-client-node] Matt-Esch commented on a change in pull request #200: convert worker threads to async functions

2022-03-21 Thread GitBox
Matt-Esch commented on a change in pull request #200: URL: https://github.com/apache/pulsar-client-node/pull/200#discussion_r831660197 ## File path: src/Consumer.cc ## @@ -79,144 +81,131 @@ void MessageListener(pulsar_consumer_t *cConsumer, pulsar_message_t *cMessage, v lis

Re: [VOTE] PIP-136: Sync Pulsar policies across multiple clouds

2022-03-21 Thread PengHui Li
Thanks for the explanation. > yes, local policies doesn't need to be replicate to other clusters and it will only replicate global policies which is shared across multiple clusters such tenant/namespace's identity-creation, ACLs, replication clusters, etc. As described in this blog [1], section "

[GitHub] [pulsar-client-node] tuteng closed pull request #204: [Test]Update pulsar version

2022-03-21 Thread GitBox
tuteng closed pull request #204: URL: https://github.com/apache/pulsar-client-node/pull/204 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-un

[VOTE] Pulsar Release 2.10.0 Candidate 4

2022-03-21 Thread PengHui Li
This is the fourth release candidate for Apache Pulsar 2.10.0 It fixes the following issues: https://github.com/apache/pulsar/pulls?q=is%3Apr+milestone%3A2.10.0+is%3Amerged+-label%3Arelease%2F2.9.1+-label%3Arelease%2F2.9.2 *** Please download, test and vote on this release. This vote will stay op

Re: [DISCUSS] PIP-143 : Standardize Admin REST API

2022-03-21 Thread PengHui Li
+1 Penghui On Fri, Mar 18, 2022 at 11:00 AM guo jiwei wrote: > Ok, I have updated the proposal number to 149. > https://github.com/apache/pulsar/issues/14365. > > Regards > Jiwei Guo (Tboy) > > > On Wed, Mar 16, 2022 at 8:53 PM PengHui Li wrote: > > > PIP-143 is this one https://github.com/apa

Re: [Discuss] Generate cert and key files automatically

2022-03-21 Thread Zixuan Liu
Hi Yunze, The current implementation is confusing, we should split the transport and auth for TLS. For transport, the code can be so like: ``` PulsarClient client = PulsarClient.builder() .enableTls(true) .tlsTrustCertsFilePath("ca.pem") .tlsCertFil

Re: [Discuss] Generate cert and key files automatically

2022-03-21 Thread Zixuan Liu
BTW, auto TLS is a good idea. Zixuan Liu 于2022年3月22日周二 11:03写道: > Hi Yunze, > > The current implementation is confusing, we should split the transport and > auth for TLS. > > For transport, the code can be so like: > ``` > PulsarClient client = PulsarClient.builder() > .enable

[GitHub] [pulsar-client-node] Matt-Esch commented on pull request #200: convert worker threads to async functions

2022-03-21 Thread GitBox
Matt-Esch commented on pull request #200: URL: https://github.com/apache/pulsar-client-node/pull/200#issuecomment-1074688520 I managed to track down the segfault with valgrind and found an appropriate workaround (issue with the node-addon-api double freeing Ref'd instances https://github.