Re: [DISCUSS][Reader] readNext reset message position automatically when enable inclusive

Thanks @Mattison and @Penghui, Good idea! I consider fixing this in client, then I will improve this in the broker. > This pip is to add a new field to the CommandSubscribe to let the broker know how to set the cursor position. I am also interested in this. PengHui Li 于2022年3月14日周一 23:33写道： >

Re: [DISCUSS] PrometheusMetricsServlet performance improvement

Note that the PrometheusMetricsGenerator will generate the text for Prometheus client metrics registered to the default CollectorRegistry. So it should be possible to progressively convert stats objects to Prometheus Gauge/Counter/etc... Le mer. 9 mars 2022 à 06:57, Michael Marshall a écrit : >

Re: [DISCUSS] Use the non-persistent topic to sync bundle load data

+1 The load data don't need to be persistent to the storage layer, Using a non-persistent topic is more efficient. Thanks, Penghui On Wed, Mar 16, 2022 at 2:14 PM Kai Wang wrote: > Hi Pulsar Community, > > Currently, Pulsar LoadManager is using Zookeeper to store the local broker > data, the L

[GitHub] [pulsar-manager] goncalocribeiro opened a new issue #451: [user.management.enable=false] - default user/password is not admin

goncalocribeiro opened a new issue #451: URL: https://github.com/apache/pulsar-manager/issues/451 I've already seen the issue #347, which says it has been solved by #351 but that doesn't work. The default user/password continues to not be an admin user. If I have my application.pr

[DISCUSS] PIP-143 : Standardize Admin REST API

Hello community, I want to discuss refactoring and standardizing REST API. Users have encountered several deadlock problems in the API part before, like #13666 , #12590 . After fixing the above two issues

Re: [DISCUSS] PIP-143 : Standardize Admin REST API

PIP-143 is this one https://github.com/apache/pulsar/issues/13761 Please peek a new proposal number Penghui On Wed, Mar 16, 2022 at 8:43 PM guo jiwei wrote: > Hello community, > > I want to discuss refactoring and standardizing REST API. Users have > encountered several deadlock problems i

Re: [DISCUSS] Set EntryCache evict task interval directly

+1, The new configuration should be compatible with the existing one. Penghui On Wed, Mar 16, 2022 at 9:09 AM Aloys Zhang wrote: > Hi all, > > Pulsar uses an EntryCache to support entry caching for tailing-read. and > there is a periodic task to evict entry from the cache. > > The task period

Re: [VOTE] Pulsar Release 2.9.2 Candidate 4

+1 (binding) - Checked the signature - Start standalone - Publish messages and consume messages - Checked Cassandra connector - Checked stateful function Thanks, Penghui On Wed, Mar 16, 2022 at 10:34 AM Ran Gao wrote: > This is the fourth release candidate for Apache Pulsar, version 2.9.2. > >

[DISCUSS] Migrate TestNg Assertion to AssertJ

Dear devs, I'd like to start a discussion to migrate the TestNg assertion to AssertJ assertion. Some main motivations are: - AssertJ is a pure streaming API with more elegant coding and higher readability. - Making full use of Java 8 Lambdas for writing easier to read tests and a better perfo

Jacoco and Codecov.io integration for Code Coverage reports

Dear community, Currently we don't have an aggregate code coverage report. There's a Jacoco configuration to generate the report after unit tests but it is not easily readable and understandable. Having a better system would bring a couple of interesting aspects: 1. We can block a pull request if

Re: [DISCUSS] Use the non-persistent topic to sync bundle load data

But in order to read from a topic you need a broker that is the owner of the owner of the special "temporary topic". While the metadata service (ZooKeeper) is already a central point and it is meant to be available (otherwise Pulsar doesn't work), we do not know anything about the availability of

Re: [DISCUSS] Migrate TestNg Assertion to AssertJ

I support the switch to AssertJ. Some automated tooling might be useful for doing the bulk of the migration. AssertJ provides some scripts for the migration: https://joel-costigliola.github.io/assertj/assertj-core-converting-testng-assertions-to-assertj.html There's also more sophisticated tools

Re: [DISCUSS] Use the non-persistent topic to sync bundle load data

> we do not know anything about the availability of the owner of the topic. If the owner broker is not available, other brokers will take over. > We could make it simpler and when a broker wants to push its data, it looks up the REST address of the "leader broker" and then pushes the data to it,

Re:Re: [DISCUSS] Migrate TestNg Assertion to AssertJ

Thank you for your research about automated toolings, Lari. As you said, if we decide to migrate, the way how we migrate it is important. There is a compromise way worth discussing. AssertJ is used for assertion in new tests, while module based migration can be used in the migration process of

[Guideline] Pulsar PR Naming Convention

Hi Pulsarers, We submit or review PRs almost every day, we might see many vague and unclear PR titles that decrease team efficiency and productivity. Good PR titles offer bring many benefits, such as speeding up the review process and improving search efficiency. To solve the vague PR title issu

Re: [Guideline] Pulsar PR Naming Convention

Hi Yu, Thanks for the great guidance. Overall looks good to me, just left a few minor comments. Penghui On Thu, Mar 17, 2022 at 10:12 AM Yu wrote: > Hi Pulsarers, > > We submit or review PRs almost every day, we might see many vague and > unclear PR titles that decrease team efficiency and pro