[GitHub] [pulsar-site] urfreespace merged pull request #6: config and style updates

2022-02-28 Thread GitBox
urfreespace merged pull request #6: URL: https://github.com/apache/pulsar-site/pull/6 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr

[GitHub] [pulsar-site] urfreespace merged pull request #7: Add more ecosytem connectors

2022-02-28 Thread GitBox
urfreespace merged pull request #7: URL: https://github.com/apache/pulsar-site/pull/7 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr

Re: [DISCUSS] PrometheusMetricsServlet performance improvement

2022-02-28 Thread PengHui Li
Hi Jiuming, Could you please check if the Prometheus client can be used to reduce the JVM heap usage? If yes, I think we can consider using the Prometheus client instead of the current implementation together. Otherwise, we'd better focus on the heap memory usage enhancement for this discussion. U

Re: [DISCUSS] PrometheusMetricsServlet performance improvement

2022-02-28 Thread Jiuming Tao
Hi Penghui, I had read `io.prometheus.client.exporter.HttpServer` source code, in `HttpMetricsHandler#handle` method, it uses thread local cached `ByteArrayOutputStream` , it’s similar with our current implemention(with heap memory resizes and mem_copy). It will spend a plenty of heap memory,

The pulsar node client package was mistakenly deleted on npmjs

2022-02-28 Thread Guangning E
I'm recently releasing pulsar node client 1.6, I'm very sorry, just now I deleted the pulsar-client package on npmjs by mistake, that doesn't seem to be recoverable, if you install pulsar-client you may see this warning `Package no longer supported`, I'm now releasing a small version for each branc

Re: The pulsar node client package was mistakenly deleted on npmjs

2022-02-28 Thread Enrico Olivelli
Thanks for the heads up Enrico Il Lun 28 Feb 2022, 14:55 Guangning E ha scritto: > I'm recently releasing pulsar node client 1.6, I'm very sorry, just now I > deleted the pulsar-client package on npmjs by mistake, that doesn't seem to > be recoverable, if you install pulsar-client you may see

[VOTE] Pulsar Node.js Client Release 1.6.0 Candidate 2

2022-02-28 Thread Guangning E
Hi everyone, Please review and vote on the release candidate #2 for the version 1.6.0, as follows: [ ] +1, Approve the release [ ] -1, Do not approve the release (please provide specific comments) This is the first release candidate for Apache Pulsar Node.js client, version 1.6.0. It fixes the fo

[GitHub] [pulsar-helm-chart] lhotari opened a new pull request #239: Revert "Upgrade cert-manager to 1.5.4 (#204)"

2022-02-28 Thread GitBox
lhotari opened a new pull request #239: URL: https://github.com/apache/pulsar-helm-chart/pull/239 This reverts commit 40a4d50923bd93c960a4ef940930177ca80cb77e. Supporting `cert-manager.io/v1` api version requires changes made in #233 or #238. In addition, the change should be made in

[GitHub] [pulsar-helm-chart] lhotari commented on pull request #238: Cert Fix

2022-02-28 Thread GitBox
lhotari commented on pull request #238: URL: https://github.com/apache/pulsar-helm-chart/pull/238#issuecomment-1054352998 @toneill818 Thank you for the contribution. It looks like there's a similar change in #233. I created #239 to first rollback #204 changes so that we have a time to pre

[GitHub] [pulsar-helm-chart] lhotari commented on pull request #233: feat(certs): use actual v1 spec for certs

2022-02-28 Thread GitBox
lhotari commented on pull request #233: URL: https://github.com/apache/pulsar-helm-chart/pull/233#issuecomment-1054368281 @smazurov Thanks for the contribution. I created a PR to first revert #204 changes so that we have time to prepare a better solution for migrating to use `cert-manager

[GitHub] [pulsar-helm-chart] lhotari edited a comment on pull request #233: feat(certs): use actual v1 spec for certs

2022-02-28 Thread GitBox
lhotari edited a comment on pull request #233: URL: https://github.com/apache/pulsar-helm-chart/pull/233#issuecomment-1054368281 @smazurov Thanks for the contribution. I created a PR to first revert #204 changes so that we have time to prepare a better solution for migrating to use `cert-

[GitHub] [pulsar-helm-chart] Rohlik commented on pull request #227: Remove breaking labelmap actions, #226, #100

2022-02-28 Thread GitBox
Rohlik commented on pull request #227: URL: https://github.com/apache/pulsar-helm-chart/pull/227#issuecomment-1054403222 I just hit on this problem too. Looking forward to see this PR merged πŸ™πŸ½ . -- This is an automated message from the Apache Git Service. To respond to the message, plea

[GitHub] [pulsar-helm-chart] toneill818 closed pull request #238: Cert Fix

2022-02-28 Thread GitBox
toneill818 closed pull request #238: URL: https://github.com/apache/pulsar-helm-chart/pull/238 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev

[GitHub] [pulsar-helm-chart] toneill818 commented on pull request #238: Cert Fix

2022-02-28 Thread GitBox
toneill818 commented on pull request #238: URL: https://github.com/apache/pulsar-helm-chart/pull/238#issuecomment-1054526089 @lhotari That works for me -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to

[GitHub] [pulsar-helm-chart] toneill818 commented on pull request #239: Revert "Upgrade cert-manager to 1.5.4 (#204)"

2022-02-28 Thread GitBox
toneill818 commented on pull request #239: URL: https://github.com/apache/pulsar-helm-chart/pull/239#issuecomment-1054553884 @lhotari Would you be interested in having cert-manager installed as a dependency if enabled, or kept outside this chart? If we require it as a dependency we can us

[GitHub] [pulsar-helm-chart] smazurov commented on pull request #233: feat(certs): use actual v1 spec for certs

2022-02-28 Thread GitBox
smazurov commented on pull request #233: URL: https://github.com/apache/pulsar-helm-chart/pull/233#issuecomment-1054586894 assuming kube is aware of both apis, upgrading is straightfoward. So the change is fine as long as the new spec for v1 is actually followed. Once cert-manager is upgr

[GitHub] [pulsar-helm-chart] michaeljmarshall commented on pull request #227: Remove breaking labelmap actions, #226, #100

2022-02-28 Thread GitBox
michaeljmarshall commented on pull request #227: URL: https://github.com/apache/pulsar-helm-chart/pull/227#issuecomment-1054648279 @mkoertgen - thanks for your contribution. Do we still need this PR? Based on the discussion in https://github.com/prometheus-operator/prometheus-operator/iss

[GitHub] [pulsar-client-node] massakam opened a new pull request #197: Do not add license header to tarball file

2022-02-28 Thread GitBox
massakam opened a new pull request #197: URL: https://github.com/apache/pulsar-client-node/pull/197 There is a step in [the release process](https://github.com/apache/pulsar-client-node/wiki/Release-process) to run `npm run license: addheader`, which will add the license header to the sou

Re: [DISCUSS] PrometheusMetricsServlet performance improvement

2022-02-28 Thread PengHui Li
Hi, Thanks for the update, I agree to have the JVM heap usage enhancement. +1 Penghui On Mon, Feb 28, 2022 at 5:33 PM Jiuming Tao wrote: > Hi Penghui, > > I had read `io.prometheus.client.exporter.HttpServer` source code, in > `HttpMetricsHandler#handle` method, it uses thread local cached >

Re: [DISCUSS] PIP-139 : Support Broker send command to real close producer/consumer.

2022-02-28 Thread Michael Marshall
> Either replicated topic or non-replicated topic, we should provide the > same topic deletion behavior, the topic can be deleted if no active > user's producers/consumers, should not be affected by the Pulsar > internal producers/consumers. I agree with you that it'd be nice to provide the same d

Re: The pulsar node client package was mistakenly deleted on npmjs

2022-02-28 Thread Hiroyuki Sakai
Hi, Guangning I undeprecated v1.5.0 and some versions by referring to following document. https://docs.npmjs.com/deprecating-and-undeprecating-packages-or-package-versions#undeprecating-a-package-or-version At the same time, I deprecated all versions uploaded recently. Could you let me know what

Re: [DISCUSS] PIP-139 : Support Broker send command to real close producer/consumer.

2022-02-28 Thread PengHui Li
> I agree with you that it'd be nice to provide the same deletion behavior. However, because geo-replication's configuration is decentralized, I think namespace or topic deletion is more complicated than unreplicated deletion. Note that users cannot currently delete namespaces that are configured w