[GitHub] [pulsar-dotpulsar] blankensteiner merged pull request #95: Add token factory support, respond to server auth challenge on token refresh

2022-01-22 Thread GitBox
blankensteiner merged pull request #95: URL: https://github.com/apache/pulsar-dotpulsar/pull/95 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: de

[GitHub] [pulsar-dotpulsar] blankensteiner commented on pull request #95: Add token factory support, respond to server auth challenge on token refresh

2022-01-22 Thread GitBox
blankensteiner commented on pull request #95: URL: https://github.com/apache/pulsar-dotpulsar/pull/95#issuecomment-1019310909 Hi @goldenccargill I really appreciate the PR, thanks! I'll just go ahead and merge it. Then I'll do some minor changes and next week we can create a new release

[GitHub] [pulsar-helm-chart] michaeljmarshall merged pull request #113: Add multi volume support in bookkeeper.

2022-01-22 Thread GitBox
michaeljmarshall merged pull request #113: URL: https://github.com/apache/pulsar-helm-chart/pull/113 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mai

[GitHub] [pulsar-helm-chart] michaeljmarshall closed issue #112: Support multi volume in bookkeeper

2022-01-22 Thread GitBox
michaeljmarshall closed issue #112: URL: https://github.com/apache/pulsar-helm-chart/issues/112 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: de

[GitHub] [pulsar-helm-chart] michaeljmarshall commented on a change in pull request #155: Add grafana data persistence support.

2022-01-22 Thread GitBox
michaeljmarshall commented on a change in pull request #155: URL: https://github.com/apache/pulsar-helm-chart/pull/155#discussion_r790222142 ## File path: charts/pulsar/values.yaml ## @@ -988,6 +988,24 @@ grafana: requests: memory: 250Mi cpu: 0.1 + volumes:

[GitHub] [pulsar-manager] michaeljmarshall commented on issue #441: Support HerdDB in the standard docker image.

2022-01-22 Thread GitBox
michaeljmarshall commented on issue #441: URL: https://github.com/apache/pulsar-manager/issues/441#issuecomment-1019416957 @mattisonchao - what do you think about making it configurable to skip the spawning of any database process in the docker image? Then, in the Pulsar Helm Chart, we cou

[GitHub] [pulsar-helm-chart] dragonls commented on a change in pull request #155: Add grafana data persistence support.

2022-01-22 Thread GitBox
dragonls commented on a change in pull request #155: URL: https://github.com/apache/pulsar-helm-chart/pull/155#discussion_r790233237 ## File path: charts/pulsar/values.yaml ## @@ -988,6 +988,24 @@ grafana: requests: memory: 250Mi cpu: 0.1 + volumes: +# u

Re: [DISCUSSION] PIP-124: Create init subscription before sending message to DLQ

2022-01-22 Thread Michael Marshall
> users will not touch the metadata of the producer of a DLQ This is true of the DLQ producer, but by using the metadata map, won't we be exposing this feature to end users implicitly because they could add the field to the metadata map for other producers? (I am okay with giving users this functi

Re: [DISCUSS] [Transaction] Clear namespace backlog can't clear system topic and system sub backlog.

2022-01-22 Thread Michael Marshall
This is a really important thread. I think our system topic design needs more definition, structure, and documentation. Thanks for starting the thread, Bo Cong. > If the user uses it, it means that the user has considered the result of the > clear system sub backlog I think we need to discuss au

[GitHub] [pulsar-helm-chart] dragonls commented on pull request #113: Add multi volume support in bookkeeper.

2022-01-22 Thread GitBox
dragonls commented on pull request #113: URL: https://github.com/apache/pulsar-helm-chart/pull/113#issuecomment-1019429492 It seems that this PR makes CI failed. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the UR

[GitHub] [pulsar-helm-chart] lhotari merged pull request #204: Upgrade cert-manager to 1.5.4

2022-01-22 Thread GitBox
lhotari merged pull request #204: URL: https://github.com/apache/pulsar-helm-chart/pull/204 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-un

[GitHub] [pulsar-helm-chart] dragonls opened a new pull request #208: Fix ci error caused by wrong block of if clause

2022-01-22 Thread GitBox
dragonls opened a new pull request #208: URL: https://github.com/apache/pulsar-helm-chart/pull/208 Fixes #112 #113 ### Motivation Fix ci error caused by wrong block of if clause. ### Modifications Fix the wrong block of if clause. ### Verifying this change