Cutting 2.7.2 - please ping be for adding last-minute issues

2021-04-29 Thread Enrico Olivelli
Hi fellows, I am preparing 2.7.2, I saw in this issue that Matteo added the label "release/2.7.2" and merged the issue to master branch. https://github.com/apache/pulsar/pull/10413 Unfortunately in this case the PR is "closed" and marked for 2.7.2 so it looks like it has been committed to 2.7.2,

[GitHub] [pulsar-helm-chart] MMeent opened a new issue #116: annotations/`checksum/config` indentation issues

2021-04-29 Thread GitBox
MMeent opened a new issue #116: URL: https://github.com/apache/pulsar-helm-chart/issues/116 **Describe the bug** With #73, annotations were introduced that would force a restart when the related configmap changes. This, however, did not always take into account the correct indentation

[GitHub] [pulsar-helm-chart] MMeent commented on pull request #73: Updating pods on configmap change

2021-04-29 Thread GitBox
MMeent commented on pull request #73: URL: https://github.com/apache/pulsar-helm-chart/pull/73#issuecomment-829391464 I've noticed that there are indentation issues for several of the templates, so I've filed #116, and created a PR at #117 to fix those specific issues. -- This is an auto

[GitHub] [pulsar-helm-chart] MMeent opened a new pull request #117: Patch and fix 116

2021-04-29 Thread GitBox
MMeent opened a new pull request #117: URL: https://github.com/apache/pulsar-helm-chart/pull/117 Fixes #116 ### Motivation Theres indentation issues for the `checksum/config` annotation in these templates, which would either fail linting or not apply at all in some situations

[GitHub] [pulsar-dotpulsar] Chickenzilla opened a new issue #73: Off-by-one error causes protocol corruption

2021-04-29 Thread GitBox
Chickenzilla opened a new issue #73: URL: https://github.com/apache/pulsar-dotpulsar/issues/73 https://github.com/apache/pulsar-dotpulsar/blob/master/src/DotPulsar/Internal/Extensions/ReadOnlySequenceExtensions.cs#L91 can cause some sequences to be only partially read, returning incorrect

Re: Cutting 2.7.2 - please ping be for adding last-minute issues

2021-04-29 Thread Sijie Guo
Can you include these two issues? I have marked them for 2.7.2. https://github.com/apache/pulsar/pull/10420 https://github.com/apache/pulsar/pull/10416 Thanks, Sijie On Thu, Apr 29, 2021 at 12:32 AM Enrico Olivelli wrote: > Hi fellows, > I am preparing 2.7.2, > > I saw in this issue that Matt

[GitHub] [pulsar-dotpulsar] blankensteiner commented on issue #73: Off-by-one error causes protocol corruption

2021-04-29 Thread GitBox
blankensteiner commented on issue #73: URL: https://github.com/apache/pulsar-dotpulsar/issues/73#issuecomment-829524211 Hi @Chickenzilla Thanks, I'll look into it! :-) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and u

[GitHub] [pulsar-dotpulsar] blankensteiner commented on issue #73: Off-by-one error causes protocol corruption

2021-04-29 Thread GitBox
blankensteiner commented on issue #73: URL: https://github.com/apache/pulsar-dotpulsar/issues/73#issuecomment-829551837 Hi @Chickenzilla Looking good and great work with the tests! :-) Wanna create a PR for the changes to ReadOnlySequenceExtensions and ReadOnlySequenceExtensionsTests

[GitHub] [pulsar-dotpulsar] Chickenzilla commented on issue #73: Off-by-one error causes protocol corruption

2021-04-29 Thread GitBox
Chickenzilla commented on issue #73: URL: https://github.com/apache/pulsar-dotpulsar/issues/73#issuecomment-829618793 Please handle it yourself (feel free to take any/all code from my PR as desired). I've moved onto a different bug and won't have time to come back to this for at least a f

[GitHub] [pulsar-dotpulsar] blankensteiner closed issue #73: Off-by-one error causes protocol corruption

2021-04-29 Thread GitBox
blankensteiner closed issue #73: URL: https://github.com/apache/pulsar-dotpulsar/issues/73 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service,

[GitHub] [pulsar-dotpulsar] blankensteiner commented on issue #73: Off-by-one error causes protocol corruption

2021-04-29 Thread GitBox
blankensteiner commented on issue #73: URL: https://github.com/apache/pulsar-dotpulsar/issues/73#issuecomment-829852295 I have just released 1.0.2 that fixes this. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the U