[GitHub] [pulsar-dotpulsar] blankensteiner commented on a change in pull request #48: Producer for Partitioned topics

blankensteiner commented on a change in pull request #48: URL: https://github.com/apache/pulsar-dotpulsar/pull/48#discussion_r476386320 ## File path: tests/DotPulsar.Tests/DotPulsar.Tests.csproj ## @@ -7,6 +7,7 @@ + Review comment: We can add mocking and

[GitHub] [pulsar-dotpulsar] blankensteiner commented on a change in pull request #48: Producer for Partitioned topics

blankensteiner commented on a change in pull request #48: URL: https://github.com/apache/pulsar-dotpulsar/pull/48#discussion_r498656554 ## File path: src/DotPulsar/Abstractions/IMessageRouter.cs ## @@ -0,0 +1,25 @@ +/* + * Licensed under the Apache License, Version 2.0 (the "L

[GitHub] [pulsar-dotpulsar] RobertIndie commented on a change in pull request #48: Producer for Partitioned topics

RobertIndie commented on a change in pull request #48: URL: https://github.com/apache/pulsar-dotpulsar/pull/48#discussion_r498661172 ## File path: src/DotPulsar/PulsarClient.cs ## @@ -12,15 +12,22 @@ * limitations under the License. */ +using System.Runtime.CompilerServic

[GitHub] [pulsar-dotpulsar] blankensteiner commented on a change in pull request #48: Producer for Partitioned topics

blankensteiner commented on a change in pull request #48: URL: https://github.com/apache/pulsar-dotpulsar/pull/48#discussion_r498663668 ## File path: src/DotPulsar/PulsarClient.cs ## @@ -12,15 +12,22 @@ * limitations under the License. */ +using System.Runtime.CompilerSer

[GitHub] [pulsar-dotpulsar] RobertIndie commented on a change in pull request #48: Producer for Partitioned topics

RobertIndie commented on a change in pull request #48: URL: https://github.com/apache/pulsar-dotpulsar/pull/48#discussion_r498665473 ## File path: src/DotPulsar/SinglePartitionRouter.cs ## @@ -0,0 +1,41 @@ +/* + * Licensed under the Apache License, Version 2.0 (the "License");

[GitHub] [pulsar-dotpulsar] RobertIndie commented on a change in pull request #48: Producer for Partitioned topics

RobertIndie commented on a change in pull request #48: URL: https://github.com/apache/pulsar-dotpulsar/pull/48#discussion_r498668310 ## File path: src/DotPulsar/PulsarClient.cs ## @@ -12,15 +12,22 @@ * limitations under the License. */ +using System.Runtime.CompilerServic

[jira] [Created] (PULSAR-7) Possibility of data loss due to asynchronous checkpointing in kinesis consumer

Priyath Gregory created PULSAR-7: Summary: Possibility of data loss due to asynchronous checkpointing in kinesis consumer Key: PULSAR-7 URL: https://issues.apache.org/jira/browse/PULSAR-7 Project: Pul

[jira] [Updated] (PULSAR-7) Possibility of data loss due to asynchronous checkpointing in kinesis consumer

[ https://issues.apache.org/jira/browse/PULSAR-7?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Priyath Gregory updated PULSAR-7: - Issue Type: Improvement (was: Bug) > Possibility of data loss due to asynchronous checkpointing in

[jira] [Updated] (PULSAR-7) Possibility of data loss due to asynchronous checkpointing in kinesis consumer

[ https://issues.apache.org/jira/browse/PULSAR-7?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Priyath Gregory updated PULSAR-7: - Issue Type: Bug (was: Improvement) > Possibility of data loss due to asynchronous checkpointing in

[jira] [Commented] (PULSAR-7) Possibility of data loss due to asynchronous checkpointing in kinesis consumer

[ https://issues.apache.org/jira/browse/PULSAR-7?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17206589#comment-17206589 ] Priyath Gregory commented on PULSAR-7: -- This issue is tracked at [https://github.com/a