[GitHub] [pulsar-dotpulsar] blankensteiner commented on a change in pull request #50: Fix checking MessageId against null throwing NRE

2020-09-01 Thread GitBox
blankensteiner commented on a change in pull request #50: URL: https://github.com/apache/pulsar-dotpulsar/pull/50#discussion_r480917670 ## File path: src/DotPulsar/MessageId.cs ## @@ -76,13 +76,13 @@ public override bool Equals(object o) => o is MessageId id && Equ

[GitHub] [pulsar-manager] Syphixs opened a new issue #327: OAuth 2 Authentication

2020-09-01 Thread GitBox
Syphixs opened a new issue #327: URL: https://github.com/apache/pulsar-manager/issues/327 Are there any plans to support Oauth2 Tokens like the support for JWT tokens? This is an automated message from the Apache Git

[GitHub] [pulsar-dotpulsar] lee-chrisbell opened a new issue #51: SetupChannel exceptions

2020-09-01 Thread GitBox
lee-chrisbell opened a new issue #51: URL: https://github.com/apache/pulsar-dotpulsar/issues/51 When SetupChannel throws an exception, the application crashes because the method is async void. I propose catching exceptions in this method and setting the ConsumerState or ProducerSt

[GitHub] [pulsar-dotpulsar] Chickenzilla commented on a change in pull request #50: Fix checking MessageId against null throwing NRE

2020-09-01 Thread GitBox
Chickenzilla commented on a change in pull request #50: URL: https://github.com/apache/pulsar-dotpulsar/pull/50#discussion_r481288743 ## File path: src/DotPulsar/MessageId.cs ## @@ -76,13 +76,13 @@ public override bool Equals(object o) => o is MessageId id && Equal

[GitHub] [pulsar-client-node] hrsakai closed pull request #116: [Do Not Merge]This is a test for ci

2020-09-01 Thread GitBox
hrsakai closed pull request #116: URL: https://github.com/apache/pulsar-client-node/pull/116 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above

[GitHub] [pulsar-client-node] hrsakai opened a new pull request #118: [Do Not Merge]This is a test for ci

2020-09-01 Thread GitBox
hrsakai opened a new pull request #118: URL: https://github.com/apache/pulsar-client-node/pull/118 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL