Re: [DISCUSSION] Delayed message delivery

2019-01-28 Thread Ezequiel Lovelle
> What exactly is the delayed delivery use case? This is helpful on systems relaying on pulsar for persistent guarantees and using it for synchronization or some sort of checks, but on such systems is common to have some overhead committing data on persistent storage maybe due to buffered mechanis

[DISCUSS] Skip tests for documentation related changes

2019-01-28 Thread Sijie Guo
Hi all, Currently for every documentation change, we have run 3 precommit jobs, java, c++ and integrationt tests. None of them is actually testing the documentation change and it is wasting jenkins resources and make the merge process for documentation changes take much longer time. So I am propo

Re: [DISCUSS] Skip tests for documentation related changes

2019-01-28 Thread Sanjeev Kulkarni
If developers are in charge of checking the checkbox, it might lead to errors. Any way to make it automatic? Since docs are restricted to certain areas of repo, maybe we can have some rules around that? On Mon, Jan 28, 2019 at 12:12 PM Sijie Guo wrote: > Hi all, > > Currently for every documenta

Re: [DISCUSS] Skip tests for documentation related changes

2019-01-28 Thread Ali Ahmed
I support it maybe a tag in the commit Header ie [Documentation] . On Mon, Jan 28, 2019 at 12:12 PM Sijie Guo wrote: > Hi all, > > Currently for every documentation change, we have run 3 precommit jobs, > java, c++ and integrationt tests. None of them is actually testing the > documentation chan

Re: [DISCUSS] Skip tests for documentation related changes

2019-01-28 Thread Joe F
+1 to Sanjeev's suggestion On Mon, Jan 28, 2019 at 12:15 PM Sanjeev Kulkarni wrote: > If developers are in charge of checking the checkbox, it might lead to > errors. Any way to make it automatic? Since docs are restricted to certain > areas of repo, maybe we can have some rules around that? > >

Re: [DISCUSS] Skip tests for documentation related changes

2019-01-28 Thread Sijie Guo
both adding tag or checkbox are developer driven. but it is easier to achieve with current github pull request builder in Jenkins. so I think the responsibility of this approach is kind of spreading across contributors and committers. It is also a way to educate pulsar contributors to understand be

Re: [DISCUSS] Skip tests for documentation related changes

2019-01-28 Thread Dave Fisher
Hi - Inline Sent from my iPhone > On Jan 28, 2019, at 1:12 PM, Sijie Guo wrote: > > both adding tag or checkbox are developer driven. but it is easier to > achieve with current github pull request builder in Jenkins. > so I think the responsibility of this approach is kind of spreading across

Re: [DISCUSSION] Delayed message delivery

2019-01-28 Thread Ezequiel Lovelle
"I agree, but that is *not what #3155 tries to achieve." This typo made this phrase nonsense, sorry! On Mon, 28 Jan 2019, 16:44 Ezequiel Lovelle > What exactly is the delayed delivery use case? > > This is helpful on systems relaying on pulsar for persistent guarantees > and using it for synchro