Re: Working on Kafka Connector

2021-03-22 Thread Enrico Olivelli
I have sent the second part of the patch about the Kafka Source https://github.com/apache/pulsar/pull/10002 With this second patch we are able to support non String keys and also we are applying Schema information to the Pulsar topic. When the key deserializer is StringDeserializer we use the dec

Re: Working on Kafka Connector

2021-03-01 Thread Enrico Olivelli
Il Lun 1 Mar 2021, 22:20 Sijie Guo ha scritto: > Enrico - I have just reviewed the PR. I don't think you addressed your > comments. I still have the concern how this PR is implemented. I'd prefer > to keep the Kafka deserializer as simple as possible. We should keep the > schema cache and the log

Re: Working on Kafka Connector

2021-03-01 Thread Sijie Guo
Enrico - I have just reviewed the PR. I don't think you addressed your comments. I still have the concern how this PR is implemented. I'd prefer to keep the Kafka deserializer as simple as possible. We should keep the schema cache and the logic to fetch confluent schema in the source connector. -

Re: Working on Kafka Connector

2021-03-01 Thread Sijie Guo
Apologized for the delay! Reviewing it now. - Sijie On Sun, Feb 28, 2021 at 11:29 PM Enrico Olivelli wrote: > Hello, > Please bear with me, I really want this work to go forward :-) > > @Sijie, I know that you are super busy, so I would like to not put > pressure on you, and I thank you very m

Re: Working on Kafka Connector

2021-02-28 Thread Enrico Olivelli
Hello, Please bear with me, I really want this work to go forward :-) @Sijie, I know that you are super busy, so I would like to not put pressure on you, and I thank you very much for your useful comments on the PR. Our Pulsar community is big and it is still growing IMHO it would be a very good

Re: Working on Kafka Connector

2021-02-24 Thread Sijie Guo
Apologized for the delay! Will review it again today or tomorrow. - Sijie On Wed, Feb 24, 2021 at 3:49 AM Enrico Olivelli wrote: > Hello community, > It looks like only Sijie started to review this work. > https://github.com/apache/pulsar/pull/9448 > > I wonder if others that are interested in

Re: Working on Kafka Connector

2021-02-24 Thread Enrico Olivelli
Hello community, It looks like only Sijie started to review this work. https://github.com/apache/pulsar/pull/9448 I wonder if others that are interested in Kafka compatibility may have time to check it out As said, this is only the first part of a series of implementations we want to do about th

Re: Working on Kafka Connector

2021-02-15 Thread Sijie Guo
Thanks, I will review the PR. - Sijie On Mon, Feb 15, 2021 at 2:47 AM Enrico Olivelli wrote: > Sijie, > > I managed to implement Avro support In KafkaBytesSource following your > suggestions. Thanks. > > I would like to commit this initial patch and then add support for all of > the primitive S

Re: Working on Kafka Connector

2021-02-15 Thread Enrico Olivelli
Sijie, I managed to implement Avro support In KafkaBytesSource following your suggestions. Thanks. I would like to commit this initial patch and then add support for all of the primitive Schemas as you did in (1) and for JSON. If you prefer I can continue to enhance this patch. Enrico (1) https

Re: Working on Kafka Connector

2021-02-14 Thread Sijie Guo
Hi Enrico, Thank you for working on this! But as I mentioned in the pull request, we should avoid using a one-connector-per-schema model. That model probably works with other connectors that have a very limited number of schemas. If you are going to implement a schema-aware Kafka connector, that

Working on Kafka Connector

2021-02-11 Thread Enrico Olivelli
Hello everyone, here in our Pulsar repository we have a simple Kafka Connector for Pulsar IO composed by a Sink and a Source. https://github.com/apache/pulsar/tree/master/pulsar-io/kafka I have started to work on a set of enhancements to this connector in order to make it more powerful and to bett