Re: Requiring all conversations on code to be resolved before merging PRs

2024-01-02 Thread tison
Thanks for starting this thread. Reply on the PR. Best, tison. Lari Hotari 于2024年1月2日周二 16:34写道: > > Hi all, > > I have made a PR that changes the GitHub protected branch settings for the > master branch in apache/pulsar so that all conversations on code must be > resolved before a PR can be m

Requiring all conversations on code to be resolved before merging PRs

2024-01-02 Thread Lari Hotari
Hi all, I have made a PR that changes the GitHub protected branch settings for the master branch in apache/pulsar so that all conversations on code must be resolved before a PR can be merged. Please review: https://github.com/apache/pulsar/pull/21832 -Lari