Re: Reporting and tooling to detect thread leaks in Pulsar tests

2023-10-30 Thread Asaf Mesika
Ok, got it. While scrolling down on the main page, and cursor is on the graph, nothing happens. When you move the mouse away from the graph, you scroll and then you see those annotations. Very nice additions and good to generally know about them. On Mon, Oct 30, 2023 at 10:53 AM Lari Hotari wrot

Re: Reporting and tooling to detect thread leaks in Pulsar tests

2023-10-30 Thread Lari Hotari
Thanks for the review. I merged the PR and triggered a manual build https://github.com/apache/pulsar/actions/runs/6690374946 to get the latest report of leaked threads. -Lari On Mon, 30 Oct 2023, 9.15 Enrico Olivelli, wrote: > Il Lun 30 Ott 2023, 06:39 Lari Hotari ha scritto: > > > Hi Asaf, >

Re: Reporting and tooling to detect thread leaks in Pulsar tests

2023-10-30 Thread Enrico Olivelli
Il Lun 30 Ott 2023, 06:39 Lari Hotari ha scritto: > Hi Asaf, > > Yes, the visibility aspect is already solved by using warnings in the > summary view. Please check the example > https://github.com/apache/pulsar/actions/runs/6680066364?pr=21450 . > > Job summaries could also be used, but they have

Re: Reporting and tooling to detect thread leaks in Pulsar tests

2023-10-29 Thread Lari Hotari
Hi Asaf, Yes, the visibility aspect is already solved by using warnings in the summary view. Please check the example https://github.com/apache/pulsar/actions/runs/6680066364?pr=21450 . Job summaries could also be used, but they have less visibility in the summary view, as you can see from the

Re: Reporting and tooling to detect thread leaks in Pulsar tests

2023-10-29 Thread Asaf Mesika
Larry, I know there is a way to add like a Job summary, so we can write it there - do you think this can increase visibility? On Sun, Oct 29, 2023 at 4:53 AM Lari Hotari wrote: > Hi all, > > I have submitted a PR (https://github.com/apache/pulsar/pull/21450) which > includes changes to add repor