Re: [DISCUSSION] PIP-120: Enable client memory limit by default

2021-12-22 Thread Michael Marshall
That makes sense, thank you for your explanation, Matteo. - Michael On Tue, Dec 21, 2021 at 4:03 PM Matteo Merli wrote: > > > Did you consider determining the default limit by inspecting the JVM's > > runtime? > > For example, in the broker, we set `maxMessagePublishBufferSizeInMB` to 1/2 > > o

Re: [DISCUSSION] PIP-120: Enable client memory limit by default

2021-12-21 Thread Matteo Merli
> Did you consider determining the default limit by inspecting the JVM's > runtime? > For example, in the broker, we set `maxMessagePublishBufferSizeInMB` to 1/2 > of direct memory, by default. > > I concede that this config is more complicated than a broker config since > we're talking about a cl

Re: [DISCUSSION] PIP-120: Enable client memory limit by default

2021-12-20 Thread Michael Marshall
> I think it's a good time for 2.10 to enable this setting by default and, > correspondingly, to disable by default the producer queue size limit. +1 > 64MB is picked because it's a small enough memory size that will guarantee > a very high producer throughput, irrespective of the individual mess

Re: [DISCUSSION] PIP-120: Enable client memory limit by default

2021-12-19 Thread Lan Liang
+1 On 12/17/2021 14:43,mattison chao wrote: +1 On Fri, 17 Dec 2021 at 13:56, 陳智弘 wrote: +1 Sijie Guo 於 2021年12月17日 週五 12:38 寫道: +1 On Tue, Dec 14, 2021 at 11:20 AM Matteo Merli wrote: https://github.com/apache/pulsar/issues/13306 Pasted below for quoting convenience. ## Mot

Re: [DISCUSSION] PIP-120: Enable client memory limit by default

2021-12-16 Thread mattison chao
+1 On Fri, 17 Dec 2021 at 13:56, 陳智弘 wrote: > +1 > > Sijie Guo 於 2021年12月17日 週五 12:38 寫道: > > > +1 > > > > On Tue, Dec 14, 2021 at 11:20 AM Matteo Merli wrote: > > > > > https://github.com/apache/pulsar/issues/13306 > > > > > > > > > Pasted below for quoting convenience. > > > > > > > > >

Re: [DISCUSSION] PIP-120: Enable client memory limit by default

2021-12-16 Thread 陳智弘
+1 Sijie Guo 於 2021年12月17日 週五 12:38 寫道: > +1 > > On Tue, Dec 14, 2021 at 11:20 AM Matteo Merli wrote: > > > https://github.com/apache/pulsar/issues/13306 > > > > > > Pasted below for quoting convenience. > > > > > > > > > > ## Motivation > > > > In Pulsar 2.8, we have introduced a sett

Re: [DISCUSSION] PIP-120: Enable client memory limit by default

2021-12-16 Thread Sijie Guo
+1 On Tue, Dec 14, 2021 at 11:20 AM Matteo Merli wrote: > https://github.com/apache/pulsar/issues/13306 > > > Pasted below for quoting convenience. > > > > > ## Motivation > > In Pulsar 2.8, we have introduced a setting to control the amount of memory > used by a client instance. > > ``

Re: [DISCUSSION] PIP-120: Enable client memory limit by default

2021-12-15 Thread Haiting Jiang
+1 (non-binding) Haiting On 2021/12/14 19:20:02 Matteo Merli wrote: > https://github.com/apache/pulsar/issues/13306 > > > Pasted below for quoting convenience. > > > > > ## Motivation > > In Pulsar 2.8, we have introduced a setting to control the amount of memory > used by a client

Re: [DISCUSSION] PIP-120: Enable client memory limit by default

2021-12-14 Thread Enrico Olivelli
+1 Enrico Il Mer 15 Dic 2021, 06:03 ZhangJian He ha scritto: > +1 > > Thanks > ZhangJian He > > Neng Lu 于2021年12月15日周三 12:52写道: > > > +1 (non-binding) > > > > On 2021/12/14 19:20:02 Matteo Merli wrote: > > > https://github.com/apache/pulsar/issues/13306 > > > > > > > > > Pasted below for quoti

Re: [DISCUSSION] PIP-120: Enable client memory limit by default

2021-12-14 Thread ZhangJian He
+1 Thanks ZhangJian He Neng Lu 于2021年12月15日周三 12:52写道: > +1 (non-binding) > > On 2021/12/14 19:20:02 Matteo Merli wrote: > > https://github.com/apache/pulsar/issues/13306 > > > > > > Pasted below for quoting convenience. > > > > > > > > > > ## Motivation > > > > In Pulsar 2.8, we have

Re: [DISCUSSION] PIP-120: Enable client memory limit by default

2021-12-14 Thread Neng Lu
+1 (non-binding) On 2021/12/14 19:20:02 Matteo Merli wrote: > https://github.com/apache/pulsar/issues/13306 > > > Pasted below for quoting convenience. > > > > > ## Motivation > > In Pulsar 2.8, we have introduced a setting to control the amount of memory > used by a client instance

Re: [DISCUSSION] PIP-120: Enable client memory limit by default

2021-12-14 Thread Hang Chen
+1 Thanks, Hang PengHui Li 于2021年12月15日周三 07:50写道: > > +1 > > Penghui > > On Wed, Dec 15, 2021 at 3:20 AM Matteo Merli wrote: > > > https://github.com/apache/pulsar/issues/13306 > > > > > > Pasted below for quoting convenience. > > > > > > > > > > ## Motivation > > > > In Pulsar 2.8, w

Re: [DISCUSSION] PIP-120: Enable client memory limit by default

2021-12-14 Thread PengHui Li
+1 Penghui On Wed, Dec 15, 2021 at 3:20 AM Matteo Merli wrote: > https://github.com/apache/pulsar/issues/13306 > > > Pasted below for quoting convenience. > > > > > ## Motivation > > In Pulsar 2.8, we have introduced a setting to control the amount of memory > used by a client instance