Re: [VOTE] Reactive Java client for Apache Pulsar 0.1.0 Candidate 1, #2 vote

2022-12-08 Thread Lari Hotari
Thank you, Dave, for validating the release requirements. The PR https://github.com/apache/pulsar-client-reactive/pull/101 contains fixes. This vote for pulsar-client-reactive 0.1.0 candidate 1 release is over. I'll start a new rc after the fixes have been merged. -Lari On 2022/12/07 21:42:

Re: [VOTE] Reactive Java client for Apache Pulsar 0.1.0 Candidate 1, #2 vote

2022-12-07 Thread Christophe Bornet
Good points Dave. Thanks for your feedback. Le mer. 7 déc. 2022 à 22:43, Dave Fisher a écrit : > Hi - > > -1 (binding) > > 1. grade-wrapper.jar is a compiled binary and is not allowed. You can > provide a script to be run to download it. See > issues.apache.org/jira/browse/CALCITE-4575 > > 2. NO

Re: [VOTE] Reactive Java client for Apache Pulsar 0.1.0 Candidate 1, #2 vote

2022-12-07 Thread Dave Fisher
Hi - -1 (binding) 1. grade-wrapper.jar is a compiled binary and is not allowed. You can provide a script to be run to download it. See issues.apache.org/jira/browse/CALCITE-4575 2. NOTICE file is missing. See apache.org/legal/src-headers.html#notice 3. A few of the *.gradle files are missing A

Re: [VOTE] Reactive Java client for Apache Pulsar 0.1.0 Candidate 1, #2 vote

2022-12-07 Thread Lari Hotari
+1, binding - sources, signature and checksums validated - sha512 checksum matches c10ec566d6f758b6a3c09f957e3e6005fdee8d8b9979b84cb33c9feae6fe28c84e198387fe0b92b6e1c697dd8e454b5a1b04565a74560a36259c35bfcfffccd2 - signature is valid - sources match git tag v0.1.0-candidate-1 (052a219334f6

Re: [VOTE] Reactive Java client for Apache Pulsar 0.1.0 Candidate 1

2022-12-07 Thread Lari Hotari
After consulting with Dave Fisher, I'm ending this first vote since it didn't contain all necessary details (the source artifact location and checksum). This vote thread is ended and I'll re-open a new thread for the actual vote. -Lari On 2022/12/07 19:09:23 Christophe Bornet wrote: > Followin

Re: [VOTE] Reactive Java client for Apache Pulsar 0.1.0 Candidate 1

2022-12-07 Thread Lari Hotari
+1, binding - sources, signature and checksums validated - Staged maven artifacts validated with a simple pulsar-client-reactive application. (followed https://github.com/apache/pulsar-client-reactive/wiki/Release-process#release-validation for validation) -Lari On 2022/12/07 19:09:23 Christo

Re: [VOTE] Reactive Java client for Apache Pulsar 0.1.0 Candidate 1

2022-12-07 Thread Lari Hotari
Since this is a new module, it's the first time we are setting up the release process. I have pushed the sources for voting to this location: https://dist.apache.org/repos/dist/dev/pulsar/pulsar-client-reactive-0.1.0-candidate-1/ The sources are the same as in the opening voting mail that Christ