Re: [DISCUSS] Subscription Naming Rules

2022-10-01 Thread lordcheng10
> Overall, I support setting naming restrictions on topic name and > subscription name. > But we must consider the compatibility since it would be a big break change. > One possible option would be adding a config entry in broker.conf for > the naming regex on topic and > subscriptions, with defaul

Re: [DISCUSS] Subscription Naming Rules

2022-10-01 Thread lordcheng10
> The namespace, cluster and topic names are checked by the org.apache.pulsar.common.naming.NamedEntity#checkName method, which requires names to contain only (a-zA-Z_0-9) or these special chars -=:.% . Sorry, the description is wrong here. The namespace, cluster names are checked by the org.apach

Re: [DISCUSS] Subscription Naming Rules

2022-10-01 Thread lordcheng10
> I think the subscription name should not contain special characters. It should keep the same naming rule with the topic. The namespace, cluster and topic names are checked by the org.apache.pulsar.common.naming.NamedEntity#checkName method, which requires names to contain only (a-zA-Z_0-9) or th

Re: [DISCUSS] Subscription Naming Rules

2022-10-01 Thread Haiting Jiang
> I think the subscription name should not contain special characters. It > should keep the same naming rule with the topic. Currently, we have entify naming restrictions on cluster/tenant/namespace, but not on topic names, see [1]. We can create topics like "persistent://public/default/###". Ove

Re: [DISCUSS] Subscription Naming Rules

2022-09-30 Thread Jiaqi Shen
+1 Add a subscription name naming rule, for example: can only contain these characters "a-zA-Z_0-9" or "-=:.%". I think the subscription name should not contain special characters. It should keep the same naming rule with the topic. lordcheng10 于2022年10月1日周六 11:12写道: > Corresponding PR: > http

Re: [DISCUSS] Subscription Naming Rules

2022-09-30 Thread lordcheng10
Corresponding PR: https://github.com/apache/pulsar/pull/17151 lordcheng10 于2022年10月1日周六 11:10写道: > Hello, Pulsar community: > When creating a subscription, pulsar does not verify the name of the > subscription, so the subscription name may contain some invisible > characters in the created subsc