Re: Re: [DISCUSS] Propose a Contributor Repository for Pulsar

Besides, this proposal is a bit different from other PIPs. A normal workflow for a PIP should be: 1. Discuss and vote for the proposal that contains high level design (it requires 3 binding +1s from PMC members) 2. Review the PR that implements the design in details (it requires a successful CI wor

Re: Re: [DISCUSS] Propose a Contributor Repository for Pulsar

Hi Dave, We had some offline discussions with the author last week about this repo. So let me clarify some points here. First, I voted -1 against making https://github.com/StevenLuMT/pulsar-java-contrib managed by Apache. As you can see, there are no licenses, no tests, no test workflows, no rele

RE: Re: [DISCUSS] Propose a Contributor Repository for Pulsar

Hi Yunze, A few of your points are of concern and to me could be good arguments for this extra code repository. On 2024/08/05 13:25:24 Yunze Xu wrote: > Let's ignore the last sentence I mentioned. I mentioned my suspicion > because I have concerns about the lifetime of this repo. It's > clarifie

Re: [DISCUSS] Propose a Contributor Repository for Pulsar

Let's ignore the last sentence I mentioned. I mentioned my suspicion because I have concerns about the lifetime of this repo. It's clarified privately so I'm apologizing for my conjecture about the company. So let's focus on the topic itself. Even without the concern about the lifetime, this repo

Re: [DISCUSS] Propose a Contributor Repository for Pulsar

I just thought again about the "best practice" part. Why not contribute it to the Apache official website (https://github.com/apache/pulsar-site)? Thanks, Yunze On Mon, Aug 5, 2024 at 8:46 PM Yunze Xu wrote: > > TL;DR, such a repository is not necessary to be contributed to Apache. > > Actually,

Re: [DISCUSS] Propose a Contributor Repository for Pulsar

TL;DR, such a repository is not necessary to be contributed to Apache. Actually, only the "Collect user best practices" point makes sense to me. The reason to have so many pluggables is exactly to avoid the core repo being not so bloated. Yeah, OTel is a good example. But IMHO, Pulsar is far less

Re: [DISCUSS] Propose a Contributor Repository for Pulsar

Dear all, I would like to express my appreciation to all of you who have shown support for my recent proposal. Your feedback and encouragement are greatly appreciated and have been instrumental in moving the discussion forward. I am pleased to announce that I have initiated a vote on this proposa

Re: [DISCUSS] Propose a Contributor Repository for Pulsar

Hi - I renamed the PIP PR to include the PIP number - PIP-367. - https://github.com/apache/pulsar/pull/23061 I think that you have covered concerns and it is time to start a separate VOTE thread. Assuming that the PIP passes then we can create the new repository by following your example and a

Re: [DISCUSS] Propose a Contributor Repository for Pulsar

Dear Dave and Enrico, Thank you for your reply and valuable comments. I think the point that needs to be clarified now is whether this repository needs to be released. In the original idea, the functions in this repository are not stable. It will be used to collect various experimental functions a

Re: [DISCUSS] Propose a Contributor Repository for Pulsar

> On Jul 29, 2024, at 6:37 AM, Enrico Olivelli wrote: > > Il giorno lun 29 lug 2024 alle ore 11:55 steven lu > ha scritto: > >> Different from pulsar-adapters, we added some instructions and examples >> here https://github.com/StevenLuMT/pulsar-java-contrib > > > This example is clear, than

Re: [DISCUSS] Propose a Contributor Repository for Pulsar

Il giorno lun 29 lug 2024 alle ore 11:55 steven lu ha scritto: > Different from pulsar-adapters, we added some instructions and examples > here https://github.com/StevenLuMT/pulsar-java-contrib This example is clear, thanks ! Let's put it this way: +0 I am not against this proposal, but I woul

Re: [DISCUSS] Propose a Contributor Repository for Pulsar

Different from pulsar-adapters, we added some instructions and examples here https://github.com/StevenLuMT/pulsar-java-contrib Enrico Olivelli 于2024年7月23日周二 17:45写道： > Probably this repository is already what you want to do: > https://github.com/apache/pulsar-adapters > > It contains a lot of di

Re: [DISCUSS] Propose a Contributor Repository for Pulsar

Probably this repository is already what you want to do: https://github.com/apache/pulsar-adapters It contains a lot of different stuff that we don't keep in the main pulsar repository. Enrico Il giorno mar 23 lug 2024 alle ore 09:51 Jia Zhai ha scritto: > Thanks for the proposal. It is a goo

Re: [DISCUSS] Propose a Contributor Repository for Pulsar

Thanks for the proposal. It is a good idea. It is also not a bad idea to incubate it outside of Pulsar official repository at first. On Tue, Jul 23, 2024 at 2:59 PM Aurora Twinkle wrote: > Hi: > I think this is a very good idea. > > In the native pulsar warehouse, there are some interfaces that

Re: [DISCUSS] Propose a Contributor Repository for Pulsar

Hi: I think this is a very good idea. In the native pulsar warehouse, there are some interfaces that have no default implementation classes, such as ConsumerInterceptor, ProducerInterceptor. Users must implement the interface themselves, which increases the cost of use. If there is a plug-in libra

Re: [DISCUSS] Propose a Contributor Repository for Pulsar

Hello Wen Zhi, This project is a new repository similar to a connector, and it will not make any modifications to Pulsar itself. [0] Its code part is simply a plugin library, based on Pulsar's external interfaces, providing a rich set of implementations. It only retains a "curated list", which is

Re: [DISCUSS] Propose a Contributor Repository for Pulsar

Hi, xiangying, First of all, thanks for driving the proposal. I have some questions. 1. Will this repository maintained by committers/pmc? If the answer is yes, there will be too many new modules introduced into pulsar and hard to maintain. If the answer is no, i think we have better not

Re: [DISCUSS] Propose a Contributor Repository for Pulsar

Thank you for your feedback, let's further clarify this matter. The original design of this proposal is a new contributor repository, and provides two ways to contribute. The first one: Contributors contribute through PR and accept code review, and can only be merged into the main branch after rev

Re: [DISCUSS] Propose a Contributor Repository for Pulsar

Il giorno lun 22 lug 2024 alle ore 17:34 xiangying meng < xiangyingme...@gmail.com> ha scritto: > >thanks for your proposal, we need more and more energy in the project. > > Yes, it requires a lot of participation, but sometimes we also need a > start. > > >Also we allow only "committers" to commi

Re: [DISCUSS] Propose a Contributor Repository for Pulsar

>thanks for your proposal, we need more and more energy in the project. Yes, it requires a lot of participation, but sometimes we also need a start. >Also we allow only "committers" to commit patches to the repositories that are >under the responsibility of the Apache Pulsar PMC, I don't know ho

Re: [DISCUSS] Propose a Contributor Repository for Pulsar

Hello, thanks for your proposal, we need more and more energy in the project. I don't think that this is a good idea. The main reason is that as an ASF project we must guarantee the quality and especially the security of what we provide to the public. Such kinds of repositories tend to become fu

Re: [DISCUSS] Propose a Contributor Repository for Pulsar

We think this is a very good solution, Our XHS team(@liangyepianzhou @AuroraTwinkle @StevenLuMT @cai152 ) will submit a few to pulsar-java-contrib