+1 (binding)
Enrico
Il giorno mar 9 mag 2023 alle ore 08:10 Yunze Xu ha scritto:
>
> +1 (binding)
>
> The separated TopicBundleAssignmentStrategy and bundleSplitListener LGTM.
>
> Typo:
> * TopicBunldeAssignmentFactory -> TopicBundleAssignmentFactory
> * TopicBunldeAssignmentStrategy -> TopicBun
+1 (non-binding)
hope to see this feature!
+1 (binding)
The separated TopicBundleAssignmentStrategy and bundleSplitListener LGTM.
Typo:
* TopicBunldeAssignmentFactory -> TopicBundleAssignmentFactory
* TopicBunldeAssignmentStrategy -> TopicBundleAssignmentStrategy
Thanks,
Yunze
On Tue, May 9, 2023 at 1:17 PM PengHui Li wrote:
>
> Hi Lin
Hi Lin,
I noticed the PIP is updated, and thanks for addressing my comments.
It looks good to me now.
+1 (binding)
Regards,
Penghui
On Mon, May 8, 2023 at 5:16 PM PengHui Li wrote:
> I'm sorry for not getting back to you sooner.
>
> From the description of the proposal. You have figured out t
I'm sorry for not getting back to you sooner.
>From the description of the proposal. You have figured out the problems
with the current
solution. From my understanding, only the first one is in the scope of this
proposal.
The other two problems, one is about the issue from ThresholdShedder and
ano