Re: Proposal to change how git checkout is done for PR builds

2021-03-18 Thread Lari Hotari
I created a PR for making this change: https://github.com/apache/pulsar/pull/9963 . On Wed, Mar 17, 2021 at 6:23 PM Matteo Merli wrote: > +1 That was the behavior we used to have in Jenkins. > > > -- > Matteo Merli > > > On Wed, Mar 17, 2021 at 8:15 AM Michael Marshall > wrote: > > > > +1 > >

Re: Proposal to change how git checkout is done for PR builds

2021-03-17 Thread Matteo Merli
+1 That was the behavior we used to have in Jenkins. -- Matteo Merli On Wed, Mar 17, 2021 at 8:15 AM Michael Marshall wrote: > > +1 > > I like the idea that this change would give PRs the benefit of any recently > fixed flaky tests without needing to rebase. Rebasing to pick up fixes to > flak

Re: Proposal to change how git checkout is done for PR builds

2021-03-17 Thread Michael Marshall
+1 I like the idea that this change would give PRs the benefit of any recently fixed flaky tests without needing to rebase. Rebasing to pick up fixes to flaky tests slows down development. Further, I think this sounds like a safer paradigm for maintaining a pristine master branch. Michael On We

Re: Proposal to change how git checkout is done for PR builds

2021-03-17 Thread Enrico Olivelli
Il giorno mer 17 mar 2021 alle ore 08:56 Lari Hotari ha scritto: > > Dear Pulsar community members, > > I would like to propose a change how Pull Request (PR) builds are handled > in Pulsar CI. > > In GitHub Actions, the default way to handle PR builds is to checkout > GitHub provided merge_commit

Proposal to change how git checkout is done for PR builds

2021-03-17 Thread Lari Hotari
Dear Pulsar community members, I would like to propose a change how Pull Request (PR) builds are handled in Pulsar CI. In GitHub Actions, the default way to handle PR builds is to checkout GitHub provided merge_commit_sha . GitHub's merge_commit_sha is explained in this documentation: https://do