since there is no objection, I will then merge this PR and let's try out
the process. If it becomes a problem, we can revert it back.
- Sijie
On Mon, Jan 14, 2019 at 2:39 PM Sijie Guo wrote:
> Any other thoughts? Currently this PR has 3 approvals. If no major
> objection, maybe we can merge it
Any other thoughts? Currently this PR has 3 approvals. If no major
objection, maybe we can merge it and try the process.
If it doesn't work out well, we can revert and move it to contributing
guide. How does that sound?
- Sijie
On Thu, Jan 3, 2019 at 6:03 PM Sijie Guo wrote:
> I think putting i
I think putting it in a CONTRIBUTING file doesn't resolve the concerns I
have raised.
One of the problems I have seen over the pull requests is that we don't
really establish any review process
between contributors and reviewers. Important things like documentation,
website updates, and backward co
Instead of placing this content in PULL_REQUEST_TEMPLATE.md I would rather
have it in CONTRIBUTING.md file.
The reason is that currently even the minimal PULL_REQUEST_TEMPLATE is
being left as it is and not interpreted as a "template" to
modifiy when creating a PR. Also I'd change the current tem
If there is no objection or no more review comments, I would like to merge
and close the issue tomorrow.
(btw, happy new year to everyone in the community!)
- Sijie
On Wed, Dec 26, 2018 at 9:41 AM Sijie Guo wrote:
> FYI. I've updated the pull request to incorporate Eren's suggestions.
>
> - Si
FYI. I've updated the pull request to incorporate Eren's suggestions.
- Sijie
On Tue, Dec 25, 2018 at 5:08 PM Jia Zhai wrote:
> +1, for Eren's and Raj's useful comments.
>
> On Wed, Dec 26, 2018 at 3:36 AM Eren Avsarogullari <
> erenavsarogull...@gmail.com> wrote:
>
> > Thanks Sijie.
> >
> > On
+1, for Eren's and Raj's useful comments.
On Wed, Dec 26, 2018 at 3:36 AM Eren Avsarogullari <
erenavsarogull...@gmail.com> wrote:
> Thanks Sijie.
>
> On Tue, 25 Dec 2018 at 18:14, Sijie Guo wrote:
>
> > Thank y'all for your feedback. I created a PR for this PIP -
> > https://github.com/apache/p
Thanks Sijie.
On Tue, 25 Dec 2018 at 18:14, Sijie Guo wrote:
> Thank y'all for your feedback. I created a PR for this PIP -
> https://github.com/apache/pulsar/pull/3252
>
> However I missed Eren's comments before. I will incorporate your comments
> into the PR.
>
> Thank you,
> Sijie
>
> On Fri,
Thank y'all for your feedback. I created a PR for this PIP -
https://github.com/apache/pulsar/pull/3252
However I missed Eren's comments before. I will incorporate your comments
into the PR.
Thank you,
Sijie
On Fri, Dec 21, 2018 at 2:28 PM Eren Avsarogullari <
erenavsarogull...@gmail.com> wrote:
Hi All,
+1.
I have also a couple of addition:
1- Issue Id can also be added to title if we have. This template is also
used by Apache Spark.
e.g: [Issue-Id][Component] Title
2- If created PR is a following one with existing PR, it can be useful to
be linked/mentioned in new one for reviewers.
Agree. For System like pulsar Documentation and Stability is far more
important to gain large-scale adoption.
On Fri, 21 Dec 2018 at 11:24, Sijie Guo wrote:
> Hi all,
>
> With the increase of contributions, more and more features are added pretty
> quickly.
> However, these features are either
Hi all,
With the increase of contributions, more and more features are added pretty
quickly.
However, these features are either not well documented or introducing
breaking changes.
There is no process for both contributors and reviewers to understand the
impact of their changes.
I am proposing im
12 matches
Mail list logo
