Re: PIP-214 has been proceeded without consensus

2023-03-30 Thread tison
Hi Yu, Your comment is out of the scope of this thread. I suggest you start a dedicated thread for the very topic. N.B. PIP-214 is not about adding connectors. And I merged the Alluxio connector[1] without a PIP. Best, tison. [1] https://github.com/apache/pulsar/pull/3823 Liu Yu 于2023年3月30日周

Re: PIP-214 has been proceeded without consensus

2023-03-30 Thread Liu Yu
Double-check: do we need a PIP for newly added connectors? https://github.com/apache/pulsar/pull/19821#issuecomment-1488860517 On 2023/03/27 14:14:23 tison wrote: > Hi Asaf, > > > Shouldn’t poeople that has write access to merge must first validate of > course if PIP is approved before merge? >

Re: PIP-214 has been proceeded without consensus

2023-03-27 Thread tison
Hi Asaf, > Shouldn’t poeople that has write access to merge must first validate of course if PIP is approved before merge? Yeah. I think they should have to. Now we have two issues here: 1. Since the patch is merged, I send a notice here so that if anyone objects this proposal, they can raise a

Re: PIP-214 has been proceeded without consensus

2023-03-27 Thread Asaf Mesika
I don’t a role in Pulsar. I reviewed the code and it was altered until it was satisfactory. Shouldn’t poeople that has write access to merge must first validate of course if PIP is approved before merge? > On 26 Mar 2023, at 15:27, tison wrote: > > Hi, > > I noticed that PIP-214[1] "Add bro

PIP-214 has been proceeded without consensus

2023-03-26 Thread tison
Hi, I noticed that PIP-214[1] "Add broker level metrics statistics and expose to prometheus" was discussed at [2], but we didn't start a vote. However, the patch and doc updates were merged [3][4]. When trying to close the issue, I found this case, and I'm wondering if it's not a proposal or we