Hi Jon
Thanks! I have commented on the PR :-)
Best regards
db
Jon Klinaku skrev den 2025-02-15 22:56:
Hi,
I have made a pull request regarding an enhancement on pulsar-dotpulsar
project for adding avro schema support. I am interested to know what
the
next steps are, could you please let me
Hi,
I have made a pull request regarding an enhancement on pulsar-dotpulsar
project for adding avro schema support. I am interested to know what the
next steps are, could you please let me know? Thank you.
Pr: https://github.com/apache/pulsar-dotpulsar/pull/253
P.S. sorry if i skiped a few steps,
gt;> be
>>> > >> useful
>>> > >> > to
>>> > >> > > > be linked/mentioned in new one for reviewers.
>>> > >> > > >
>>> > >> > > > 3- When PR is created, single commit can be preferable.
cks. So, reviewer can track
>> > recent
>> > >> > > > commits.
>> > >> > > >
>> > >> > > > 4- Unit/Integration Test execution time check can be useful
>> (For
>> > >> > general
>> > >
e under control as the long-term)
> > >> > > >
> > >> > > > 5- If build is broken due to an irrelevant test, then Issue
> > creation
> > >> > (if
> > >> > > > not exist) can be useful to track and force robustness of th
> > > 5- If build is broken due to an irrelevant test, then Issue
> creation
> >> > (if
> >> > > > not exist) can be useful to track and force robustness of the
> flaky
> >> > test.
> >> > > >
> >> > > > Thanks,
; test.
>> > > >
>> > > > Thanks,
>> > > > Eren
>> > > >
>> > > > On Fri, 21 Dec 2018 at 14:47, Yuva raj wrote:
>> > > >
>> > > > > Agree. For System like pulsar Documentation and Stability is fa
> >
> > > > > Agree. For System like pulsar Documentation and Stability is far
> more
> > > > > important to gain large-scale adoption.
> > > > >
> > > > > On Fri, 21 Dec 2018 at 11:24, Sijie Guo
> wrote:
> > > > >
ain large-scale adoption.
> > > >
> > > > On Fri, 21 Dec 2018 at 11:24, Sijie Guo wrote:
> > > >
> > > > > Hi all,
> > > > >
> > > > > With the increase of contributions, more and more features are
> added
> &g
>
> > > > Hi all,
> > > >
> > > > With the increase of contributions, more and more features are added
> > > pretty
> > > > quickly.
> > > > However, these features are either not well documented or introducing
> > &
Sijie Guo wrote:
> >
> > > Hi all,
> > >
> > > With the increase of contributions, more and more features are added
> > pretty
> > > quickly.
> > > However, these features are either not well documented or introducing
> > > breaking chang
these features are either not well documented or introducing
> > breaking changes.
> > There is no process for both contributors and reviewers to understand the
> > impact of their changes.
> >
> > I am proposing improve the github pull request template to add a
> check
ures are either not well documented or introducing
> breaking changes.
> There is no process for both contributors and reviewers to understand the
> impact of their changes.
>
> I am proposing improve the github pull request template to add a checklist
> for contributors
> t
improve the github pull request template to add a checklist
for contributors
to understand what are the impacts of their changes. It can also improve
the review process.
Please take a look and let me know what you think.
https://github.com/apache/pulsar/wiki/PIP-27%3A-Add-checklist-in-github-pull
14 matches
Mail list logo