Re: Discussing negative acknowledgment in batch default behavior

2022-05-23 Thread Enrico Olivelli
Asaf, would you like to send a PR ? Enrico Il giorno lun 23 mag 2022 alle ore 13:38 PengHui Li ha scritto: > > I support enabling it in 2.11.0 > > Without the `Acknowledgement in Batch Level index` > Users will see a weird behavior `the acked messages dispatched to the > consumer again` > Many n

Re: Discussing negative acknowledgment in batch default behavior

2022-05-23 Thread PengHui Li
I support enabling it in 2.11.0 Without the `Acknowledgement in Batch Level index` Users will see a weird behavior `the acked messages dispatched to the consumer again` Many new users thought it was a bug. For the default configuration, we should be more friendly to new users, because they have t

Re: Discussing negative acknowledgment in batch default behavior

2022-05-23 Thread Enrico Olivelli
Asaf, I don't have numbers to say something about the runtime impact. It is a important feature and I am +1 to enabling it by default You can send a PR in the meantime. I am not sure about the impact on the tests, maybe we will have to take a look carefully in order to not introduce new flaky tes

Re: Discussing negative acknowledgment in batch default behavior

2022-05-22 Thread Asaf Mesika
Resurfacing this as it seems (to me) an important correction to be made. Would love your opinions on this. Thanks! Asaf On Wed, May 11, 2022 at 1:16 PM Asaf Mesika wrote: > Hello all, > > I have a question regarding a feature introduced in 2.6.0 called Negative > Acknowledgement in Batch Leve

Discussing negative acknowledgment in batch default behavior

2022-05-11 Thread Asaf Mesika
Hello all, I have a question regarding a feature introduced in 2.6.0 called Negative Acknowledgement in Batch Level index, described in PIP-54 . In short: Before this feature, if you would write in batches