Re: Disabling ci tests for documentation changes

2019-09-21 Thread Ali Ahmed
I am done with my research , we have a skip ci phrase in the jenkins and it works as expected. eg https://github.com/apache/pulsar/pull/5244. The issue is github is configured to expect a response always, we can consider changing that. But this will open the repo to potential problem. As there wil

Re: Disabling ci tests for documentation changes

2019-09-19 Thread Matteo Merli
Another viable option could be to move the site to a separate "pulsar-site" git repo. That would again require some work, but it would be a cleaner long-term approach. -- Matteo Merli On Wed, Sep 18, 2019 at 4:38 PM Sijie Guo wrote: > > +1 > > The later approach seems to be better to me. Please

Re: Disabling ci tests for documentation changes

2019-09-18 Thread Sijie Guo
+1 The later approach seems to be better to me. Please remember syncing the jenkins job configuration back to the jenkins job configurations. https://github.com/apache/pulsar/tree/master/.test-infra/jenkins And make sure all the changes made to Jenkins are under proper review. Thanks, Sijie On T

Disabling ci tests for documentation changes

2019-09-18 Thread Ali Ahmed
Currently there has been a growth in PR for documentation changes, but it's being slowed by the test run failures, we can relieve the issue, with some small changes. either not run the test if the git can't find a code change in files git diff --name-only HEAD master | grep -v site2 or change the