Re: Apache Pulsar coding guide

2019-11-03 Thread Jinfeng Huang
Hi Sijie, Thank you for your feedback. I'll take action in https://github.com/apache/pulsar/pull/5494. Best Regards, Jennifer On Sat, Nov 2, 2019 at 12:28 PM Sijie Guo wrote: > Jinfeng, > > Thank you for driving this effort! > > Given the tight dependencies between these two communities, I thi

Re: Apache Pulsar coding guide

2019-11-01 Thread Sijie Guo
Jinfeng, Thank you for driving this effort! Given the tight dependencies between these two communities, I think it is okay to use the coding guide from BookKeeper. A lot of Pulsar committers are also BookKeeper committers. Having a consistent coding guide between two communities would actually he

Re: Apache Pulsar coding guide

2019-10-30 Thread Jinfeng Huang
Shall we add a coding guide for Apache Pulsar? Do you have any advice on it? For details, refer to https://github.com/apache/pulsar/pull/5494. Best Regards, Jennifer On Tue, Oct 29, 2019 at 11:10 PM Jinfeng Huang wrote: > Hi all, > When our users read the contributing guidelines at > https://p

Apache Pulsar coding guide

2019-10-29 Thread Jinfeng Huang
Hi all, When our users read the contributing guidelines at https://pulsar.apache.org/en/contributing/#code , they found the link navigates to coding guide does not work. After investigation, we've found there is no coding guide for Apache Pulsar. Shall we add a coding guide for Apache Pulsar? I've