Re: [DISCUSS] PIP-221: Make TableView support read the non-persistent topic

2022-11-15 Thread Joe F
Introducing new system concepts as code change PR is really not the way to go about making these changes. The semantics and use case discussion should come first, so that they can be discussed and the implications understood. It's not a good experience to put this out there without providing a m

Re: [DISCUSS] PIP-221: Make TableView support read the non-persistent topic

2022-11-14 Thread Kai Wang
Hi Joe, > I am not sure about the semantics of TableView on a non-persistent topic. > What happens if the client crashes? What is the base state for the table? If users use a non-persistent topic as the TableView topic, when the client crashes, the TableViews data will be lose. The current u

Re: [DISCUSS] PIP-221: Make TableView support read the non-persistent topic

2022-11-14 Thread Kai Wang
Hi Michael, > What time is used to compute expiration? Is it the publish time or the > receive time? This TTL will be based on the message publish time. We can also make it configurable if users have this demand. > Also, are there cases that will reset a key's timer? If some keys need to reset t

Re: [DISCUSS] PIP-221: Make TableView support read the non-persistent topic

2022-11-14 Thread Joe F
I am not sure about the semantics of TableView on a non-persistent topic. Exactly how does this work? What happens if the client crashes? What is the base state for the table? What exactly can I expect as a user from this? Joe On Sun, Nov 13, 2022 at 8:57 PM Kai Wang wrote: > Hi, pulsar-d

Re: [DISCUSS] PIP-221: Make TableView support read the non-persistent topic

2022-11-14 Thread Michael Marshall
> And this PIP title has been changed to `Make TableView support TTL`. What time is used to compute expiration? Is it the publish time or the receive time? Also, are there cases that will reset a key's timer? Thanks, Michael On Mon, Nov 14, 2022 at 2:40 AM Enrico Olivelli wrote: > > Il giorno l

Re: [DISCUSS] PIP-221: Make TableView support read the non-persistent topic

2022-11-14 Thread Enrico Olivelli
Il giorno lun 14 nov 2022 alle ore 05:57 Kai Wang ha scritto: > > Hi, pulsar-dev community, > > Since the non-persistent topic support doesn't require API changes. I have > pushed a PR to implement it, which has already been merged. > > See: https://github.com/apache/pulsar/pull/18375 Perfect T

Re: [DISCUSS] PIP-221: Make TableView support read the non-persistent topic

2022-11-13 Thread Kai Wang
Hi, pulsar-dev community, Since the non-persistent topic support doesn't require API changes. I have pushed a PR to implement it, which has already been merged. See: https://github.com/apache/pulsar/pull/18375 And this PIP title has been changed to `Make TableView support TTL`. PIP link: http