Hi Baodi,
Good work. But I'm concerned about the names of these metrics. They
seem hard for users to understand. I've left some comments in the PR.
Also, is this thread a formal voting thread? If so, I suggest adding a
`[VOTE]` tag to the thread title for clarity.
Thanks,
Zike Yang
> For me, separating the metrics for messages and bytes makes it easier
for users to identify where the limitations are and adjust their
configurations accordingly.
Thanks for the explanation. That makes sense to me.
BR,
Zike Yang
On Fri, Mar 7, 2025 at 8:08 PM Baodi Shi wrote:
>
> hi, Zike.
>
hi, Zike.
Thanks for review.
For me, separating the metrics for messages and bytes makes it easier
for users to identify where the limitations are and adjust their
configurations accordingly.
What do you think?
> Also, is this thread a formal voting thread? If so, I suggest adding a
`[VOTE]` ta
te the PR accordingly
> > 3. Resume the vote once these corrections are made
> >
> > -Lari
> >
> > On Thu, 27 Feb 2025 at 15:37, Baodi Shi wrote:
> > >
> > > I would like to start voting thread for [improve][pip] PIP-406:
> > > Introduce metrics related to dispatch_throttled_count
> > >
> > > - PR: https://github.com/apache/pulsar/pull/23945
> > >
> > > - Discuss thread:
> > > https://lists.apache.org/thread/w9pq1jp3f22prsr97mxzj1yhdoo1cnc4
> > >
> > >
> > > Thanks,
> > > Baodi Shi
>
ages
> (more accurate, but more complex)
>
> I recommend we:
> 1. Address this design issue in the implementation
> 2. Update the PR accordingly
> 3. Resume the vote once these corrections are made
>
> -Lari
>
> On Thu, 27 Feb 2025 at 15:37, Baodi Shi wro
king to count unique throttled messages
> (more accurate, but more complex)
>
> I recommend we:
> 1. Address this design issue in the implementation
> 2. Update the PR accordingly
> 3. Resume the vote once these corrections are made
>
> -Lari
>
> On Thu, 2
accordingly
3. Resume the vote once these corrections are made
-Lari
On Thu, 27 Feb 2025 at 15:37, Baodi Shi wrote:
>
> I would like to start voting thread for [improve][pip] PIP-406:
> Introduce metrics related to dispatch_throttled_count
>
> - PR: https://github.com/apache/pu
I would like to start voting thread for [improve][pip] PIP-406:
Introduce metrics related to dispatch_throttled_count
- PR: https://github.com/apache/pulsar/pull/23945
- Discuss thread:
https://lists.apache.org/thread/w9pq1jp3f22prsr97mxzj1yhdoo1cnc4
Thanks,
Baodi Shi
