Re: [VOTE] Pulsar Release 2.8.0 Candidate 1

2021-06-08 Thread Chris Bartholomew
I agree that using 'fsGroup' is the proper solution.  If we are concerned about PR#10743 setting the permissions to 644 as a security risk, then why are we not also reverting it? If this is a legitimate problem, then are we not introducing a security risk in 2.8.0? Also, why not just revert it

Re: [VOTE] Pulsar Release 2.8.0 Candidate 1

2021-06-08 Thread Enrico Olivelli
Il giorno mar 8 giu 2021 alle ore 09:22 Sijie Guo ha scritto: > > Enrico, > > PR#10743 doesn't fix the problem and it actually made things worse. I am a > bit surprised that the change was merged without a review from other > committers who are more familiar with the Pulsar Functions codebase. > >

Re: [VOTE] Pulsar Release 2.8.0 Candidate 1

2021-06-08 Thread Sijie Guo
Enrico, PR#10743 doesn't fix the problem and it actually made things worse. I am a bit surprised that the change was merged without a review from other committers who are more familiar with the Pulsar Functions codebase. 1) First of all, the problem can happen when you using an old version of a b

Re: [VOTE] Pulsar Release 2.8.0 Candidate 1

2021-06-07 Thread Enrico Olivelli
Il Mar 8 Giu 2021, 03:32 PengHui Li ha scritto: > Hi Sijie, > > Thanks for the feedback, cancel the RC1 for now. > Please don't vote for this thread again, thanks. > > This is the PR > https://github.com/apache/pulsar/pull/10861#pullrequestreview-678011678 > for reverting https://github.com/apach

Re: [VOTE] Pulsar Release 2.8.0 Candidate 1

2021-06-07 Thread PengHui Li
Hi Sijie, Thanks for the feedback, cancel the RC1 for now. Please don't vote for this thread again, thanks. This is the PR https://github.com/apache/pulsar/pull/10861#pullrequestreview-678011678 for reverting https://github.com/apache/pulsar/pull/8796. After the PR merged, I will send out the RC2

Re: [VOTE] Pulsar Release 2.8.0 Candidate 1

2021-06-07 Thread Matteo Merli
Agree, there seems to be no way to fix this in the Helm charts because the functions stateful set is created outside Helm. Created a PR to revert: https://github.com/apache/pulsar/pull/10861 -- Matteo Merli On Mon, Jun 7, 2021 at 6:26 PM Sijie Guo wrote: > > Penghui, > > Unfortunately, I thin

Re: [VOTE] Pulsar Release 2.8.0 Candidate 1

2021-06-07 Thread Sijie Guo
Penghui, Unfortunately, I think we have to cancel this vote. The change https://github.com/apache/pulsar/pull/8796 has broken the Pulsar Functions running on Kubernetes. The Pulsar Functions Kubernetes runtime generates a secret and mounts it using mode `256`. That means the secret is only able

Re: [VOTE] Pulsar Release 2.8.0 Candidate 1

2021-06-07 Thread PengHui Li
Hi all, I have also pushed the docker image to my personal dockerhub account. If you want to verify on docker, you use use following images https://hub.docker.com/repository/docker/lph890127/pulsar https://hub.docker.com/repository/docker/lph890127/pulsar-all https://hub.docker.com/repository/doc

Re: [VOTE] Pulsar Release 2.8.0 Candidate 1

2021-06-07 Thread Matteo Merli
+1 binding Checked: * Signatures * Bin distribution: - NOTICE, README, LICENSE - Start standalone service and producer/consumer test * Src distribution: - NOTICE, README, LICENSE - Compile and unit tests - Start standalone service * Checked staging maven repository ar

[VOTE] Pulsar Release 2.8.0 Candidate 1

2021-06-07 Thread PengHui Li
This is the first release candidate for Apache Pulsar, version 2.8.0. It fixes the following issues:https://github.com/apache/pulsar/pulls?q=is%3Apr+milestone%3A2.8.0+-label%3Arelease%2F2.7.1+-label%3Arelease%2F2.7.2+is%3Aclosed *** Please download, test and vote on this release. This vote will s