Re: [VOTE] Pulsar Node.js Client Release 1.8.2 Candidate 2

2023-04-11 Thread Baodi Shi
Hi, tison. Thanks for your feedback. I noticed that the master branch also doesn't have NOTICE files. I'll add it first and then launch release 1.8.2-rc.3 Thanks, Baodi Shi On Apr 12, 2023 at 10:14:20, tison wrote: > Thank you! I can successfully run the example. > > However, -1 because the s

Re: [VOTE] Pulsar Node.js Client Release 1.8.2 Candidate 2

2023-04-11 Thread tison
Thank you! I can successfully run the example. However, -1 because the source release doesn't contain a NOTICE file. Other check items including LICENSE, license headers, checksum and GPG sign should be fine. Best, tison. Baodi Shi 于2023年4月12日周三 09:48写道: > This example connects test env. May

Re: [VOTE] Pulsar Node.js Client Release 1.8.2 Candidate 2

2023-04-11 Thread Baodi Shi
This example connects test env. Maybe it's network latency or server instability. You can try again. BTW: The token expires in tls-token.js . I updated it, you can pull the main branch and try it. Thanks, Baodi Shi On Apr 12, 2023 at 00:22:53, Zili Chen wrote: > Hi Baodi, > > When running t

Re: [VOTE] Pulsar Node.js Client Release 1.8.2 Candidate 2

2023-04-11 Thread Zili Chen
Hi Baodi, When running the tls test you provided, I encountered this error: $ node tls-oauth2.js [INFO][ClientConnection:190] [ -> pulsar+ssl://baodi-test-7407d844-b456-49e1-987c-24f1a5c162cb.usce1-whale.test.g.sn2.dev:6651] Create ClientConnection, timeout=1 [INFO][ConnectionPool:97] Crea

[VOTE] Pulsar Node.js Client Release 1.8.2 Candidate 2

2023-04-11 Thread Baodi Shi
Hi everyone, This is the first release candidate for Apache Pulsar Node.js client, version 1.8.2. It fixes the following issues: https://github.com/apache/pulsar-client-node/pulls?q=is%3Apr+label%3Arelease%2Fv1.8.2+is%3Aclosed Please download the source files and review this release candidate: -