Re: [VOTE] Pulsar Client C++ Release 3.5.0 Candidate 2

2024-03-15 Thread Yunze Xu
Close this vote by 3 binding +1s - Yunze - Penghui - Jiwei Thanks, Yunze On Fri, Mar 15, 2024 at 11:15 AM guo jiwei wrote: > > +1 (binding) > > - Verified checksum and signatures > - Built from source on macOS m1 > - Ran the tests > > Regards > Jiwei Guo (Tboy) > > > On Thu, Mar 14, 2024 at 9:12

Re: [VOTE] Pulsar Client C++ Release 3.5.0 Candidate 2

2024-03-14 Thread guo jiwei
+1 (binding) - Verified checksum and signatures - Built from source on macOS m1 - Ran the tests Regards Jiwei Guo (Tboy) On Thu, Mar 14, 2024 at 9:12 PM Yunze Xu wrote: > +1 (binding) > > - Verified checksum and signatures > - Built from source on macOS m1 > - Upgrade the dependency of the py

Re: [VOTE] Pulsar Client C++ Release 3.5.0 Candidate 2

2024-03-14 Thread PengHui Li
+1 (binding) - Checked the signature - Tested the pre-build binaries on Mac (m2 pro) Regards, Penghui On Thu, Mar 14, 2024 at 9:12 PM Yunze Xu wrote: > +1 (binding) > > - Verified checksum and signatures > - Built from source on macOS m1 > - Upgrade the dependency of the python client and veri

Re: [VOTE] Pulsar Client C++ Release 3.5.0 Candidate 2

2024-03-14 Thread Yunze Xu
+1 (binding) - Verified checksum and signatures - Built from source on macOS m1 - Upgrade the dependency of the python client and verified the issues are fixed (https://github.com/apache/pulsar-client-python/pull/202) Thanks, Yunze On Thu, Mar 14, 2024 at 6:13 PM Yunze Xu wrote: > > The vcpkg s

Re: [VOTE] Pulsar Client C++ Release 3.5.0 Candidate 2

2024-03-14 Thread Yunze Xu
The vcpkg submodule is just convenient for development. You can just run `git clone https://github.com/microsoft/vcpkg.git` in the source directory instead of fetching the submodule. BTW, I just found that when INTEGRATE_VCPKG is ON, we cannot customize the CMAKE_TOOLCHAIN_FILE. So I opened a PR t

Re: [VOTE] Pulsar Client C++ Release 3.5.0 Candidate 2

2024-03-14 Thread Baodi Shi
Hi, yunze https://dist.apache.org/repos/dist/dev/pulsar/pulsar-client-cpp/pulsar-client-cpp-3.5.0-candidate-2/apache-pulsar-client-cpp-3.5.0.tar.gz This source code not include vcpkg, If we unzip it and run the command cmake -B build -DINTEGRATE_VCPKG=ON, it throws an error. Do we need to include

[VOTE] Pulsar Client C++ Release 3.5.0 Candidate 2

2024-03-11 Thread Yunze Xu
This is the second release candidate for Apache Pulsar Client C++, version 3.5.0. It fixes the following issues: https://github.com/apache/pulsar-client-cpp/milestone/6?closed=1 *** Please download, test and vote on this release. This vote will stay open for at least 72 hours *** Note that we ar