Re: [VOTE] PIP-353: Improve transaction message visibility for peek-messages

2024-05-27 Thread Baodi Shi
Hi, all. >From this comment: https://github.com/apache/pulsar/pull/22762#discussion_r1615383124 I will use `---transaction-isolation-level` to instead of `--show-txn-uncommitted` and `--show-txn-aborted`. This way, we can maintain consistency with the interface behavior of the consume mentioned

Re: [VOTE] PIP-353: Improve transaction message visibility for peek-messages

2024-05-24 Thread Baodi Shi
Close this vote passed by 3 +1 binding: - zike - yubiao - jiwei Thanks, Baodi Shi On May 24, 2024 at 16:41:07, guo jiwei wrote: > +1 (binding) > > > Regards > Jiwei Guo (Tboy) > > > On Fri, May 24, 2024 at 8:29 AM Yubiao Feng > wrote: > > +1 (binding) > > > Thanks > > Yubiao Feng > > > On We

Re: [VOTE] PIP-353: Improve transaction message visibility for peek-messages

2024-05-24 Thread guo jiwei
+1 (binding) Regards Jiwei Guo (Tboy) On Fri, May 24, 2024 at 8:29 AM Yubiao Feng wrote: > +1 (binding) > > Thanks > Yubiao Feng > > On Wed, May 22, 2024 at 9:55 PM Baodi Shi wrote: > > > Hi, all > > > > I would like to start the voting thread for PIP-353. > > https://github.com/apache/pulsa

Re: [VOTE] PIP-353: Improve transaction message visibility for peek-messages

2024-05-23 Thread Yubiao Feng
+1 (binding) Thanks Yubiao Feng On Wed, May 22, 2024 at 9:55 PM Baodi Shi wrote: > Hi, all > > I would like to start the voting thread for PIP-353. > https://github.com/apache/pulsar/pull/22746 > > The implementation PR is: > https://github.com/apache/pulsar/pull/22762 > > Discuss thread: > htt

Re: [VOTE] PIP-353: Improve transaction message visibility for peek-messages

2024-05-22 Thread Zike Yang
+1 (binding) BR, Zike Yang On Wed, May 22, 2024 at 9:55 PM Baodi Shi wrote: > > Hi, all > > I would like to start the voting thread for PIP-353. > https://github.com/apache/pulsar/pull/22746 > > The implementation PR is: > https://github.com/apache/pulsar/pull/22762 > > Discuss thread: > https:/

[VOTE] PIP-353: Improve transaction message visibility for peek-messages

2024-05-22 Thread Baodi Shi
Hi, all I would like to start the voting thread for PIP-353. https://github.com/apache/pulsar/pull/22746 The implementation PR is: https://github.com/apache/pulsar/pull/22762 Discuss thread: https://lists.apache.org/thread/dc7f64jtvg987ydztxpffqx88bp44lwv Thanks, Baodi Shi