Re: [VOTE] PIP-345: Optimize finding message by timestamp

2024-03-25 Thread PengHui Li
Hi, Jiuming Yes, it's not a good one "ManagedLedger#getEarliestM essagePublishTimeInBacklog" and it should be the only one in the ManagedLedger to have a publish time concept. I think we mixed the concepts in https://github.com/apache/pulsar/pull/12523, which is bad. It's better to start a proposa

Re: [VOTE] PIP-345: Optimize finding message by timestamp

2024-03-25 Thread 太上玄元道君
Hi Penghui, Thanks for your feedback! I'm not sure about this either, since publishTimestamp is a Messaging layer concept, and ML as a Persistence layer should not be aware about this. But in ML, I'd noticed some methods searching message by PublishTimestamp(say, ManagedLedgerImpl#getEarliestMes

Re: [VOTE] PIP-345: Optimize finding message by timestamp

2024-03-25 Thread PengHui Li
Hi, Jiuming I'm sorry for not getting back to you sooner. First, I support the motivation to optimize this case because it could be a significant blocker for users who want infinite data retention, which is a BIG differentiator with Apache Kafka. And, I really saw the cases with high publish thro

Re: [VOTE] PIP-345: Optimize finding message by timestamp

2024-03-24 Thread 太上玄元道君
bump 太上玄元道君 于2024年3月20日 周三16:23写道: > bump > > 太上玄元道君 于2024年3月19日 周二19:35写道: > >> Hi Pulsar community, >> >> This thread is to start a vote for PIP-345: Optimize finding message by >> timestamp >> >> PIP: https://github.com/apache/pulsar/pull/22234 >> Discuss thread: >> https://lists.apache.org/th

Re: [VOTE] PIP-345: Optimize finding message by timestamp

2024-03-20 Thread 太上玄元道君
bump 太上玄元道君 于2024年3月19日 周二19:35写道: > Hi Pulsar community, > > This thread is to start a vote for PIP-345: Optimize finding message by > timestamp > > PIP: https://github.com/apache/pulsar/pull/22234 > Discuss thread: > https://lists.apache.org/thread/5owc9os6wmy52zxbv07qo2jrfjm17hd2 > > Thanks, >

[VOTE] PIP-345: Optimize finding message by timestamp

2024-03-19 Thread 太上玄元道君
Hi Pulsar community, This thread is to start a vote for PIP-345: Optimize finding message by timestamp PIP: https://github.com/apache/pulsar/pull/22234 Discuss thread: https://lists.apache.org/thread/5owc9os6wmy52zxbv07qo2jrfjm17hd2 Thanks, Tao Jiuming