Re: [RESULT] [VOTE] PIP-342: Support OpenTelemetry metrics in Pulsar client

2024-03-25 Thread PengHui Li
Sorry, I forgot to submit my PR review before. Just some minor comments about the names. Please take a look. Regards, Penghui On Fri, Mar 22, 2024 at 11:21 PM Matteo Merli wrote: > Closing this vote with 4 binding and 4 non-binding +1s > > Binding +1s: > * Lari > * Mattison > * PengHui > *

[RESULT] [VOTE] PIP-342: Support OpenTelemetry metrics in Pulsar client

2024-03-22 Thread Matteo Merli
Closing this vote with 4 binding and 4 non-binding +1s Binding +1s: * Lari * Mattison * PengHui * Matteo Non-Binding +1s: * Dao Jun * Apurva * Asaf * Zixuan Thanks, Matteo -- Matteo Merli On Thu, Mar 14, 2024 at 11:54 PM Zixuan Liu wrote: > +1 (non-binding) > > Thanks, > Zixuan >

Re: [VOTE] PIP-342: Support OpenTelemetry metrics in Pulsar client

2024-03-14 Thread Zixuan Liu
+1 (non-binding) Thanks, Zixuan PengHui Li 于2024年3月15日周五 09:47写道： > +1 (binding) > > Regards, > Penghui > > On Fri, Mar 15, 2024 at 2:32 AM Asaf Mesika wrote: > > > +1 (non-binding) > > > > On Thu, Mar 14, 2024 at 8:29 PM Apurva Telang > > wrote: > > > > > +1 (non-binding) > > > > > > On Thu,

Re: [VOTE] PIP-342: Support OpenTelemetry metrics in Pulsar client

2024-03-14 Thread PengHui Li
+1 (binding) Regards, Penghui On Fri, Mar 15, 2024 at 2:32 AM Asaf Mesika wrote: > +1 (non-binding) > > On Thu, Mar 14, 2024 at 8:29 PM Apurva Telang > wrote: > > > +1 (non-binding) > > > > On Thu, Mar 14, 2024 at 2:12 AM mattison chao > > wrote: > > > > > +1 (binding) > > > > > > Best, > > >

Re: [VOTE] PIP-342: Support OpenTelemetry metrics in Pulsar client

2024-03-14 Thread Asaf Mesika
+1 (non-binding) On Thu, Mar 14, 2024 at 8:29 PM Apurva Telang wrote: > +1 (non-binding) > > On Thu, Mar 14, 2024 at 2:12 AM mattison chao > wrote: > > > +1 (binding) > > > > Best, > > Mattison > > On Mar 14, 2024 at 15:55 +0800, Lari Hotari , wrote: > > > +1 (binding) > > > > > > -Lari > > > >

Re: [VOTE] PIP-342: Support OpenTelemetry metrics in Pulsar client

2024-03-14 Thread Apurva Telang
+1 (non-binding) On Thu, Mar 14, 2024 at 2:12 AM mattison chao wrote: > +1 (binding) > > Best, > Mattison > On Mar 14, 2024 at 15:55 +0800, Lari Hotari , wrote: > > +1 (binding) > > > > -Lari > > > > On Thu, 14 Mar 2024 at 03:45, Matteo Merli > wrote: > > > > > > PIP: https://github.com/apache/

Re: [VOTE] PIP-342: Support OpenTelemetry metrics in Pulsar client

2024-03-14 Thread mattison chao
+1 (binding) Best, Mattison On Mar 14, 2024 at 15:55 +0800, Lari Hotari , wrote: > +1 (binding) > > -Lari > > On Thu, 14 Mar 2024 at 03:45, Matteo Merli wrote: > > > > PIP: https://github.com/apache/pulsar/pull/22178 > > > > WIP PR: https://github.com/apache/pulsar/pull/22179 > > > > > > > > > >

Re: [VOTE] PIP-342: Support OpenTelemetry metrics in Pulsar client

2024-03-14 Thread Lari Hotari
+1 (binding) -Lari On Thu, 14 Mar 2024 at 03:45, Matteo Merli wrote: > > PIP: https://github.com/apache/pulsar/pull/22178 > > WIP PR: https://github.com/apache/pulsar/pull/22179 > > > > > -- > Matteo Merli >

Re: [VOTE] PIP-342: Support OpenTelemetry metrics in Pulsar client

2024-03-13 Thread 太上玄元道君
+1 nonbinding Matteo Merli 于2024年3月14日周四 09:45写道： > PIP: https://github.com/apache/pulsar/pull/22178 > > WIP PR: https://github.com/apache/pulsar/pull/22179 > > > > > -- > Matteo Merli > >

[VOTE] PIP-342: Support OpenTelemetry metrics in Pulsar client

2024-03-13 Thread Matteo Merli
PIP: https://github.com/apache/pulsar/pull/22178 WIP PR: https://github.com/apache/pulsar/pull/22179 -- Matteo Merli