Re: [VOTE] PIP-293: Delete config `disableBrokerInterceptors`

2023-08-20 Thread guo jiwei
Thanks. Close the vote with 3(binding) + 1(non-binding). Regards Jiwei Guo (Tboy) On Mon, Aug 21, 2023 at 9:32 AM Hang Chen wrote: > +1 (binding) > > Thanks, > Hang > > 于2023年8月18日周五 06:33写道: > > > > +1 (binding) > > > > > > Best, > > Mattison > > On 15 Aug 2023 at 16:24 +0800, guo jiwei ,

Re: [VOTE] PIP-293: Delete config `disableBrokerInterceptors`

2023-08-20 Thread Hang Chen
+1 (binding) Thanks, Hang 于2023年8月18日周五 06:33写道: > > +1 (binding) > > > Best, > Mattison > On 15 Aug 2023 at 16:24 +0800, guo jiwei , wrote: > > Hi dev, > > There is a config in ServiceConfiguration called > > `disableBrokerInterceptors` introduced by #8157 > >

Re: [VOTE] PIP-293: Delete config `disableBrokerInterceptors`

2023-08-17 Thread mattisonchao
+1 (binding) Best, Mattison On 15 Aug 2023 at 16:24 +0800, guo jiwei , wrote: > Hi dev, > There is a config in ServiceConfiguration called > `disableBrokerInterceptors` introduced by #8157 > , it looks to disable the > broker interceptor, but commented

Re: [VOTE] PIP-293: Delete config `disableBrokerInterceptors`

2023-08-17 Thread PengHui Li
+1 (binding) Thanks, Penghui On Wed, Aug 16, 2023 at 4:40 PM Zixuan Liu wrote: > +1(non-binding) > > Thanks, > Zixuan > > guo jiwei 于2023年8月15日周二 16:24写道: > > > > Hi dev, > >There is a config in ServiceConfiguration called > > `disableBrokerInterceptors` introduced by #8157 > >

Re: [VOTE] PIP-293: Delete config `disableBrokerInterceptors`

2023-08-16 Thread Zixuan Liu
+1(non-binding) Thanks, Zixuan guo jiwei 于2023年8月15日周二 16:24写道: > > Hi dev, >There is a config in ServiceConfiguration called > `disableBrokerInterceptors` introduced by #8157 > , it looks to disable the > broker interceptor, but commented for usin

[VOTE] PIP-293: Delete config `disableBrokerInterceptors`

2023-08-15 Thread guo jiwei
Hi dev, There is a config in ServiceConfiguration called `disableBrokerInterceptors` introduced by #8157 , it looks to disable the broker interceptor, but commented for using test only. In actual, we judge whether enable the interceptor by judging whe