Re: [VOTE] PIP-281: Add notifyError method on PushSource

2023-08-02 Thread Baodi Shi
Close this vote by 3 binding +1s - Penghui - Yunze - Jiwei And 2 non-binding +1s - Zike - Rui Thanks, Baodi Shi On Aug 2, 2023 at 10:47:32, guo jiwei wrote: > +1 (binding) > > > Regards > Jiwei Guo (Tboy) > > > On Tue, Aug 1, 2023 at 10:24 AM Rui Fu wrote: > > +1 > > > Bes

Re: [VOTE] PIP-281: Add notifyError method on PushSource

2023-08-01 Thread guo jiwei
+1 (binding) Regards Jiwei Guo (Tboy) On Tue, Aug 1, 2023 at 10:24 AM Rui Fu wrote: > +1 > > Best, > > Rui Fu > On Jul 25, 2023 at 18:10 +0800, Baodi Shi , wrote: > > Hello, > > > > This is the vote thread for PIP 281. > > > > PR: https://github.com/apache/pulsar/pull/20807 > > Discussion: >

Re: [VOTE] PIP-281: Add notifyError method on PushSource

2023-07-31 Thread Rui Fu
+1 Best, Rui Fu On Jul 25, 2023 at 18:10 +0800, Baodi Shi , wrote: > Hello, > > This is the vote thread for PIP 281. > > PR: https://github.com/apache/pulsar/pull/20807 > Discussion: https://lists.apache.org/thread/dnmvcb5drvwhw4bpyq6x572hcdtyydfg > > The vote will be open for at least 48 hours.

Re: [VOTE] PIP-281: Add notifyError method on PushSource

2023-07-31 Thread Yunze Xu
I see the PIP number has conflicts with https://github.com/apache/pulsar/pull/20748, could you modify the PIP number since 20748 is earlier. Thanks, Yunze On Mon, Jul 31, 2023 at 4:02 PM Yunze Xu wrote: > > +1 (binding) > > Though there are some syntax errors in this PR. > > Thanks, > Yunze > >

Re: [VOTE] PIP-281: Add notifyError method on PushSource

2023-07-31 Thread Yunze Xu
+1 (binding) Though there are some syntax errors in this PR. Thanks, Yunze On Tue, Jul 25, 2023 at 8:04 PM PengHui Li wrote: > > +1(binding) > > Please do not merge the PIP PR before closing the VOTE. > > Regards, > Penghui > > On Tue, Jul 25, 2023 at 6:27 PM Zike Yang wrote: > > > +1 > > > >

Re: [VOTE] PIP-281: Add notifyError method on PushSource

2023-07-25 Thread PengHui Li
+1(binding) Please do not merge the PIP PR before closing the VOTE. Regards, Penghui On Tue, Jul 25, 2023 at 6:27 PM Zike Yang wrote: > +1 > > Thanks, > Zike Yang > > On Tue, Jul 25, 2023 at 6:10 PM Baodi Shi wrote: > > > > Hello, > > > > This is the vote thread for PIP 281. > > > > PR: https

Re: [VOTE] PIP-281: Add notifyError method on PushSource

2023-07-25 Thread Zike Yang
+1 Thanks, Zike Yang On Tue, Jul 25, 2023 at 6:10 PM Baodi Shi wrote: > > Hello, > > This is the vote thread for PIP 281. > > PR: https://github.com/apache/pulsar/pull/20807 > Discussion: https://lists.apache.org/thread/dnmvcb5drvwhw4bpyq6x572hcdtyydfg > > The vote will be open for at least 48 h

[VOTE] PIP-281: Add notifyError method on PushSource

2023-07-25 Thread Baodi Shi
Hello, This is the vote thread for PIP 281. PR: https://github.com/apache/pulsar/pull/20807 Discussion: https://lists.apache.org/thread/dnmvcb5drvwhw4bpyq6x572hcdtyydfg The vote will be open for at least 48 hours. Thanks, Baodi Shi