Re: [VOTE] PIP-272

2023-06-09 Thread Yunze Xu
+1 (binding) Thanks, Yunze On Thu, Jun 8, 2023 at 8:38 PM Asaf Mesika wrote: > > After several ping pongs over the PR, I'm changing my vote: > > +1 (non-binding) > > Just please make sure to review all pending grammar suggestions. > > On Tue, Jun 6, 2023 at 10:53 PM Asaf Mesika wrote: > > > I'm

Re: [VOTE] PIP-272

2023-06-08 Thread Asaf Mesika
After several ping pongs over the PR, I'm changing my vote: +1 (non-binding) Just please make sure to review all pending grammar suggestions. On Tue, Jun 6, 2023 at 10:53 PM Asaf Mesika wrote: > I'm sorry for not getting back to you sooner: Weekend, work, etc. > > I vote -1 (non-binding), as I

Re: [VOTE] PIP-272

2023-06-06 Thread Asaf Mesika
I'm sorry for not getting back to you sooner: Weekend, work, etc. I vote -1 (non-binding), as I found something rather disturbing in the design. Can we please go back to the discussion (in the PR)? Rui Fu - I see you voted +1 (binding) - what do you think about the comments I've made? Thanks!

Re: [VOTE] PIP-272

2023-06-05 Thread Rui Fu
+1 Best, Rui Fu On Jun 6, 2023 at 09:50 +0800, Pengcheng Jiang , wrote: > Hello, community: > > This thread is to start a vote for PIP-272: Add stateStorageConfig to > WorkerConfig. > > Discussion thread: > https://lists.apache.org/thread/pwfv7nj64frfnbw7jfydzx8my15b3lj6 > PR: https://github.com

[VOTE] PIP-272

2023-06-05 Thread Pengcheng Jiang
Hello, community: This thread is to start a vote for PIP-272: Add stateStorageConfig to WorkerConfig. Discussion thread: https://lists.apache.org/thread/pwfv7nj64frfnbw7jfydzx8my15b3lj6 PR: https://github.com/apache/pulsar/pull/20455 Sincerely Pengcheng Jiang