Hi guys,
Please help review https://github.com/apache/pulsar/pull/19158, which
has been pending for a while. I see 2.12.0 (or 3.0.0?) is coming, I
hope we can include this PIP in the next major release.
Thanks,
Yunze
On Wed, Dec 28, 2022 at 10:40 PM Yunze Xu wrote:
>
> Hi Enrico,
>
> Yeah, I've
Hi Enrico,
Yeah, I've discussed it privately with Hang and he had the same
concern with you and. So I changed the `Schema` to a
more simple class:
```java
class TopicMessageIdSerDes {
public static byte[] serialize(TopicMessageId topicMessageId) {/* ... */}
public static TopicMessageId d
Schema doesn't make much sense to me.
Schema is a Pulsar Client API to deal with Message serialisation, it
is not a general purpose serde framework.
I still approve the PIP overall but I don't think we should expose
such things to the user facing APIs
Il giorno mer 28 dic 2022 alle ore 09:15 Han
+1 (binding)
Thanks,
Hang
Yunze Xu 于2022年12月28日周三 11:53写道：
>
> After discussing with @hangc0276 offline, I decided to add a
> `Schema` implementation in this proposal to serialize
> both the owner topic and the base `MessageId`. You can see the latest
> update on GitHub. If any of you have any c
After discussing with @hangc0276 offline, I decided to add a
`Schema` implementation in this proposal to serialize
both the owner topic and the base `MessageId`. You can see the latest
update on GitHub. If any of you have any concern, feel free to let me
know.
Thanks,
Yunze
On Mon, Dec 26, 2022 a
+1 (binding)
Enrico
Il Ven 23 Dic 2022, 05:46 Yunze Xu ha
scritto:
> It needs the 3rd binding +1 yet. Could anyone else take a look?
>
> Thanks,
> Yunze
>
> On Wed, Dec 21, 2022 at 3:21 PM 丛搏 wrote:
> >
> > Hi Yunze,
> >
> > add `TopicMessageId ` will couple messageID and `topic name` together
It needs the 3rd binding +1 yet. Could anyone else take a look?
Thanks,
Yunze
On Wed, Dec 21, 2022 at 3:21 PM 丛搏 wrote:
>
> Hi Yunze,
>
> add `TopicMessageId ` will couple messageID and `topic name` together,
> which is very unclear for non-partition-topic.
>
> ```
> void seek(String topicName,
Hi Yunze,
add `TopicMessageId ` will couple messageID and `topic name` together,
which is very unclear for non-partition-topic.
```
void seek(String topicName, MessageId messageId) throws PulsarClientException;
List> getLastTopicMessageId() throws
PulsarClientException;
```
If the interface is de
Yeah, it's an implementation detail and I will keep the same semantics
with the latest master when I push my PR.
Thanks,
Yunze
On Fri, Dec 16, 2022 at 3:03 PM 丛搏 wrote:
>
> if you don't change this in PIP-229 or PIP-224, I will create a new
> PIP to handle the `BatchMessageIdImpl` and `MessageId
if you don't change this in PIP-229 or PIP-224, I will create a new
PIP to handle the `BatchMessageIdImpl` and `MessageIdImpl`
`compareTo()` method, now I have no problem with this PIP
+1 (non-binding)
Sorry to bother this PIP vote.
Thanks,
Bo
Yunze Xu 于2022年12月16日周五 11:58写道：
>
> If this breakin
If this breaking change can pass the PMC votes, I will keep the new
semantics in PIP-229. Otherwise, it would not make sense to adopt the
new semantics in PIP-229.
Thanks,
Yunze
On Fri, Dec 16, 2022 at 11:46 AM Yunze Xu wrote:
>
> I cannot find any confusing code from the proposal itself. Could
I cannot find any confusing code from the proposal itself. Could you
point it out? If you are mentioning the `legacyCompare` and `compare`
methods in #18890 [1], it's not related to this proposal. And I have
opened PIP-229 [2] for discussion.
BTW, the PIP-229 itself doesn't mention the compare log
Although unrelated, it adds a lot of confusing code.
Thanks,
Bo
Yunze Xu 于2022年12月16日周五 08:05写道：
>
> This proposal is not related to the comparison logic between
> BatchMessageIdImpl and MessageIdImpl.
>
> Thanks,
> Yunze
>
> On Thu, Dec 15, 2022 at 12:58 PM 丛搏 wrote:
> >
> > -1 (non-binding)
This proposal is not related to the comparison logic between
BatchMessageIdImpl and MessageIdImpl.
Thanks,
Yunze
On Thu, Dec 15, 2022 at 12:58 PM 丛搏 wrote:
>
> -1 (non-binding)
> sorry, I have one question about the BatchMessageId compareTo()
> method. the discussion mail :
> https://lists.apach
-1 (non-binding)
sorry, I have one question about the BatchMessageId compareTo()
method. the discussion mail :
https://lists.apache.org/thread/8n3oyk2hdsskkotnj4lnlvfnndctpqbg.
I hope it can be this issue can be discussed clearly.
I hope it can be this issue can be discussed clearly. I will retry
+1 (non-binding)
Thanks,
Bo
PengHui Li 于2022年12月14日周三 19:12写道：
>
> +1 (binding)
>
> - Penghui
>
> On Sun, Dec 11, 2022 at 6:36 AM Enrico Olivelli wrote:
>
> > +1 (binding)
> >
> > Enrico
> >
> > Il Ven 9 Dic 2022, 10:41 Jiaqi Shen ha scritto:
> >
> > > +1(non-binding)
> > >
> > > Thanks,
> > >
+1 (binding)
- Penghui
On Sun, Dec 11, 2022 at 6:36 AM Enrico Olivelli wrote:
> +1 (binding)
>
> Enrico
>
> Il Ven 9 Dic 2022, 10:41 Jiaqi Shen ha scritto:
>
> > +1(non-binding)
> >
> > Thanks,
> > Jiaqi Shen
> >
> >
> > 于2022年12月5日周一 15:23写道：
> >
> > > +1(non-binding)
> > >
> > > Best,
> > >
+1 (binding)
Enrico
Il Ven 9 Dic 2022, 10:41 Jiaqi Shen ha scritto:
> +1(non-binding)
>
> Thanks,
> Jiaqi Shen
>
>
> 于2022年12月5日周一 15:23写道：
>
> > +1(non-binding)
> >
> > Best,
> > Mattison
> > On Dec 5, 2022, 15:09 +0800, Zike Yang , wrote:
> > > +1(non-binding)
> > >
> > > Best,
> > > Zike Ya
+1(non-binding)
Thanks,
Jiaqi Shen
于2022年12月5日周一 15:23写道：
> +1(non-binding)
>
> Best,
> Mattison
> On Dec 5, 2022, 15:09 +0800, Zike Yang , wrote:
> > +1(non-binding)
> >
> > Best,
> > Zike Yang
> >
> > On Mon, Dec 5, 2022 at 2:41 PM Baodi Shi
> wrote:
> > >
> > > +1(non-binding)
> > >
> > >
+1(non-binding)
Best,
Mattison
On Dec 5, 2022, 15:09 +0800, Zike Yang , wrote:
> +1(non-binding)
>
> Best,
> Zike Yang
>
> On Mon, Dec 5, 2022 at 2:41 PM Baodi Shi wrote:
> >
> > +1(non-binding)
> >
> > Thanks,
> > Baodi Shi
> >
> > > > 2022年12月5日 12:51，Yunze Xu 写道：
> > > >
> > > > Hi all,
> > >
+1(non-binding)
Best,
Zike Yang
On Mon, Dec 5, 2022 at 2:41 PM Baodi Shi wrote:
>
> +1(non-binding)
>
> Thanks,
> Baodi Shi
>
> > 2022年12月5日 12:51，Yunze Xu 写道：
> >
> > Hi all,
> >
> > I'm starting the vote for PIP-224: Introduce TopicMessageId for
> > consumer's MessageId related APIs:
> > http
+1(non-binding)
Thanks,
Baodi Shi
> 2022年12月5日 12:51，Yunze Xu 写道：
>
> Hi all,
>
> I'm starting the vote for PIP-224: Introduce TopicMessageId for
> consumer's MessageId related APIs:
> https://github.com/apache/pulsar/issues/18616
>
> Here is the discussion thread:
> https://lists.apache.org/
Hi all,
I'm starting the vote for PIP-224: Introduce TopicMessageId for
consumer's MessageId related APIs:
https://github.com/apache/pulsar/issues/18616
Here is the discussion thread:
https://lists.apache.org/thread/jhqy65cdyxzmmxnfsjm8rv9pbk76noxy
The vote will be open for at least 3 days.
Tha
23 matches
Mail list logo
