Re: [VOTE] PIP-174: Provide new implementation for broker dispatch cache

2022-08-09 Thread Michael Marshall
+1 - thanks for a great write up Matteo, it looks like it'll be a great improvement! (Sorry for casting a late vote, but I figure it's worth affirming the PIP even if we've already closed the vote.) Thanks, Michael On Sun, Jul 24, 2022 at 9:32 PM Matteo Merli wrote: > > Closing this vote with 3

Re: [VOTE] PIP-174: Provide new implementation for broker dispatch cache

2022-07-24 Thread Matteo Merli
Closing this vote with 3 +1s and no -1s: +1s: * Matteo * PengHui * Dave Thanks, Matteo -- Matteo Merli On Thu, Jul 21, 2022 at 7:58 PM Dave Fisher wrote: > > Sorry I’m late to this discussion. > > I think that the motivation is correct. There is really quite a bit of > activity around thi

Re: [VOTE] PIP-174: Provide new implementation for broker dispatch cache

2022-07-21 Thread Dave Fisher
Sorry I’m late to this discussion. I think that the motivation is correct. There is really quite a bit of activity around this issue. Let’s take extra efforts to engage extra time with commits to confirm performance improvements. Let’s particularly pay attention to threading. +1 Regards, Dave

Re: [VOTE] PIP-174: Provide new implementation for broker dispatch cache

2022-07-21 Thread PengHui Li
+1 Penghui Li On Jul 22, 2022, 02:37 +0800, Matteo Merli , wrote: > ## Motivation > > The current implementation of the read cache in the Pulsar broker has largely > remained unchanged for a long time, except for a few minor tweaks. > > While the implementation is stable and reasonably efficient f

[VOTE] PIP-174: Provide new implementation for broker dispatch cache

2022-07-21 Thread Matteo Merli
## Motivation The current implementation of the read cache in the Pulsar broker has largely remained unchanged for a long time, except for a few minor tweaks. While the implementation is stable and reasonably efficient for typical workloads, the overhead required for managing the cache evictions